New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774380 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tooltip is seen missing for 'Open' file in file manager while tabbing twice

Project Member Reported by rkalavakuntla@chromium.org, Oct 13 2017

Issue description

Chrome Version:63.0.3238.0/10028.0.0 dev channel Blaze,Paine,Falco
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user -> Take any sample screenshot ->click on SPACE to Get info 
(2)Now press tab continuously and Observe that for second time tool tip is seen missing for 'Open'(Please refer video)

Actual:While pressing tab continuously,for second time tool tip is seen missing for 'Open' even if focus is on Open.
Expected:Tool-tip should be seen for Open when focus is on Open

This is a Regression issue as same is working fine in 63.0.3236.0/10024.0.0 dev channel Paine

@fukino: Please confirm the above issue.

Note: Issue is not seen for Linux,Windows OS



 
actual.webm
1.2 MB View Download
expected.webm
1.3 MB View Download

Comment 1 by fukino@chromium.org, Oct 13 2017

Cc: fukino@chromium.org
Owner: yamaguchi@chromium.org
yamaguchi@, could you take a look?
Status: Started (was: Assigned)
Labels: MERGE
Status: Fixed (was: Started)
I have reverted the change in master that caused this issue.
Since M63 is not branched yet, it will fix this issue in M63.
  https://chromium.googlesource.com/chromium/src.git/+/bc19783572cb7a575421da6a2b67fb54abef0d75

commit bc19783572cb7a575421da6a2b67fb54abef0d75
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Oct 13 12:34:54 2017

Revert "Do not show tooltip when focus moved as a result of mouse operation."

This reverts commit 10a97df6559061ad5b81e9be7b59dd616fb44fe0.

Reason for revert: It caused regression crbug/774380

Original change's description:
> Do not show tooltip when focus moved as a result of mouse operation.
> 
> Focus is also moved a menu-button after executing or dismissing menu
> by mouse/touch. In such case we should not show the tooltip unlike when
> manually focusing it by keyboard.
> 
> As a side effect, tooltip will not appear when focusing by keyboard
> when button focus is made invisible by  Issue 748489 . It will be resolved
> when  Issue 748489  is fixed.
> 
> Bug:   769593  
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ieda9e391117103d91ddad584705173674b3470ae
> Reviewed-on: https://chromium-review.googlesource.com/700116
> Reviewed-by: Naoki Fukino <fukino@chromium.org>
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507616}

TBR=fukino@chromium.org,yamaguchi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:   769593  
Change-Id: Ieb1442e647ff5db03433438b8eb3338276e98853
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/718217
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508678}
[modify] https://crrev.com/bc19783572cb7a575421da6a2b67fb54abef0d75/ui/file_manager/file_manager/foreground/elements/files_tooltip.js
[modify] https://crrev.com/bc19783572cb7a575421da6a2b67fb54abef0d75/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js
Labels: -MERGE
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-63
Now I found the change was submitted after the branch point.

Comment 7 by gkihumba@google.com, Oct 16 2017

Labels: Merge-Approved-63

Comment 8 by gkihumba@google.com, Oct 16 2017

Labels: -Merge-Request-63
Labels: -Merge-Approved-63 merge-merged-3239
The patch has been merged.

Here is the automated comment from
https://bugs.chromium.org/p/chromium/issues/detail?id=769593#c10


commit a1e1d8b4c863bd447d75b4c8ecc4ff638b392280
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Oct 17 01:33:19 2017

Revert "Do not show tooltip when focus moved as a result of mouse operation."

This reverts commit 10a97df6559061ad5b81e9be7b59dd616fb44fe0.

Reason for revert: It caused regression crbug/774380

Original change's description:
> Do not show tooltip when focus moved as a result of mouse operation.
> 
> Focus is also moved a menu-button after executing or dismissing menu
> by mouse/touch. In such case we should not show the tooltip unlike when
> manually focusing it by keyboard.
> 
> As a side effect, tooltip will not appear when focusing by keyboard
> when button focus is made invisible by  Issue 748489 . It will be resolved
> when  Issue 748489  is fixed.
> 
> Bug:  769593 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ieda9e391117103d91ddad584705173674b3470ae
> Reviewed-on: https://chromium-review.googlesource.com/700116
> Reviewed-by: Naoki Fukino <fukino@chromium.org>
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507616}

TBR=fukino@chromium.org,yamaguchi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  769593 
Change-Id: Ieb1442e647ff5db03433438b8eb3338276e98853
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/718217
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508678}(cherry picked from commit bc19783572cb7a575421da6a2b67fb54abef0d75)
Reviewed-on: https://chromium-review.googlesource.com/722459
Cr-Commit-Position: refs/branch-heads/3239@{#24}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/a1e1d8b4c863bd447d75b4c8ecc4ff638b392280/ui/file_manager/file_manager/foreground/elements/files_tooltip.js
[modify] https://crrev.com/a1e1d8b4c863bd447d75b4c8ecc4ff638b392280/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js

Status: Verified (was: Fixed)

Sign in to add a comment