https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/67381
Fixed by engedy: https://chromium-review.googlesource.com/c/chromium/src/+/718396
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c5247ff645640403c5467c93307512d2fb4a343 commit 8c5247ff645640403c5467c93307512d2fb4a343 Author: Charles Harrison <csharrison@chromium.org> Date: Fri Oct 13 19:43:32 2017 Reland Strong Popup Blocker This CL squashes three reverted CLs: 1. crrev.com/508415 2. crrev.com/508433 3. crrev.com/508522 These were all reverted due to crbug.com/774367 , caused by executing a posted task on a deleted object (the fake database manager) with PlzNavigate disabled. The initial upload is just the raw squash of the three CLs. The subsequent patches apply the fix. Verified by running SafeBrowsingTriggeredPopupBlockerTest.FailNavigation_MaintainsBlocking On a debug Linux build with --disable-browser-side-navigation. TBR=sky@chromium.org,holte@chromium.org Bug: 761385 , 774367 Change-Id: Ibff1a7bea7d1ca9df03060ab71852d589815cd5d Reviewed-on: https://chromium-review.googlesource.com/718744 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#508783} [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/DEPS [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/BUILD.gn [add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/console_logger.cc [add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/console_logger.h [add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc [add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h [add] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/chrome/test/BUILD.gn [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/tools/metrics/histograms/enums.xml [modify] https://crrev.com/8c5247ff645640403c5467c93307512d2fb4a343/tools/metrics/histograms/histograms.xml
Comment 1 by yhirano@chromium.org
, Oct 13 2017