Issue metadata
Sign in to add a comment
|
DOMWrapperWorld.Basic is consistently flaky |
||||||||||||||||||||||||
Issue description
1. Run all webkit_unit_tests.
2. Observe that DOMWrapperWorld.Basic always fails the first run.
Failing output:
[355/6925] ActivityLoggerTest.RequestResource (121 ms)
[ RUN ] DOMWrapperWorldTest.Basic
../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp:91: Failure
Value of: DOMWrapperWorld::NonMainWorldsExistInMainThread()
Actual: true
Expected: false
../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp:94: Failure
Expected: 1u
Which is: 1
To be equal to: retrieved_worlds.size()
Which is: 2
../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp:137: Failure
Expected: worlds.size() + 1
Which is: 4
To be equal to: retrieved_worlds.size()
Which is: 5
../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp:146: Failure
Value of: DOMWrapperWorld::NonMainWorldsExistInMainThread()
Actual: true
Expected: false
../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp:148: Failure
Expected: 1u
Which is: 1
To be equal to: retrieved_worlds.size()
Which is: 2
[ FAILED ] DOMWrapperWorldTest.Basic (17 ms)
[356/6925] DOMWrapperWorldTest.Basic (17 ms)
,
Nov 1 2017
It looks like the fix for another test accidentally fixed this, but we should probably still update the test expectations to be relative, rather than absolute (as other tests can cause new worlds to be created)
,
Aug 23
I think I found the root cause of this in https://crbug.com/874484. We can probably dupe this into there.
,
Aug 23
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dcheng@chromium.org
, Oct 13 2017