New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 774363 link

Starred by 1 user
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
skyos...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 774350



Sign in to add a comment

webkit_unit_tests: several virtual time tests are consistently flaky

Project Member Reported by dcheng@chromium.org, Oct 13 2017 
1. Run all webkit_unit_tests.
2. Observe that VirtualTimeTest.SetInterval, VirtualTimeTest.DOMTimersFireInExpectedOrder, and VirtualTimeTest.AllowVirtualTimeToAdvance consistently require a retry.

Output from the failed runs:
[ RUN      ] VirtualTimeTest.DOMTimersFireInExpectedOrder                                              
../../third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp:102: Failure                        
      Expected: "c, b, a"                          
      Which is: 0x3043dd 
To be equal to: ExecuteJavaScript("run_order.join(', ')")                                              
      Which is: ""       
[  FAILED  ] VirtualTimeTest.DOMTimersFireInExpectedOrder (31 ms)                                      
[4329/6925] VirtualTimeTest.DOMTimersFireInExpectedOrder (31 ms)                                       
[ RUN      ] VirtualTimeTest.SetInterval           
../../third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp:130: Failure                        
      Expected: "9, timer, 8, 7, 6, 5, 4, 3, 2, 1, 0"                                                  
      Which is: 0x30451b 
To be equal to: ExecuteJavaScript("run_order.join(', ')")                                              
      Which is: ""       
[  FAILED  ] VirtualTimeTest.SetInterval (12 ms)   
[4330/6925] VirtualTimeTest.SetInterval (12 ms)    
[ RUN      ] VirtualTimeTest.AllowVirtualTimeToAdvance                                                 
../../third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp:160: Failure                        
      Expected: "c, b, a"                          
      Which is: 0x3043dd 
To be equal to: ExecuteJavaScript("run_order.join(', ')")                                              
      Which is: ""       
[  FAILED  ] VirtualTimeTest.AllowVirtualTimeToAdvance (13 ms)                                         
[4331/6925] VirtualTimeTest.AllowVirtualTimeToAdvance (13 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89906c3716662689a9792efc5e6ede635b06712

commit a89906c3716662689a9792efc5e6ede635b06712
Author: Alex Clarke <alexclarke@chromium.org>
Date: Mon Oct 16 17:30:40 2017

Fix TimeDomain assignment in RendererSchedulerImpl::ApplyTaskQueuePolicy

Transitioning from TimeDomainType::THROTTLED to TimeDomainType::VIRTUAL
was busted.

Bug:  774363 
Change-Id: Id9e61c2ad3428f8ccb031a2ef2de2d7f9ec24488
Reviewed-on: https://chromium-review.googlesource.com/720921
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509088}
[modify] https://crrev.com/a89906c3716662689a9792efc5e6ede635b06712/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/a89906c3716662689a9792efc5e6ede635b06712/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Comment 2 by alexclarke@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment