Pixel_CSS3DBlueBox fails on Nexus 5 and 5X |
|||
Issue descriptionStarted in https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/11979 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205%29/builds/7681 Wasn't able to find what in blamelist caused this. Going to skip the test.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/158add130a02344cdd62f413da42380b5b10a087 commit 158add130a02344cdd62f413da42380b5b10a087 Author: Yuly Novikov <ynovikov@chromium.org> Date: Fri Oct 13 06:22:38 2017 Skip Pixel_CSS3DBlueBox on Nexus 5 and 5X BUG= 774354 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9419e5ae751b53761da0b6573c58d8cbd8564cc2 Reviewed-on: https://chromium-review.googlesource.com/717938 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#508615} [modify] https://crrev.com/158add130a02344cdd62f413da42380b5b10a087/content/test/gpu/gpu_tests/pixel_expectations.py
,
Oct 13 2017
The suspected patch actually fixed a bug: solid color picture layers used to ignore any scale factors. Instead the layer should be scaled by IdealContentsScale. In the test case, the content of blue box should be scaled by device_scale_factor * <scale portion of perspective(500) * rotateY(45deg)> instead of a factor of 1. The float math may be responsible for edge pixel differences. Judging the test results http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?1e6cb39457ae9fc0d631aea1e0f21457a25501d3_Android_Release_Nexus_5__telemetry, I think we can rebaseline that test?
,
Oct 13 2017
Sounds good, can you do it?
,
Oct 13 2017
Sure no problem!
,
Oct 13 2017
Great, thanks. :) It's easy. Please see: https://www.chromium.org/developers/testing/gpu-testing#TOC-Updating-and-Adding-New-Pixel-Tests-to-the-GPU-Bots Just submit a CL which: 1) Marks the test failing everywhere 2) Increments the version number of the test in src/content/test/gpu/gpu_tests/pixel_test_pages.py Then follow it up with a CL a couple of hours later which unmarks the test as failing. There's another failure on Mac in that file which we should probably leave in place, so please just comment out that expectation when marking it failing and uncomment it after. Thanks.
,
Oct 24 2017
The previous patch is followed by a patch that fixes occlusion scaling bug. I will rebaseline the test after the occlusion one being landed. Hi kbr@, I see that the test is already marked as failure for Nexus 5/5X in test expectations, should I mark it failure for all platforms?
,
Oct 24 2017
No, just unmark these two after you rebaseline.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8111786e36f6d6fa6a787509a690379e60afdd0b commit 8111786e36f6d6fa6a787509a690379e60afdd0b Author: sunxd <sunxd@chromium.org> Date: Mon Oct 30 20:36:28 2017 Rebaseline Pixel_CSS3DBlueBox The test failed because we fix a cc picture layer tiling issue. It used to ignore any scale factors, so fixing it would bring pixel differences in the test. This CL increase the version number for rebaseline. Bug: 774354 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I38fee772dd9a8ed779c420acc6508077b45ebe1f Reviewed-on: https://chromium-review.googlesource.com/735074 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#512609} [modify] https://crrev.com/8111786e36f6d6fa6a787509a690379e60afdd0b/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/8111786e36f6d6fa6a787509a690379e60afdd0b/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a083d2cbc20724845b571f1bc30fd443c67a45cc commit a083d2cbc20724845b571f1bc30fd443c67a45cc Author: sunxd <sunxd@chromium.org> Date: Thu Nov 02 19:03:03 2017 Followup: rebaseline Pixel_CSS3DBlueBox This cl recovers pixel_expectations.py so that the test is not expected to fail. Bug: 774354 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I04bad02764e8fcdb5d1b23b620be4f8d90b2a65c Reviewed-on: https://chromium-review.googlesource.com/751421 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513572} [modify] https://crrev.com/a083d2cbc20724845b571f1bc30fd443c67a45cc/content/test/gpu/gpu_tests/pixel_expectations.py
,
Nov 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ynovikov@chromium.org
, Oct 13 2017Status: Assigned (was: Untriaged)