Add an abstract class for the observers in scoped_layer_animation_settings. |
||||||
Issue descriptionToT. The observers in scoped_layer_animation_settings, CacheRenderSurfaceObserver, DeferredPaintObserver, and TrilinearFilteringObserver, share the very similar pattern. We should abstract it and reduce the duplication of the code.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f12fa07d109c13d3c5196be4696a89d11891e246 commit f12fa07d109c13d3c5196be4696a89d11891e246 Author: wutao <wutao@chromium.org> Date: Thu Oct 19 18:38:40 2017 Abstract observers in ScopedLayerAnimationSettings. The observers in scoped_layer_animation_settings, CacheRenderSurfaceObserver, DeferredPaintObserver, and TrilinearFilteringObserver, share the very similar pattern. This cl abstracts the observers and reduces the duplication of the code. Bug: 774332 Test: local builds works with caching and trilinear filtering. Change-Id: Idc4119d6ec680145c05161b504a7baf45080058b Reviewed-on: https://chromium-review.googlesource.com/724362 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510146} [modify] https://crrev.com/f12fa07d109c13d3c5196be4696a89d11891e246/ui/compositor/scoped_layer_animation_settings.cc
,
Oct 19 2017
,
Oct 20 2017
Please add appropriate OSs.
,
Oct 20 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa94d63c677270cecb702b9a454afce464733b8c commit aa94d63c677270cecb702b9a454afce464733b8c Author: wutao <wutao@chromium.org> Date: Fri Oct 20 22:26:13 2017 [Merge to M63] Abstract observers in ScopedLayerAnimationSettings. The observers in scoped_layer_animation_settings, CacheRenderSurfaceObserver, DeferredPaintObserver, and TrilinearFilteringObserver, share the very similar pattern. This cl abstracts the observers and reduces the duplication of the code. TBR=reveman@chromium.org,piman@chromium.org (cherry picked from commit f12fa07d109c13d3c5196be4696a89d11891e246) Bug: 774332 Test: local builds works with caching and trilinear filtering. Change-Id: Idc4119d6ec680145c05161b504a7baf45080058b Reviewed-on: https://chromium-review.googlesource.com/724362 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510146} Reviewed-on: https://chromium-review.googlesource.com/731651 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#127} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/aa94d63c677270cecb702b9a454afce464733b8c/ui/compositor/scoped_layer_animation_settings.cc
,
Mar 6 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wutao@chromium.org
, Oct 19 2017