CCT toolbar animates on tab reparenting |
|||||
Issue descriptionChrome Version: Stable m61 Recording on stable with CCT from Hangouts (googlers only): https://drive.google.com/file/d/0B091Vp7gEagZUHhnbkZCdmxDd1E/view Here is an screen recording from CCT in Minimal-UI on Dev (googlers only): https://screenshot.googleplex.com/niojdz1Jb86.png Animation should not happen. From my early debugging I found that toolbar changes are invoked by ToolbarManager#refreshSelectedTab() after tab disappeared due to reparenting.
,
Oct 17 2017
Requesting a merge of crrev.com/c/716439 into m63. This patch unblocks the launch of Minimal-UI (Launch tracked in crbug/763638), as it fixes subtle UI transition issues pointed out be the UI Review. It has landed in Canary and has been tested by me, I confirm it fixes the problem and introduces no additional issues.
,
Oct 18 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3902eb0e85023940fa3da0d2f69f5472ee690eb4 commit 3902eb0e85023940fa3da0d2f69f5472ee690eb4 Author: Piotr Swigon <piotrs@chromium.org> Date: Wed Oct 18 04:28:17 2017 [WebApps] Do not reparent from WebappActivity. This patch changes reparenting to regular link opening. This change is motivated by the CCT toolbar clearing its color and moving text around on tab reparenting. Bug: 774326 Change-Id: I030f5a497090c24e54c0fd33ed5f9f02bec00e54 Reviewed-on: https://chromium-review.googlesource.com/716439 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508584}(cherry picked from commit 0f6428bac3035b5b9e69da4c8de7defaf02f7267) Reviewed-on: https://chromium-review.googlesource.com/724761 Reviewed-by: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#45} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/3902eb0e85023940fa3da0d2f69f5472ee690eb4/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java [modify] https://crrev.com/3902eb0e85023940fa3da0d2f69f5472ee690eb4/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
,
Dec 26 2017
Unassigning myself as I won't be able to work on this. Assigning to the correct component. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2017