Issue 774324 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sahel@chromium.org
Closed:	Oct 2017
Cc:	dtapu...@chromium.org
Components:	Blink>Scroll
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Hotlist-Input-Dev M-64

Add metric to record how often wheels are latched

Project Member Reported by bokan@chromium.org, Oct 13 2017

Issue description

Dave brought up a good idea today: we should record how often wheels are latched. That is, for each incoming Wheel, record YES|NO whether it immediately causes a ScrollUpdate or whether it has to create a new latch by sending a ScrollBegin. 

This will help us determine how much impact latching is having as well as how good our timeout value is.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b0f84658725b9cf03ce78d2f30b1f599d7e5452

commit 3b0f84658725b9cf03ce78d2f30b1f599d7e5452
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Oct 25 02:58:28 2017

Uma metric added to record latched vs non-latched wheel scrolling.

Bug:  774324 
Test: MouseWheelEventQueueTest.WheelScrollingWasLatchedHistogramCheck/*
Change-Id: I243d693a9d70b40f764577b2b7b94b894c515ba0
Reviewed-on: https://chromium-review.googlesource.com/726891
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511334}
[modify] https://crrev.com/3b0f84658725b9cf03ce78d2f30b1f599d7e5452/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/3b0f84658725b9cf03ce78d2f30b1f599d7e5452/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/3b0f84658725b9cf03ce78d2f30b1f599d7e5452/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/3b0f84658725b9cf03ce78d2f30b1f599d7e5452/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3b0f84658725b9cf03ce78d2f30b1f599d7e5452/tools/metrics/histograms/histograms.xml

Comment 2 by sahel@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)

►

Issue 774324 link

Issue metadata

Add metric to record how often wheels are latched

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

Comment 1 Deleted

Comment 2 by sahel@chromium.org, Oct 25 2017

Comment 2 Deleted

Sign in to add a comment