New issue
Advanced search Search tips

Issue 774322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

cros_config: option to create a full config tree for all the models in unibuild family

Project Member Reported by pbe...@chromium.org, Oct 13 2017

Issue description

Create a structure similar to what's created with crrev.com/i/471852 so one can easily diff model's configurations incl. file content using something like kdiff3.

 

Comment 1 by sjg@chromium.org, Oct 19 2017

Status: Started (was: Assigned)
Starting point here:

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/726162

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dca3a04823a91e596cedff24207a1467e9572e02

commit dca3a04823a91e596cedff24207a1467e9572e02
Author: Simon Glass <sjg@chromium.org>
Date: Fri Oct 20 04:15:31 2017

chromeos-config: Show a simple file tree

This is just a starting point showing how files in the config can be
listed in a user-friendly form. It allows you to see the size of each file
and also those which are missing. Future work could involve actually
copying the files to a directory so that can be examined/compared.

BUG= chromium:774322 
TEST=PYTHONPATH=~/cosarm python cros_config_host_py/cros_config_host_py \
	~/cosarm/chroot/build/reef-uni/usr/share/chromeos-config/config.dtb \
	file-tree ~/cosarm/chroot/build/reef-uni
Size      Path
          /
             etc/
                cras/
                   basking/
1992                  bxtda7219max
2500                  dsp.ini
                   electro/
2027                  bxtda7219max
1728                  dsp.ini
...

Change-Id: I4754a3b2ac78860dd6ee590061f9f5e62a622e74
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/726162
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/dca3a04823a91e596cedff24207a1467e9572e02/chromeos-config/cros_config_host_py/libcros_config_host_unittest.py
[modify] https://crrev.com/dca3a04823a91e596cedff24207a1467e9572e02/chromeos-config/cros_config_host_py/cros_config_host.py
[modify] https://crrev.com/dca3a04823a91e596cedff24207a1467e9572e02/chromeos-config/cros_config_host_py/libcros_config_host.py

Comment 3 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 4 by sjg@chromium.org, Jan 5 2018

Status: Fixed (was: Started)
I'm calling this done since we have the basic feature. We can add more as needed.

Sign in to add a comment