New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 768572



Sign in to add a comment

GPU.fyi Mac Experimental (Retina) Release bots failure

Project Member Reported by weiliangc@chromium.org, Oct 12 2017

Issue description

gles2_conform_test failure looks like:
[ RUN      ] GLES2ConformTest.GL_array_input_run
[21665:775:1012/154721.164785:8983385546563:ERROR:gpu_test_config.cc(271)] Unknown OS
[21665:775:1012/154721.164802:8983385562382:ERROR:gles2_conform_test.cc(56)] Fail to load bot configuration
gen/gpu/gles2_conform_support/gles2_conform_test_autogen.cc:22: Failure
Value of: RunGLES2ConformTest("GL/array/input.run")
  Actual: false
Expected: true
[  FAILED  ] GLES2ConformTest.GL_array_input_run (1 ms)



gpu_unittest failure looks like:
[ RUN      ] GPUTestConfigTest.LoadCurrentConfig
[22051:775:1012/154731.452351:8993673389621:ERROR:gpu_test_config.cc(271)] Unknown OS
../../gpu/config/gpu_test_config_unittest.cc:272: Failure
Value of: config.LoadCurrentConfig(&gpu_info)
  Actual: false
Expected: true
../../gpu/config/gpu_test_config_unittest.cc:273: Failure
Value of: config.IsValid()
  Actual: false
Expected: true
[  FAILED  ] GPUTestConfigTest.LoadCurrentConfig (0 ms)

Two out of the three bots' initial failure CL range doesn't overlap at all, so couldn't track down which CL it is.
Blocking: 768572
Cc: cwallez@chromium.org
Owner: ynovikov@chromium.org
Status: Started (was: Available)
These bots were updated to 10.13 Mac OS in issue 768572.
I'll try to fix the "Unknown OS" problem.
Owner: cwallez@chromium.org
Status: Assigned (was: Started)
Actually, Corentin, it would probably take you much less time than me.
Can you take it, please?
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443334af046a516e6bcd5517ebdd0a7803575fe0

commit 443334af046a516e6bcd5517ebdd0a7803575fe0
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 13 21:01:03 2017

gpu/config: Add support for macOS High Sierra

BUG= 774309 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iadfc74843630ef78e708412922eccd0fb2cc137a
Reviewed-on: https://chromium-review.googlesource.com/717658
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508814}
[modify] https://crrev.com/443334af046a516e6bcd5517ebdd0a7803575fe0/gpu/config/gpu_test_config.cc
[modify] https://crrev.com/443334af046a516e6bcd5517ebdd0a7803575fe0/gpu/config/gpu_test_config.h
[modify] https://crrev.com/443334af046a516e6bcd5517ebdd0a7803575fe0/gpu/config/gpu_test_expectations_parser.cc
[modify] https://crrev.com/443334af046a516e6bcd5517ebdd0a7803575fe0/gpu/config/gpu_test_expectations_parser_unittest.cc

Confirmed this fixes the problem on the experimental bots. Keeping this bug open for the roll of the changes in ANGLE.
Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/2f1feb79d45b52a36d854648ddb9d6fd4dd17340

commit 2f1feb79d45b52a36d854648ddb9d6fd4dd17340
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Wed Oct 18 00:15:04 2017

Roll skia/third_party/externals/angle2/ 8a9e0fc23..b9cb7f60d (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/8a9e0fc238a1..b9cb7f60da57

$ git log 8a9e0fc23..b9cb7f60d --date=short --no-merges --format='%ad %ae %s'
2017-10-16 cwallez Update gpu_test_expectations

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 774309 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=benjaminwagner@google.com

Change-Id: Idd70b597c6ed5fa18c1f97df84e50662bec51267
Reviewed-on: https://skia-review.googlesource.com/60921
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/2f1feb79d45b52a36d854648ddb9d6fd4dd17340/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ec170c190678ab68b07736731d654b91429540

commit c7ec170c190678ab68b07736731d654b91429540
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Wed Oct 18 05:40:15 2017

Roll src/third_party/skia/ d71c6d199..5546c921e (3 commits)

https://skia.googlesource.com/skia.git/+log/d71c6d1994f6..5546c921e0ca

$ git log d71c6d199..5546c921e --date=short --no-merges --format='%ad %ae %s'
2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ b9cb7f60d..ebf7299e4 (1 commit)
2017-10-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 8a9e0fc23..b9cb7f60d (1 commit)
2017-10-17 benjaminwagner Synchronize public.bzl float-cast-overflow omit list with test.py.

Created with:
  roll-dep src/third_party/skia
BUG= 774309 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I4f4ad7cf3865ab75b485e46ce77942a42f261637
Reviewed-on: https://chromium-review.googlesource.com/724960
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509694}
[modify] https://crrev.com/c7ec170c190678ab68b07736731d654b91429540/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9203cfa3eb511238e67fcdf3892add8b1f68086

commit c9203cfa3eb511238e67fcdf3892add8b1f68086
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Oct 18 22:30:15 2017

Roll ANGLE 2d88e9b..d042fba

https://chromium.googlesource.com/angle/angle.git/+log/2d88e9b..d042fba

BUG=,chromium:774309

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Merge branch 'master' of https://chromium.googlesource.com/chromium/src


gpu/config: Return partial info from angle::GetSystemInfo

A filure in angle::GetSystemInfo will still return a gpu info collection
failure but partial results will be shown in about:gpu which will help
diagnosing problems.

BUG= chromium:774748 

Change-Id: I000b9f83dc35389beeb14657460baed22ac25daa
Reviewed-on: https://chromium-review.googlesource.com/726020
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509898}
[modify] https://crrev.com/c9203cfa3eb511238e67fcdf3892add8b1f68086/DEPS

Sign in to add a comment