Enable DCHECK on build bot linux_layout_tests_layout_ng |
||||
Issue descriptionCurrently, DCHECK is not enabled on linux_layout_tests_layout_ng. We often see some weird test failures that are in fact due to DCHECK hit. We should enable DCHECK on linux_layout_tests_layout_ng to make run results more useful.
,
Oct 12 2017
Note, this will make the results similar to linux_chromium_rel_ng (both will hit DCHECK), but DCHECKs are disabled on the continuous release bots. Do we want to do this because we want this try bot to be similar to linux_chromium_rel_ng?
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14c22a8eef5953721eb6b8880105da9e6e5eceec commit 14c22a8eef5953721eb6b8880105da9e6e5eceec Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Oct 13 19:14:11 2017 Enable dcheck on linux_layout_tests_layout_ng Bug: 774299 Change-Id: Iced4576c4b3f65d1e71270e7ddb130667f1710ab Reviewed-on: https://chromium-review.googlesource.com/717501 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#508773} [modify] https://crrev.com/14c22a8eef5953721eb6b8880105da9e6e5eceec/tools/mb/mb_config.pyl
,
Oct 13 2017
Seems that the bot can't ignore so many unexpected crashes... https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_layout_ng/builds/1658 We need to update the test expectations
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d39dc71dd2cc21af084f491cf4c1e1128dd84d8 commit 6d39dc71dd2cc21af084f491cf4c1e1128dd84d8 Author: Koji Ishii <kojii@chromium.org> Date: Mon Oct 16 02:32:30 2017 [LayoutNG] Update FlagExpectations for LayoutNG Following bot results are included. 1662 1665 1668 1669 1670 1671 This is a large change after DCHECK was enabled ( crbug.com/774299 ). TBR=eae@chromium.org NOTRY=true Bug: 591099, 774299 Change-Id: I219b6ffd787dfd62a3985e2a469f23eba9f4abb0 Reviewed-on: https://chromium-review.googlesource.com/720416 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#508971} [modify] https://crrev.com/6d39dc71dd2cc21af084f491cf4c1e1128dd84d8/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
,
Oct 16 2017
I think this is considered done now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Oct 12 2017