New issue
Advanced search Search tips

Issue 774298 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Remove ConsumeTextureCHROMIUM

Project Member Reported by vmi...@chromium.org, Oct 12 2017

Issue description

I believe ConsumeTextureCHROMIUM has been replaced by CreateAndConsumeTextureCHROMIUM in all code except tests.  We can remove the API.
 
If its okay, I will take a stab at this.

Comment 2 by piman@chromium.org, Oct 18 2017

Owner: rijubrat...@intel.com
Status: Assigned (was: Available)
Please go ahead.

Comment 3 by piman@chromium.org, Oct 18 2017

Components: -Internals>GPU Internals>GPU>Internals
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190739f431bd8f09c90923b39dd38ec9d12e1045

commit 190739f431bd8f09c90923b39dd38ec9d12e1045
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Tue Oct 24 07:56:16 2017

[gpu] Remove ConsumeTextureCHROMIUM

Make layer_tree_pixel_test use CreateAndConsumeTextureCHROMIUM.
Update CHROMIUM_texture_mailbox.txt

BUG= 774298 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id5eb0594673d948a188899df8310e24d7e3368e5
Reviewed-on: https://chromium-review.googlesource.com/725736
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#511056}
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/cc/test/test_gles2_interface.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/cc/test/test_gles2_interface.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/cc/test/test_web_graphics_context_3d.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/cc/test/test_web_graphics_context_3d.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_texture_mailbox.txt
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/common/gles2_cmd_ids_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
[modify] https://crrev.com/190739f431bd8f09c90923b39dd38ec9d12e1045/gpu/command_buffer/tests/gl_texture_mailbox_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5339ea1dd9be8381fbad674cc685da6345a6373

commit d5339ea1dd9be8381fbad674cc685da6345a6373
Author: Victor Miura <vmiura@chromium.org>
Date: Tue Nov 21 08:46:06 2017

Remove remnants of TexParameteri calls from layer_tree_pixel_test.

Patch https://chromium-review.googlesource.com/725736 left these
calls on an undetermined texture binding.

BUG= 774298 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaabdd2ce981594e141dcaee43de1718fa4fab3d0
Reviewed-on: https://chromium-review.googlesource.com/781439
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518185}
[modify] https://crrev.com/d5339ea1dd9be8381fbad674cc685da6345a6373/cc/test/layer_tree_pixel_test.cc

Sign in to add a comment