Sound content setting should show in OIB when tab is audible |
||
Issue descriptionIn the new OIB, content settings are only shown when they're not in their default state. However, we want the sound content setting to also show up when the tab is audible.
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07624e078141bbbe3612245d0ae57c617601c15f commit 07624e078141bbbe3612245d0ae57c617601c15f Author: Tommy Steimel <steimel@chromium.org> Date: Tue Oct 17 04:06:09 2017 Show sound content setting in Page Info when tab is audible on Android This CL updates Android to show the sound content setting in the Page Info Bubble when sound is playing or has recently played on a site. In order to use WebContents::WasRecentlyAudible() for this, we also enable monitoring audio levels on Android. Bug: 774256 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia00909f6a6343f1e2fabf2ee3d4e651b3640c81e Reviewed-on: https://chromium-review.googlesource.com/719707 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509278} [modify] https://crrev.com/07624e078141bbbe3612245d0ae57c617601c15f/chrome/browser/ui/android/page_info/page_info_popup_android.cc [modify] https://crrev.com/07624e078141bbbe3612245d0ae57c617601c15f/chrome/browser/ui/android/page_info/page_info_popup_android.h [modify] https://crrev.com/07624e078141bbbe3612245d0ae57c617601c15f/media/audio/audio_output_controller.h
,
Oct 18 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c9e59a7d6b7f5b307791efdbb98f512f03ed750 commit 0c9e59a7d6b7f5b307791efdbb98f512f03ed750 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Oct 27 18:11:08 2017 Revert "Show sound content setting in Page Info when tab is audible on Android" This reverts commit 07624e078141bbbe3612245d0ae57c617601c15f. Reason for revert: Enabling audio monitoring has had significant performance impact on Android. See crbug.com/776172 Original change's description: > Show sound content setting in Page Info when tab is audible on Android > > This CL updates Android to show the sound content setting in the Page > Info Bubble when sound is playing or has recently played on a site. In > order to use WebContents::WasRecentlyAudible() for this, we also enable > monitoring audio levels on Android. > > Bug: 774256 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ia00909f6a6343f1e2fabf2ee3d4e651b3640c81e > Reviewed-on: https://chromium-review.googlesource.com/719707 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509278} TBR=miu@chromium.org,mlamouri@chromium.org,tedchoc@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 774256 , 776172 Change-Id: Ifb33a6b779826d3416adb82cdd80ad56589eba68 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/739883 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#512238} [modify] https://crrev.com/0c9e59a7d6b7f5b307791efdbb98f512f03ed750/chrome/browser/ui/android/page_info/page_info_popup_android.cc [modify] https://crrev.com/0c9e59a7d6b7f5b307791efdbb98f512f03ed750/chrome/browser/ui/android/page_info/page_info_popup_android.h [modify] https://crrev.com/0c9e59a7d6b7f5b307791efdbb98f512f03ed750/media/audio/audio_output_controller.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 13 2017