Switching from amd64-generic-asan to betty-asan |
|||||||||||||||
Issue descriptionamd64-generic-asan is replaced by betty-asan in crrev.com/9af4a9a23a7589ce4dec411604695c4572c75190 https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan needs to be changed, too.
,
Oct 14 2017
The waterfall restart created betty-asan, but it is red. https://build.chromium.org/p/chromiumos/builders/betty-asan Now unrelated to this I realize that it was a mistake to remove amd64-generic-asan. I think it is best to have two, one for public and one for private bits. https://chromium-review.googlesource.com/#/c/chromiumos/chromite/+/720151/
,
Oct 14 2017
Back to betty, the error is
20:07:48: ERROR: <class 'chromite.lib.portage_util.MissingOverlayException'>: board overlay not found: betty
Traceback (most recent call last):
File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 229, in wrapped_functor
return functor(*args, **kwargs)
File "/b/c/cbuild/repository/chromite/cbuildbot/stages/report_stages.py", line 457, in PerformStage
config['boards'][0], buildroot=build_root)
File "/b/c/cbuild/repository/chromite/lib/toolchain.py", line 78, in GetToolchainTupleForBoard
toolchains = GetToolchainsForBoard(board, buildroot)
File "/b/c/cbuild/repository/chromite/lib/toolchain.py", line 60, in GetToolchainsForBoard
buildroot=buildroot)
File "/b/c/cbuild/repository/chromite/lib/portage_util.py", line 188, in FindOverlays
overlays = _ListOverlays(board=board, buildroot=buildroot)
File "/b/c/cbuild/repository/chromite/lib/portage_util.py", line 170, in _ListOverlays
raise MissingOverlayException('board overlay not found: %s' % board)
MissingOverlayException: board overlay not found: betty
I guess wrong waterfall?
,
Oct 14 2017
Oh..... did an internal builder end up on the chromiumos waterfall? Yeah.... that's not supposed to happen, and there might be a safety somewhere to prevent it.
,
Oct 14 2017
Also, make sure all of the relevant builders are listed here, please: https://luci-scheduler.appspot.com/jobs/chromiumos-chromite
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c51866c2ebcc62100cf3cbc3775715354595d0a2 commit c51866c2ebcc62100cf3cbc3775715354595d0a2 Author: Ilja H. Friedel <ihf@chromium.org> Date: Mon Oct 16 07:17:48 2017 chromeos_config: re-add amd64-generic-asan. In 9af4a9a23a7589ce4dec411604695c4572c75190 I switched all of amd64-generic-asan to betty-asan. Now I have more information and I believe it is better if they co-exist. (amd64-generic is fully public and VM capable, while betty has private bits.) So this is a partial revert and re-adds amd64-generic-asan. BUG= chromium:765364 , chromium:772568, chromium:774251 TEST=unittest Change-Id: I0021db9c4d4e432b2e00f2a318e37f09c046c272 Reviewed-on: https://chromium-review.googlesource.com/720151 Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/c51866c2ebcc62100cf3cbc3775715354595d0a2/cbuildbot/config_dump.json [modify] https://crrev.com/c51866c2ebcc62100cf3cbc3775715354595d0a2/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/c51866c2ebcc62100cf3cbc3775715354595d0a2/cbuildbot/chromeos_config.py
,
Oct 16 2017
Change to move betty-asan to internal is up https://chromium-review.googlesource.com/#/c/chromiumos/chromite/+/722118/
,
Oct 16 2017
+yunlian@ / toolchain sheriff
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e550f58e089c1bce534e1002cc674d3ea3ed9595 commit e550f58e089c1bce534e1002cc674d3ea3ed9595 Author: Ilja H. Friedel <ihf@chromium.org> Date: Tue Oct 17 00:47:45 2017 cbuildbot: move betty-asan to internal waterfall. betty-asan builds from internal sources unlike amd64-generic-asan, so it should live on the internal waterfall. BUG= chromium:765364 , chromium:772568, chromium:774251 TEST=run_tests Change-Id: I6ec03570622a5617bccf72d510388eda0eb52d87 Reviewed-on: https://chromium-review.googlesource.com/722118 Commit-Queue: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/e550f58e089c1bce534e1002cc674d3ea3ed9595/cbuildbot/config_dump.json [modify] https://crrev.com/e550f58e089c1bce534e1002cc674d3ea3ed9595/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/e550f58e089c1bce534e1002cc674d3ea3ed9595/cbuildbot/chromeos_config.py
,
Oct 17 2017
,
Oct 20 2017
amd64-generic is back: https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan betty-asan may or may not be alive, I gave it a kick: https://uberchromegw.corp.google.com/i/chromeos/builders/betty-asan
,
Dec 26 2017
,
Jan 2 2018
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
,
Feb 5 2018
,
Mar 12 2018
Is there a plan to bring betty-asan to life?
,
Mar 30 2018
,
Mar 30 2018
,
May 1 2018
Are you still working on this?
,
May 1 2018
,
May 2 2018
Ideally we need betty-asan.
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ec76188a3a9368f2ae61bd4c0f561383cd558a86 commit ec76188a3a9368f2ae61bd4c0f561383cd558a86 Author: Don Garrett <dgarrett@google.com> Date: Fri May 18 21:33:13 2018 chromeos_config: Use internal checkout for betty-asan. betty-asan was failing to try to build because it was using an external source code checkout. BUG= chromium:774251 TEST=run_tests (no test build) Change-Id: I4ae76803ac808b50cf9ef6ec57a768086f523f6a Reviewed-on: https://chromium-review.googlesource.com/1062793 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/ec76188a3a9368f2ae61bd4c0f561383cd558a86/cbuildbot/config_dump.json [modify] https://crrev.com/ec76188a3a9368f2ae61bd4c0f561383cd558a86/cbuildbot/chromeos_config.py
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12bf7454a6ae15b397e68c1245263bf178984ef4 commit 12bf7454a6ae15b397e68c1245263bf178984ef4 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 18 23:03:14 2018 Roll src/third_party/chromite/ 08be0a3a8..17530e94d (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/08be0a3a8469..17530e94d1c5 $ git log 08be0a3a8..17530e94d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dgarrett chromeos_config: Display Asan builders as informational. 2018-05-16 dgarrett chromeos_config: Use internal checkout for betty-asan. Created with: roll-dep src/third_party/chromite BUG= chromium:834078 , chromium:774251 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifea8c8a720e251e7b76931ed57162db83baf6cf9 Reviewed-on: https://chromium-review.googlesource.com/1066738 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560086} [modify] https://crrev.com/12bf7454a6ae15b397e68c1245263bf178984ef4/DEPS
,
Jun 18 2018
Assigning to me to fix betty asan builds.
,
Jun 21 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-betty-private/+/0c94252e5a40098f42022377c3b9706bf3a152a7 commit 0c94252e5a40098f42022377c3b9706bf3a152a7 Author: Manoj Gupta <manojgupta@google.com> Date: Thu Jun 21 08:05:40 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a commit 487a2e6e5f7dbc8febe2086f347c17d0c4b0066a Author: Manoj Gupta <manojgupta@google.com> Date: Thu Jun 21 08:05:40 2018 Add asan profile in chromiumos-overlay profiles. This is to make it easier to add asan profile to different boards. BUG= chromium:774251 TEST=profile is added. TEST=Created a working betty asan profile with this profile as parent. Change-Id: Ic7a7abf2d0e2485b6508c5ea6f2a3e34c5d45e6a Reviewed-on: https://chromium-review.googlesource.com/1105413 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/README.md [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/amd64/parent [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/make.defaults [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/arm/parent [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/arm64/parent [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/x86/parent [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/profile.bashrc [add] https://crrev.com/487a2e6e5f7dbc8febe2086f347c17d0c4b0066a/profiles/asan/package.use.mask
,
Jun 21 2018
betty-asan is making some progress now. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=2683998 Building Chrome in build packages is failing because of bug 853266 which is fixed but needs to wait for a Chrome uprev. Post that, I suspect there might be an issue related to image size if the image does not fit in 4GB rootfs.
,
Jun 26 2018
The build gets to build_image step but fails because 4GB is not enough space for ASan builds. ihf@, vapier@ Is there a 8GB rootfs? https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8942646006809815600 chromeos-chrome-69.0.3473.0_rc-r1: * CHROME_SIZE = 663495000 chromeos-chrome-69.0.3473.0_rc-r1: * >>> SetUID: [chmod go-r] /opt/google/chrome/chrome-sandbox ... chromeos-chrome-69.0.3473.0_rc-r1: [ ok ] chromeos-chrome-69.0.3473.0_rc-r1: !!! copy /build/betty/tmp/portage/chromeos-base/chromeos-chrome-69.0.3473.0_rc-r1/image/opt/google/chrome/chrome -> /mnt/host/source/src/build/images/betty/R69-10819.0.2018_06_26_0936-a1/rootfs/opt/google/chrome/chrome failed. chromeos-chrome-69.0.3473.0_rc-r1: !!! [Errno 28] No space left on device chromeos-chrome-69.0.3473.0_rc-r1: >>> Failed to install chromeos-base/chromeos-chrome-69.0.3473.0_rc-r1 to /mnt/host/source/src/build/images/betty/R69-10819.0.2018_06_26_0936-a1/rootfs/, Log file: chromeos-chrome-69.0.3473.0_rc-r1: >>> '/build/betty/tmp/portage/logs/chromeos-base:chromeos-chrome-69.0.3473.0_rc-r1:20180626-163847.log' === Complete: job chromeos-chrome-69.0.3473.0_rc-r1 (0m28.8s) ===
,
Jun 26 2018
not currently, but should be trivial to add one in src/scripts/build_library/legacy_disk_layout.json and then refer to that in the cbuildbot config
,
Jun 26 2018
Yes, we should make the betty rootfs as large as needed. Maybe even 16 if there is no downside, as we will soon install more data on it.
,
Jun 27 2018
The 16gb rootfs Cl is failing for eve https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/PreCQ/b8942606173947551376 Looks like that the custom disk_layout.json file in eve (https://cs.corp.google.com/chromeos_public/src/overlays/overlay-eve/scripts/disk_layout.json) does not stack well with the 16gb rootfs changes. $ build_library/cgpt.py validate base ../overlays/overlay-eve/scripts/disk_layout.json Traceback (most recent call last): File "build_library/cgpt.py", line 1557, in <module> sys.exit(main(sys.argv[1:])) File "build_library/cgpt.py", line 1551, in main ret = opts.callback(opts, *opts.args) File "build_library/cgpt.py", line 1454, in Validate partitions = GetPartitionTableFromConfig(options, layout_filename, image_type) File "build_library/cgpt.py", line 672, in GetPartitionTableFromConfig config = LoadPartitionConfig(layout_filename) File "build_library/cgpt.py", line 421, in LoadPartitionConfig (layout_name, part['label'], part['fs_bytes'], part['bytes'], part['size'])) __main__.InvalidSize: Filesystem may not be larger than partition: 16gb-rootfs ROOT-A: 16777216000 > 4294967296 I looked at https://chromium.googlesource.com/chromiumos/platform/crosutils/+/HEAD/build_library/README.disk_layout but not sure if I understand anything there. The error goes away if I also add the 16gb-rootfs to the eve's disk layout as well. Is that a right way to fix the error?
,
Jun 27 2018
We also have a amd64-generic-asan informational chrome pfq build, and it has been failing forever, see https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=amd64-generic-asan&buildBranch=master. Anyone here know what this build used for? And do we still need this build?
,
Jun 27 2018
Informational builder builds ToT chrome while the non-information one runs the stable Chrome ebuild. The current failures are because of a known bug 844092 which needs to be fixed by audio team. IIUC, None of these builders are part of Chrome PFQ which is used for upreving Chrome.
,
Jun 27 2018
Correct, they are not part of the PFQ.
,
Jun 27 2018
Thanks manojgupta@ and dgarrett@! Sorry I don't know much about the history. But if these two builders (amd64-generic-asan and betty-asan) are not part of the PFQ, do you know why they are put under the category of chrome_informational PFQ builders (https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?builderGroups=chrome_pfq%2Cchrome_informational&limit=3&buildBranch=master)?
,
Jun 27 2018
The link in #comment 34 has a typo, it should be https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?builderGroups=chrome_pfq%2Cchrome_informational&limit=3&buildBranch=master
,
Jun 27 2018
In the chrome_informational builders are builds run to do additional testing useful to Gardeners in managing the PFQ. However, the builders in question have recently been moved around in the UI, and might not be in the right place. In particular, I'm not sure if the informational vs chrome_informationals are correct. If not, just let me know and it'll be easy to move future builds.
,
Jun 27 2018
As they compile Chrome with ASAN options I think the intention is to FYI cover the Chromium waterfall builds before Chrome uprevs and is sent to the PFQ. So the coverage should not really be PFQ, but kind of pre-PFQ.
,
Jun 27 2018
PS: The a link that shows informational vs chrome_informational: https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?buildBranch=master&builderGroups=informational%2Cchrome_informational&limit=3&email=&buildConfig=
,
Jun 27 2018
i think our stacking logic is slightly off atm, or it's not exactly intuitive. check out issue 716607 and https://chromium-review.googlesource.com/183391. you might have to add a hack to the eve layout in the meantime.
,
Jun 27 2018
Just ran a script to find the non-working layouts and seems like I need to change these set of files. overlays/baseboard-fizz/scripts/disk_layout.json overlays/baseboard-nami/scripts/disk_layout.json overlays/baseboard-poppy/scripts/disk_layout.json overlays/overlay-atlas/scripts/disk_layout.json overlays/overlay-eve/scripts/disk_layout.json overlays/overlay-kidd/scripts/disk_layout.json overlays/overlay-nautilus/scripts/disk_layout.json overlays/overlay-nocturne/scripts/disk_layout.json private-overlays/overlay-caroline-arc64-private/scripts/disk_layout.json private-overlays/overlay-grunt-private/scripts/disk_layout.json private-overlays/overlay-kahlee-private/scripts/disk_layout.json private-overlays/overlay-storm-private/scripts/legacy_disk_layout.json This is not too big a list but wish if changing them wasn't necessary in the first place.
,
Jun 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-caroline-arc64-private/+/f1328832ca690e3ae02088b844c22c2e3020c2a1 commit f1328832ca690e3ae02088b844c22c2e3020c2a1 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jun 29 04:06:24 2018
,
Jun 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-betty-private/+/51ab28d78ac611f9eee1dcfa12ffae8728324641 commit 51ab28d78ac611f9eee1dcfa12ffae8728324641 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jun 29 08:09:11 2018
,
Jun 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kahlee-private/+/eeae29872f5875ee37f0ddc62df183e74e7792e3 commit eeae29872f5875ee37f0ddc62df183e74e7792e3 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jun 29 12:21:37 2018
,
Jun 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-grunt-private/+/07e87733d0870b0dc4e714072b4db434f1e4128d commit 07e87733d0870b0dc4e714072b4db434f1e4128d Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jun 29 18:38:51 2018
,
Jun 29 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-betty-arc64-private/+/52ca3357cbbe1d6b5e1e334eb8d09c85a2a3c403 commit 52ca3357cbbe1d6b5e1e334eb8d09c85a2a3c403 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jun 29 18:38:52 2018
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/63de5167a015dcbf33656d9f7cf7d3fe75418c59 commit 63de5167a015dcbf33656d9f7cf7d3fe75418c59 Author: Manoj Gupta <manojgupta@google.com> Date: Tue Jul 03 05:06:56 2018 disk_layout: Add 16gb rootfs option. Add the 16gb rootfs option to disk layout. This is needed as a workaround where cgpt.py is reporting issues in stacking the 16gb rootfs in the common legacy_disk_layout.json file in CL:1115504. BUG= chromium:774251 TEST=pre-cq passes. Change-Id: I95479a8f2f25cb3499f5e517c7aa224b47a63723 Reviewed-on: https://chromium-review.googlesource.com/1118920 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/overlay-nautilus/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/baseboard-poppy/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/baseboard-fizz/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/overlay-eve/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/overlay-nocturne/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/overlay-atlas/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/overlay-kidd/scripts/disk_layout.json [modify] https://crrev.com/63de5167a015dcbf33656d9f7cf7d3fe75418c59/baseboard-nami/scripts/disk_layout.json
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8ccc5691f281f41dc76e743d3adc3b05dd6dace7 commit 8ccc5691f281f41dc76e743d3adc3b05dd6dace7 Author: Manoj Gupta <manojgupta@google.com> Date: Tue Jul 03 11:13:37 2018 disk layout: Add 16GiB rootfs. This is needed to support very large images e.g. builds using address sanitizer that are only supported in VM. Should not be used for actual hardware devices. BUG= chromium:774251 TEST=pre-cq passes. betty-asan tryjob passed. CQ-DEPEND=CL:1118920, CL:*646280 Change-Id: I196727014ff019ed8f19db8b98809e4dc5a43da5 Reviewed-on: https://chromium-review.googlesource.com/1115504 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8ccc5691f281f41dc76e743d3adc3b05dd6dace7/build_library/legacy_disk_layout.json
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/670e331c4d8724a1b630b3238c58758da18770b0 commit 670e331c4d8724a1b630b3238c58758da18770b0 Author: Manoj Gupta <manojgupta@google.com> Date: Tue Jul 03 18:41:11 2018 config: Make all asan images use 16gb rootfs. ASan images are large and need more disk space. Move all of them to 16gb rootfs to avoid running out of space in build_image step. Note: These images are not suitable for device installation. CQ-DEPEND=CL:1115504 BUG= chromium:774251 TEST=Pending Change-Id: I3a37b543d638ddc2594f9d48155e9e9ae79113ef Reviewed-on: https://chromium-review.googlesource.com/1115508 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/670e331c4d8724a1b630b3238c58758da18770b0/config/chromeos_config.py [modify] https://crrev.com/670e331c4d8724a1b630b3238c58758da18770b0/config/config_dump.json
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fee4934f4c3211453c578f561e68662a45bf85fc commit fee4934f4c3211453c578f561e68662a45bf85fc Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jul 03 21:22:35 2018 Roll src/third_party/chromite da20e836abca..670e331c4d87 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/da20e836abca..670e331c4d87 git log da20e836abca..670e331c4d87 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 manojgupta@google.com config: Make all asan images use 16gb rootfs. 2018-07-03 mortonm@chromium.org Adjust tester for shill user belonging to daemon-store group. Created with: gclient setdep -r src/third_party/chromite@670e331c4d87 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:774251 ,chromium:649417 TBR=chrome-os-gardeners@chromium.org Change-Id: I9dbdd16184ca3d45d589c7a3f2eec480db4bf713 Reviewed-on: https://chromium-review.googlesource.com/1124903 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572356} [modify] https://crrev.com/fee4934f4c3211453c578f561e68662a45bf85fc/DEPS
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8e3dedf26d7c16d38a5ae472b016f749c0185226 commit 8e3dedf26d7c16d38a5ae472b016f749c0185226 Author: Manoj Gupta <manojgupta@google.com> Date: Wed Jul 04 12:43:49 2018 amd64-generic: Add 16gb rootfs layout. Add 16gb rootfs layout to amd64-generic so that asan builds can use it. BUG= chromium:774251 TEST=amd64-generic-tot-asan-informational build_image passed. Change-Id: I41ec5819c6dda9e163dfadee7724f1ad3762f036 Reviewed-on: https://chromium-review.googlesource.com/1125526 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/8e3dedf26d7c16d38a5ae472b016f749c0185226/overlay-amd64-generic/scripts/disk_layout.json
,
Jul 4
betty-asan is up and running (mostly). https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8941921232086706816 There are Unittest and VMTest fails which should be tracked in different bugs. Closing this for now.
,
Jul 18
I hit an issue building an image in my workstation for eve- cgpt.py choked on the new layout. Reverting 1115504 allowed me to build.
,
Jul 18
Regarding #52, probably making same change to eve as CL 1118920 may work. Nevertheless, add this layout to every board is super ugly. I don;t really who is the right person to fix this though.
,
Jul 18
/facepalm - I was on an old branch. 1118920 adds the layout to eve. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by ihf@chromium.org
, Oct 12 2017