New issue
Advanced search Search tips

Issue 774248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Support platform name in the master config

Project Member Reported by sjg@chromium.org, Oct 12 2017

Issue description

At present 'mosys platform name' reports the platform name. We have no such concept in the master configuration.

We should add this, so that mosys can report it, and so we can locate the platform name based on the SKU ID.
 

Comment 1 by sjg@chromium.org, Oct 12 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 13 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/457ee22299fccdb9ad9d323d9567f2dc00056ad5

commit 457ee22299fccdb9ad9d323d9567f2dc00056ad5
Author: Simon Glass <sjg@chromium.org>
Date: Fri Oct 13 01:10:39 2017

Add support for reporting platform name from cros_config

Mosys needs to have a platform name that it can report with
'mosys platform name'. Add decoding of this from the master configuration.

BUG= chromium:774248 
BRANCH=none
TEST=FEATURES=test emerge-coral --nodeps mosys

Change-Id: I15bc42e1e86f1b59d5debf5414b50a15eb087765
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/717259
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/457ee22299fccdb9ad9d323d9567f2dc00056ad5/include/lib/cros_config.h
[modify] https://crrev.com/457ee22299fccdb9ad9d323d9567f2dc00056ad5/lib/cros_config/cros_config.c
[modify] https://crrev.com/457ee22299fccdb9ad9d323d9567f2dc00056ad5/tests/test_config.dts
[modify] https://crrev.com/457ee22299fccdb9ad9d323d9567f2dc00056ad5/tests/simple_tests.c

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e26635ae85c54c3465dd256444b6316ae2bcbe0a

commit e26635ae85c54c3465dd256444b6316ae2bcbe0a
Author: Simon Glass <sjg@chromium.org>
Date: Fri Oct 13 01:13:04 2017

chromeos-config: Add support for the platform name

We need to add the concept of a platform name so that mosys can report it
correctly. Associate this with a SKU map, since this mirrors mosys's usage
(the platform name defines the SKU map to use) and we don't expect it to
be model-specific.

BUG= chromium:774248 
TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools

Change-Id: Iaeabff7e76604f4e527b24d5d4c1cf400ee3ca80
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/717042
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/e26635ae85c54c3465dd256444b6316ae2bcbe0a/chromeos-config/README.md

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16 2017

Comment 7 by sjg@chromium.org, Oct 17 2017

Status: Fixed (was: Started)

Sign in to add a comment