Can you share how we got to the conclusion that we needed these three states?  One of our goals for Media Remoting was for it to be opaque to users, and this is definitely backing away from that.  I appreciate there are cases where we need to offer an opt-out (e.g. captions), but this seems more extreme.  Did we consider using any sort of aggregation across users to do this automatically (e.g., most users disable media remoting on this site, so disable it across the board)?

skonig: This is a replacement for the "disable button" we had in the video in the page content area. It turns out it is too common for web pages to assume they have complete user input event control over the video element, which means the disable button is broken or otherwise too-often causes broken behaviors in the web page when remoting is active. Therefore, we'd like to move this to the Media Router dialog alongside the other mirroring session controls.

Let me be more specific about the behavior and intentions of each:

* Auto is the default, normal behavior, where Media Remoting activates only when we think the user's environment can support it (e.g., good-enough WiFi). It also falls-back to mirroring when conditions change and require traditional mirroring be used instead.

* Never is the "disable button": This allows users to prevent remoting from ever activating. This is needed for some use cases remoting cannot support, such as showing captions on the TV.

* Always is meant for cases where remoting activates, but keeps shutting off at random times. For example, maybe the user knows their WiFi is not ideal and is willing to accept hiccups or other momentary pauses and would rather remoting did not revert back to mirroring when that happens since it would not improve their experience.

Our intention is for this setting to be persisted as a user pref across mirroring sessions. Per-domain was considered, but there shouldn't be per-domain reasons to change this (give the purpose behind each setting).

FWIW, "Always" is the only new functionality being proposed (by me), and is certainly open for further discussion. Auto/Never are the same functionality currently provided by the "disable button" in the video content area that we have all agreed were needed.

> One of our goals for Media Remoting was for it to be opaque to users...

True. However, we quickly discovered the need for the "disable button" due to certain use cases that don't have feasible technical/auto-prediction solutions. This setting will be somewhat silently tucked-away in the MR dialog mirroring controls. All users would start out with Auto and, ideally, would never have a reason to change it. It's only the few special cases where they might change it (because we can't automate the right decision for those special cases).

> Did we consider using any sort of aggregation across users to do this automatically...

Not yet. But, as I described above, I'm don't believe this should be a per-domain setting.

I would recommend we move product-level discussion to an internal alias (or, better yet, a face to face conversation) and report back here with the conclusion and our rationale.

I'll schedule some time for us to discuss.  I get the rationale behind Never (and Auto being the counter to that), however I'm skeptical about Always.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04f7bcfcbed919044ac6b341b0d362a365531d0

commit c04f7bcfcbed919044ac6b341b0d362a365531d0
Author: Bin Zhao <zhaobin@chromium.org>
Date: Fri Nov 17 06:38:05 2017

[Media Router] (ui) Added a Media Remoting control to MR dialog

- Added an 'always use mirroring' checkbox to MR (route control) dialog.
  The checkbox only shows up if a route is a local mirroring route.
- Send 'setMediaRemotingEnabled' message to chrome when user
  changes 'always use mirroring' checkbox value

Bug:  774245 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I85c9f9ec8bd320ba1f4eebba4f1fb6223dfda084
Reviewed-on: https://chromium-review.googlesource.com/717317
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517327}
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/resources/media_router/media_router_browser_api.js
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
[modify] https://crrev.com/c04f7bcfcbed919044ac6b341b0d362a365531d0/chrome/test/data/webui/media_router/route_controls_tests.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/761b5363493444d07bd36f0c42528ea3f69c95ea

commit 761b5363493444d07bd36f0c42528ea3f69c95ea
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Nov 22 21:26:29 2017

[MediaRouter] Plumb MR dialog control for media remoting to prefs.

Add a boolean pref for whether media remoting should be enabled.

The pref value is also exposed to the MR extension so it can use the
value to enable/disable remoting.

Created a MirroringMediaRouteController subclass. The role of the class
is to (1) update the media remoting pref according to user input, and
(2) augment the MediaStatus update sent by the MRP with the media
remoting bit.


Patched from crrev.com/767827.

Bug:  774245 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibe870ef217bad3c98cee7b97fd6d7f8fe8013a7d
Reviewed-on: https://chromium-review.googlesource.com/779710
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518751}
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/media/router/mojo/media_route_controller.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/media/router/mojo/media_route_controller.h
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/media/router/mojo/media_route_controller_unittest.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/resources/media_router/media_router_browser_api.js
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/media_router/media_route.h
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/media_router/media_status.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/media_router/media_status.h
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/pref_names.cc
[modify] https://crrev.com/761b5363493444d07bd36f0c42528ea3f69c95ea/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac386d69d24c335e60ce306a6d085e3b0184358a

commit ac386d69d24c335e60ce306a6d085e3b0184358a
Author: Derek Cheng <imcheng@chromium.org>
Date: Thu Nov 30 23:17:19 2017

[Media Router] Only use new mirroring controls if remoting is enabled.

The new controls (which contains option to enable/disable remoting)
should not be shown if the user does not have remoting enabled.

Bug:  774245 
Change-Id: I9f77f360f7af89736bb3be7efb5537dbbff4951e
Reviewed-on: https://chromium-review.googlesource.com/798357
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520738}
[modify] https://crrev.com/ac386d69d24c335e60ce306a6d085e3b0184358a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3923e4a52c22908d0be6e807886ca7adde49ff0

commit a3923e4a52c22908d0be6e807886ca7adde49ff0
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Dec 01 02:10:11 2017

[Media Router] Strings for media remoting controls.

These strings will be used in a dropdown menu (which will replace the
"always use mirroring" checkbox) in the route controls.

Bug:  774245 
Change-Id: If851a0c80cf715f360f30238273d926783f72a5b
Reviewed-on: https://chromium-review.googlesource.com/798590
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520793}
[modify] https://crrev.com/a3923e4a52c22908d0be6e807886ca7adde49ff0/chrome/app/media_router_strings.grdp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261c5fa9b60b79811c9d860270855c12fd04caa2

commit 261c5fa9b60b79811c9d860270855c12fd04caa2
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Dec 05 03:26:42 2017

[Media Router] Dropdown for media remoting controls.

The dropdown will replace the checkbox that is currently in place to
control whether media remoting is enabled.

Note that this is not meant to be the final iteration of the UX; it is
however an improvement over the existing checkbox and is a reasonable
interim solution (while we gather feedback + do another UX study)

Screenshots:
LTR: https://screenshot.googleplex.com/dSPAZY4yHd5
RTL: https://screenshot.googleplex.com/apBUWUvp74q

BUG= 774245 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I296c47cae0ecf4d16b5b645f92af00a2e1161d4f
Reviewed-on: https://chromium-review.googlesource.com/804138
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521604}
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/resources/media_router/media_router.css
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/resources/media_router/media_router_common.css
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc
[modify] https://crrev.com/261c5fa9b60b79811c9d860270855c12fd04caa2/chrome/test/data/webui/media_router/route_controls_tests.js

Requesting merge to 64 for the above patch. Thanks!

Approving merge to M64 Chrome OS.

I am putting this back in Merge-Request-64 to get approval to merge into 64 desktop and not just Chrome OS. Thanks!

This bug requires manual review: There is .grd file changes and we are only 46 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M64 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0e4ef528af5cd6740a5f362509cba4d18c25bc

commit df0e4ef528af5cd6740a5f362509cba4d18c25bc
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Dec 08 00:01:39 2017

[Media Router] Dropdown for media remoting controls.

The dropdown will replace the checkbox that is currently in place to
control whether media remoting is enabled.

Note that this is not meant to be the final iteration of the UX; it is
however an improvement over the existing checkbox and is a reasonable
interim solution (while we gather feedback + do another UX study)

Screenshots:
LTR: https://screenshot.googleplex.com/dSPAZY4yHd5
RTL: https://screenshot.googleplex.com/apBUWUvp74q

BUG= 774245 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I296c47cae0ecf4d16b5b645f92af00a2e1161d4f
Reviewed-on: https://chromium-review.googlesource.com/804138
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521604}(cherry picked from commit 261c5fa9b60b79811c9d860270855c12fd04caa2)
Reviewed-on: https://chromium-review.googlesource.com/815935
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#81}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/resources/media_router/media_router.css
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/resources/media_router/media_router_common.css
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc
[modify] https://crrev.com/df0e4ef528af5cd6740a5f362509cba4d18c25bc/chrome/test/data/webui/media_router/route_controls_tests.js

imcheng can you close this out?