Add a build_type:pre_cq tag for a Pre-CQ Buildbucket request |
|||
Issue descriptionI'm going to add a tag (build_type:pre_cq) for all Pre-CQ builds. Let me know if this affects you.
,
Oct 12 2017
Check out the "cbb_display_group" tag which is already being set.
,
Oct 12 2017
cbb_display_group shows 'Production Tryjob' or 'Tryjob', but I need 'pre_cq'.
,
Oct 12 2017
If the new waterfall doesn't filter on build_type flag, I'll add build_type to all tryjobs (like https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/stages/scheduler_stages.py?l=61) ?
,
Oct 12 2017
if the new waterfall does rely on the build_type flag, I'll only add build_type:pre_cq for all Pre-CQ builds.
,
Oct 16 2017
So Production Tryjob = pre_cq in cbb_display_group ?
,
Oct 16 2017
I think it will be reasonable to rename "Producuction Tryjob" to "Pre CQ" or whatever friendly name you would prefer.
,
Oct 16 2017
Re #6: I'll add build_type:pre_cq and will not touch cbb_display_group
,
Oct 16 2017
Sure. Let us rename cbb_display_group to "Pre CQ" as well. Let's also decide on a list of names for other groups. I'll update go/cros-builds-group
,
Oct 16 2017
Or you can hold off changing the cbb_display_group until we decide on the name format of the display group.
,
Oct 30 2017
,
Oct 30 2017
I believe that CL:731827 will define teh pre_cq value, and it will be used after CL:731828.
,
Feb 22 2018
fixed at https://chromium-review.googlesource.com/c/chromiumos/chromite/+/754292 |
|||
►
Sign in to add a comment |
|||
Comment 1 by nxia@chromium.org
, Oct 12 2017