New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774244 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add a build_type:pre_cq tag for a Pre-CQ Buildbucket request

Project Member Reported by nxia@chromium.org, Oct 12 2017

Issue description

I'm going to add a tag (build_type:pre_cq) for all Pre-CQ builds. Let me know if this affects you. 
 

Comment 1 by nxia@chromium.org, Oct 12 2017

Owner: nxia@chromium.org
Check out the "cbb_display_group" tag which is already being set.

Comment 3 by nxia@chromium.org, Oct 12 2017

cbb_display_group shows 'Production Tryjob' or 'Tryjob', but I need 'pre_cq'.

Comment 4 by nxia@chromium.org, Oct 12 2017

If the new waterfall doesn't filter on build_type flag, I'll add build_type to all tryjobs (like https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/stages/scheduler_stages.py?l=61) ? 

Comment 5 by nxia@chromium.org, Oct 12 2017

if the new waterfall does rely on the build_type flag, I'll only add build_type:pre_cq for all Pre-CQ builds.
So Production Tryjob = pre_cq in cbb_display_group ? 
I think it will be reasonable to rename "Producuction Tryjob" to "Pre CQ" or whatever friendly name you would prefer.

Comment 8 by nxia@chromium.org, Oct 16 2017

Re #6: I'll add build_type:pre_cq and will not touch cbb_display_group

Sure. Let us rename cbb_display_group to "Pre CQ" as well. Let's also decide on a list of names for other groups. I'll update go/cros-builds-group
Or you can hold off changing the cbb_display_group until we decide on the name format of the display group. 
Labels: Legoland CrOS-Swarming
I believe that CL:731827 will define teh pre_cq value, and it will be used after CL:731828.

Comment 13 by nxia@chromium.org, Feb 22 2018

Status: Fixed (was: Untriaged)
fixed at https://chromium-review.googlesource.com/c/chromiumos/chromite/+/754292

Sign in to add a comment