New issue
Advanced search Search tips

Issue 774229 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 774213



Sign in to add a comment

With white-space: pre-line, space before '\n' should be collapsed but is not

Project Member Reported by xiaoche...@chromium.org, Oct 12 2017

Issue description

Chrome Version: ToT r508367

What steps will reproduce the problem?
(1) Load https://jsfiddle.net/9twgry47/

What is the expected result?

The space after letter 'F' is collapsed, and the border in the first line should end at right boundary of 'F'

What happens instead?

The space after 'F' is preserved, and the border ends after 'F'

The test case works fine in Firefox.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d95c8d6e47c8b1c0f77e37fb143058077ecabb4

commit 6d95c8d6e47c8b1c0f77e37fb143058077ecabb4
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon Jun 04 13:24:08 2018

[LayoutNG] Rebaseline editing/pasteboard/copy-paste-white-space.html and change expectation

The layout test currently fails in LayoutNG because the legacy baseline
is wrong: with 'white-space: pre-line', legacy fails to collapse spaces
before '\n', which is fixed in NG.

Hence, this patch corrects the baseline, and marks it fail in legacy and
pass in LayoutNG.

Bug: 774229
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I110ddef8dfff86b1097f514cad4bca7a2c8eb135
Reviewed-on: https://chromium-review.googlesource.com/1082985
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564074}
[modify] https://crrev.com/6d95c8d6e47c8b1c0f77e37fb143058077ecabb4/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/6d95c8d6e47c8b1c0f77e37fb143058077ecabb4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6d95c8d6e47c8b1c0f77e37fb143058077ecabb4/third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-white-space.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2abf7305cff4239716a76162319b772312b20f5

commit c2abf7305cff4239716a76162319b772312b20f5
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Jun 21 09:39:33 2018

[LayoutNG] Introduce NGPaintFragmentTraversal::MoveToParent() and MoveToPrevious()

This patch inttroduces |MoveToParent()| and |MoveToPrevious()| in
|NGPaintFragmentTraversal| class for the patch[1], which uses |MoveToPrevious()|
to find text fragment in same line.

This patch also utilize |MoveToParent()| in |MoveToNext()| to share code for
improving code health.

[1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to
LayoutNG;

Bug: 774229
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If65e3015b8f4ed768325c0e13df121c0bc378580
Reviewed-on: https://chromium-review.googlesource.com/1109609
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569199}
[modify] https://crrev.com/c2abf7305cff4239716a76162319b772312b20f5/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc
[modify] https://crrev.com/c2abf7305cff4239716a76162319b772312b20f5/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.h
[modify] https://crrev.com/c2abf7305cff4239716a76162319b772312b20f5/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f1818dec7dd55a6d5c99d9cdf4b27f17f29dea

commit 28f1818dec7dd55a6d5c99d9cdf4b27f17f29dea
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Jun 22 08:10:25 2018

[LayoutNG] Implement NGAbstractInlineTextBox::CharacterWidths()

This patch implements |NGAbstractInlineTextBox::CharacterWidths()| as follow-up
of the patch[1] introduced stub version.

This patch makes following three layout tests to pass:
 1. accessibility/inline-text-bidi-bounds-for-range.html
 2. accessibility/inline-text-bounds-for-range-br.html
 3. accessibility/inline-text-bounds-for-range.html

[1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to
LayoutNG;

Bug: 774229
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I479b394e810a7a81cb8e46d94a0d7db0b5c3fac3
Reviewed-on: https://chromium-review.googlesource.com/1109797
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569552}
[modify] https://crrev.com/28f1818dec7dd55a6d5c99d9cdf4b27f17f29dea/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/28f1818dec7dd55a6d5c99d9cdf4b27f17f29dea/third_party/blink/renderer/core/layout/ng/inline/ng_abstract_inline_text_box.cc

Labels: Fixed-In-LayoutNG

Sign in to add a comment