Build Cronet for iOS with ARC enabled |
|||
Issue descriptionMake Cronet.mm and cronet_environment.mm compile with ARC. Add configs += [ "//build/config/compiler:enable_arc" ] to the build file. Add #if !defined(__has_feature) || !__has_feature(objc_arc) #error "This file requires ARC support." #endif to the source files.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd67093872682f71d054e57fe7276c2e9ba75c96 commit bd67093872682f71d054e57fe7276c2e9ba75c96 Author: kapishnikov <kapishnikov@chromium.org> Date: Fri Oct 13 16:57:38 2017 Build Cronet for iOS with ARC enabled BUG= 774225 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7ca92a5f81520bcd7f7736a43181de79031fb9e5 Reviewed-on: https://chromium-review.googlesource.com/716777 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#508731} [modify] https://crrev.com/bd67093872682f71d054e57fe7276c2e9ba75c96/components/cronet/ios/BUILD.gn [modify] https://crrev.com/bd67093872682f71d054e57fe7276c2e9ba75c96/components/cronet/ios/Cronet.mm [modify] https://crrev.com/bd67093872682f71d054e57fe7276c2e9ba75c96/components/cronet/ios/cronet_environment.mm [modify] https://crrev.com/bd67093872682f71d054e57fe7276c2e9ba75c96/components/cronet/tools/generate_accept_languages.py
,
Oct 13 2017
,
Oct 16 2017
Cherry-picking the fix (bd67093872682f71d054e57fe7276c2e9ba75c96) to M63 branch 3239. The fix only contains changes in Cronet component and has no impact on Chromium since none of the Chromium code depends on the Cronet package.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d20475e2fc27e70d991851914f3239619e481d1e commit d20475e2fc27e70d991851914f3239619e481d1e Author: kapishnikov <kapishnikov@chromium.org> Date: Mon Oct 16 15:47:21 2017 Build Cronet for iOS with ARC enabled BUG= 774225 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7ca92a5f81520bcd7f7736a43181de79031fb9e5 Reviewed-on: https://chromium-review.googlesource.com/716777 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508731}(cherry picked from commit bd67093872682f71d054e57fe7276c2e9ba75c96) Reviewed-on: https://chromium-review.googlesource.com/721459 Cr-Commit-Position: refs/branch-heads/3239@{#10} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/d20475e2fc27e70d991851914f3239619e481d1e/components/cronet/ios/BUILD.gn [modify] https://crrev.com/d20475e2fc27e70d991851914f3239619e481d1e/components/cronet/ios/Cronet.mm [modify] https://crrev.com/d20475e2fc27e70d991851914f3239619e481d1e/components/cronet/ios/cronet_environment.mm [modify] https://crrev.com/d20475e2fc27e70d991851914f3239619e481d1e/components/cronet/tools/generate_accept_languages.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by kapishnikov@chromium.org
, Oct 12 2017