Typing in an etherpad document jumps the page around
Reported by
todd.ken...@gmail.com,
Oct 12 2017
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Example URL: https://oasis.sandstorm.io/shared/Kcyuf6xCRz1-8qacjEhI-EBKPwIryjvXPVzlkVYuNDT Steps to reproduce the problem: 1. Go to any etherpad-lite instance 2. Paste in a script that is longer than the page 3. Scroll to the bottom and try to type What is the expected behavior? The browser stays focused on the section you're typing in What went wrong? The page jumps up and down continuously as you type rather than staying focused on the correct part of the page. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chrome 58 Does this work in other browsers? Yes Chrome version: 61.0.3163.100 Channel: stable OS Version: OS X 10.11.6 Flash Version:
,
Oct 13 2017
Able to reproduce this issue on reported version 61.0.3163.100 and latest Canary 63.0.3238.0 using Win 10, Ubuntu 14.04 and Mac 10.12.6 Bisect Information: ==================== Good build: 61.0.3157.0 -Revision :486615 Bad Build: 61.0.3158.0 -Revision:486952 Bisect Tool Info: ---------------- You are probably looking for a change made after 486681 (known good), but no later than 486682 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/ec7832af966579298a2e9886117a7171d64b8122..6ce9d62f9ff5113c4a5c2f39ebf998187feedc5c Suspecting: https://chromium-review.googlesource.com/550237 @Sandra Sun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Oct 13 2017
bokan@, majidvp@, flackr@ FYI. Sandra please ensure that this gets investigated ASAP.
,
Oct 13 2017
,
Oct 16 2017
sunyunjia@: Please also confirm if the fix(when its available) will be safe enough merge for M-62 as well. Looping in M-62 release owners as well.
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6247becd3a3621eea409ea4758f70a9a4491a39e commit 6247becd3a3621eea409ea4758f70a9a4491a39e Author: Sandra Sun <sunyunjia@chromium.org> Date: Wed Oct 18 18:26:17 2017 Reset PendingOffset for LocalFrameView During ScrollIntoView process, if a LocalFrameView's scroll is added to the scroll sequence and is not scrolled instantly, a pending_offset will be added to calculate its ancestors' scroll_offset properly. However, this pending_offset is not correctly reset each time, so if ScrollIntoView is called for the second time on a same LocalFrameView, the pending_offset may be incorrect. This patch resets this pending_offset whenever a ScrollIntoView is called so that we won't mistakenly re-apply the already-scrolled offset as a pending_offset. Bug: 774222 Change-Id: I798a120e0937fe2f6cc6b389c2bb2c4fc6a4889d Reviewed-on: https://chromium-review.googlesource.com/723132 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#509816} [add] https://crrev.com/6247becd3a3621eea409ea4758f70a9a4491a39e/third_party/WebKit/LayoutTests/fast/scroll-behavior/resources/scroll-into-view-twice-iframe.html [add] https://crrev.com/6247becd3a3621eea409ea4758f70a9a4491a39e/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-iframe-into-view-twice.html [modify] https://crrev.com/6247becd3a3621eea409ea4758f70a9a4491a39e/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
,
Oct 18 2017
,
Oct 19 2017
Issue 776325 has been merged into this issue.
,
Oct 19 2017
sunyunjia@, dtapuska@: Do we need to merger this back in M62?
,
Oct 19 2017
62 has sailed. You should probably merge to 63 once it is tested in a Canary build.
,
Oct 20 2017
Verified on Canary 64.0.3245.0
,
Oct 23 2017
,
Oct 24 2017
,
Oct 24 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2017
Please merge your change to M63 branch 3239 by 4:00 PM PT tomorrow, Wednesday (10/25). Thank you.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cd8f993ec3734f62a9b495fafc33d91957c73f8 commit 2cd8f993ec3734f62a9b495fafc33d91957c73f8 Author: Sandra Sun <sunyunjia@chromium.org> Date: Wed Oct 25 00:56:56 2017 Reset PendingOffset for LocalFrameView During ScrollIntoView process, if a LocalFrameView's scroll is added to the scroll sequence and is not scrolled instantly, a pending_offset will be added to calculate its ancestors' scroll_offset properly. However, this pending_offset is not correctly reset each time, so if ScrollIntoView is called for the second time on a same LocalFrameView, the pending_offset may be incorrect. This patch resets this pending_offset whenever a ScrollIntoView is called so that we won't mistakenly re-apply the already-scrolled offset as a pending_offset. Bug: 774222 Change-Id: I798a120e0937fe2f6cc6b389c2bb2c4fc6a4889d Reviewed-on: https://chromium-review.googlesource.com/723132 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509816}(cherry picked from commit 6247becd3a3621eea409ea4758f70a9a4491a39e) Reviewed-on: https://chromium-review.googlesource.com/737149 Reviewed-by: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#202} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [add] https://crrev.com/2cd8f993ec3734f62a9b495fafc33d91957c73f8/third_party/WebKit/LayoutTests/fast/scroll-behavior/resources/scroll-into-view-twice-iframe.html [add] https://crrev.com/2cd8f993ec3734f62a9b495fafc33d91957c73f8/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-iframe-into-view-twice.html [modify] https://crrev.com/2cd8f993ec3734f62a9b495fafc33d91957c73f8/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
,
Oct 27 2017
,
Oct 30 2017
Issue 779202 has been merged into this issue.
,
Oct 30 2017
,
Oct 30 2017
,
Oct 30 2017
Verified on Chrome:63.0.3239.26 Device:Samsung Galaxy A7/MMB29K
,
May 4 2018
Issue 780888 has been merged into this issue. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 Deleted