Several VR tests are very flaky |
|||||||
Issue descriptionStarting at noon Oct 11, https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester is mostly red due to heavy flakiness in many VR tests. The affected tests are mostly "transition" tests (plus one input test) and they are failing with timeouts. The single flakiest test is "Vrdisplayactivate". The first failing build https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/203 featured change https://chromium-review.googlesource.com/709956 'Reland "VR: Move focus/secure origin checks to chrome/browser/vr/service"' which seems like a plausible culprit at first glance. List of unique failures so far: https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/246 org.chromium.chrome.browser.vr_shell.VrShellTransitionTest#testExitPresentationWebVrToVrShell https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/245 org.chromium.chrome.browser.vr_shell.WebVrInputTest#testControllerClicksRegisteredOnDaydream__ChromeTabbedActivity org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testNfcFiresVrdisplayactivate__ChromeTabbedActivity https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/244 org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testNfcFiresVrdisplayactivate__ChromeTabbedActivity https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/241 org.chromium.chrome.browser.vr_shell.WebVrInputTest#testPresentationLocksFocus__ChromeTabbedActivity org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testNfcFiresVrdisplayactivate__ChromeTabbedActivity https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/238 org.chromium.chrome.browser.vr_shell.WebVrInputTest#testControllerClicksRegisteredOnDaydream__ChromeTabbedActivity https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/237 org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testRequestPresentEntersVr__WebappActivity
,
Oct 12 2017
bsheedy FYI. I've got a fix in the works for testNfcFiresVrdisplayactivate, should hopefully hit the CQ soon otherwise I'll revert the offending CL.
,
Oct 12 2017
The VrShellTransitionTest#* failures should be fixed with this revert https://chromium-review.googlesource.com/c/chromium/src/+/717016 The rest should (hopefully) be fixed with Michael's CL.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37845e0f35e8801b7133c0e82262195778725f1a commit 37845e0f35e8801b7133c0e82262195778725f1a Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Oct 12 23:03:35 2017 VR: Fix race firing displayactivate There was a race between blink getting focus and letting us know the page is listening for activate, and the browser firing displayactivate on Android. This CL remembers the last display that was listening for activate, and sends displayactivate to that display if there are no better candidates to send the displayactivate to. Bug: 774211 Change-Id: I566babd6139769b7b2cadeece9b3e889f81fd237 Reviewed-on: https://chromium-review.googlesource.com/716806 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#508521} [modify] https://crrev.com/37845e0f35e8801b7133c0e82262195778725f1a/device/vr/vr_device.cc [modify] https://crrev.com/37845e0f35e8801b7133c0e82262195778725f1a/device/vr/vr_device.h
,
Oct 13 2017
,
Oct 13 2017
Looking at the bot, seems like we're back to baseline levels of VR flakiness :P
,
Mar 1 2018
,
Mar 1 2018
,
Aug 29
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aelias@chromium.org
, Oct 12 2017