pull lld on mac when doing a win/cross build |
|||
Issue descriptionWe don't use lld for anything on Mac, so it's not part of the default clang package. Add a conditional DEPS hook (`host_os == "mac" and checkout_win`) that downloads lld when targeting win on mac. https://chromium-review.googlesource.com/706813 already made us upload lld to somewhere, so that will be possible as soon as the next clang roll lands.
,
Oct 15 2017
Needs http://llvm.org/viewvc/llvm-project?view=revision&revision=315873 in addition to https://chromium-review.googlesource.com/c/chromium/src/+/720556
,
Oct 16 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1df4a695557335dfde1c19eb964e9bcc768e948c commit 1df4a695557335dfde1c19eb964e9bcc768e948c Author: Nico Weber <thakis@chromium.org> Date: Mon Oct 16 21:36:30 2017 mac: Download lld when targeting Windows. Still can't link base_unittests.exe though; the mt.exe libxml building logic means we don't build mt.exe (and link it into lld) by default on Mac :-/ This requires upstream r315873. Bug: 774209 Change-Id: Ib74469bf9d2ce02f04c6e5985d00db66ddb4cc81 Reviewed-on: https://chromium-review.googlesource.com/720556 Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509179} [modify] https://crrev.com/1df4a695557335dfde1c19eb964e9bcc768e948c/DEPS [add] https://crrev.com/1df4a695557335dfde1c19eb964e9bcc768e948c/tools/clang/scripts/download_lld_mac.py [modify] https://crrev.com/1df4a695557335dfde1c19eb964e9bcc768e948c/tools/clang/scripts/package.py
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59206c227bb69ffe45961b05de3cbe608854b3ce commit 59206c227bb69ffe45961b05de3cbe608854b3ce Author: Nico Weber <thakis@chromium.org> Date: Tue Oct 17 21:49:15 2017 mac: Make do-I-need-to-download-lld check actually work. Bug: 774209 Change-Id: Ia95ff7b9bb74d4b69067c121d0a95af96331199e Reviewed-on: https://chromium-review.googlesource.com/723941 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509549} [modify] https://crrev.com/59206c227bb69ffe45961b05de3cbe608854b3ce/tools/clang/scripts/download_lld_mac.py
,
Nov 7 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ddc34d682f7318225e1d3591bf081a6f393d476 commit 9ddc34d682f7318225e1d3591bf081a6f393d476 Author: Nico Weber <thakis@chromium.org> Date: Thu Dec 14 16:34:22 2017 mac: Remove now-unused code from lld downlod script. No intended behavior change. Bug: 774209 Change-Id: Iffa593253058c5ab8a81712be216b903be23b0c4 Reviewed-on: https://chromium-review.googlesource.com/826173 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524083} [modify] https://crrev.com/9ddc34d682f7318225e1d3591bf081a6f393d476/tools/clang/scripts/download_lld_mac.py
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce96b47065492432a419a12ee14ed2bf3ee59084 commit ce96b47065492432a419a12ee14ed2bf3ee59084 Author: Nico Weber <thakis@chromium.org> Date: Thu Dec 14 18:52:31 2017 win/cross: Allow building 64-bit chrome/win on Mac hosts. 64-bit builds have been working for a while now. 32-bit chrome/win still cannot build on Mac hosts due to bug 794838 . TBR=brettw Bug: 774209 , 794838 Change-Id: I762853e7e5d2b4470642402e8b585dfe8f84b53e Reviewed-on: https://chromium-review.googlesource.com/826010 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524129} [modify] https://crrev.com/ce96b47065492432a419a12ee14ed2bf3ee59084/build/config/BUILDCONFIG.gn [modify] https://crrev.com/ce96b47065492432a419a12ee14ed2bf3ee59084/docs/win_cross.md |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Oct 12 2017