New issue
Advanced search Search tips

Issue 774208 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 772022



Sign in to add a comment

Alternative proxy server should not be disabled if alternative job fails due to network change events

Project Member Reported by tbansal@chromium.org, Oct 12 2017 
As part of fixing Issue 684761, Http JobController stopped marking alternative services as broken if the alternative job fails due to network change events but the main job succeeds. However, due to a recent refactor that logic no longer applies for requests that are fetched over alternative proxies.

Http JobController should stop marking alternative proxy servers as broken if the alternative job fails due to network change events.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01018e8e756b69feb791341440879f6c07212887

commit 01018e8e756b69feb791341440879f6c07212887
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Oct 12 22:02:06 2017

Do not notify proxy delegate of bad alternative proxy server
if the alternative job failed due to network change

Bug:  774208 
Change-Id: Ic7c81a251c3b88b9d3232b48452934e8d4e2a6c7
Reviewed-on: https://chromium-review.googlesource.com/716567
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508492}
[modify] https://crrev.com/01018e8e756b69feb791341440879f6c07212887/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/01018e8e756b69feb791341440879f6c07212887/net/http/http_stream_factory_impl_job_controller_unittest.cc

Comment 2 by tbansal@chromium.org, Oct 12 2017

Status: Fixed (was: Started)

Comment 3 by tbansal@chromium.org, Nov 13 2017

Blocking: 772022
►

Sign in to add a comment