New issue
Advanced search Search tips

Issue 774198 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: false. failed to open UTS46 data with error: 4 in url_canon_icu.cc

Project Member Reported by ClusterFuzz, Oct 12 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6510078718115840

Fuzzer: libFuzzer_payment_method_manifest_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false. failed to open UTS46 data with error: 4 in url_canon_icu.cc
  SignalHandler
  url::UIDNAWrapper::UIDNAWrapper
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=501991:502034

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6510078718115840

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org a...@chromium.org ellyjo...@chromium.org pnangunoori@chromium.org
Components: Blink>Payments
Labels: Test-Predator-Wrong-CLs M-63 CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.
Thank You.
Components: -Blink>Payments UI>Browser>Payments
Owner: rouslan@chromium.org
Status: Started (was: Untriaged)
Cc: -a...@chromium.org -ellyjo...@chromium.org -msrchandra@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b24552f343b2bbd431c05dbfb3236bbc2ecd5c

commit 73b24552f343b2bbd431c05dbfb3236bbc2ecd5c
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Oct 13 18:52:10 2017

[Payments] Fix crash in payment manifest parser.

Before this patch, parsing payment method manifest with invalid UTF8
in the URL of the "supported_origins" would hit a CHECK() in GURL
constructor.

This patch rejects URLs that have invalid UTF8 before constructing a
GURL object and fingerprints that are not ASCII.

After this patch, the parser rejects payment method manifests with
invalid UTF8 in the URL of the "supported_origins".

Bug:  774198 
Change-Id: Ie18711a90db4876f762806851cc45e013f3326ad
Reviewed-on: https://chromium-review.googlesource.com/719156
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508767}
[modify] https://crrev.com/73b24552f343b2bbd431c05dbfb3236bbc2ecd5c/components/payments/content/utility/fingerprint_parser.cc
[modify] https://crrev.com/73b24552f343b2bbd431c05dbfb3236bbc2ecd5c/components/payments/content/utility/fingerprint_parser_unittest.cc
[modify] https://crrev.com/73b24552f343b2bbd431c05dbfb3236bbc2ecd5c/components/payments/content/utility/payment_manifest_parser.cc
[modify] https://crrev.com/73b24552f343b2bbd431c05dbfb3236bbc2ecd5c/components/payments/content/utility/payment_manifest_parser_unittest.cc

Status: Fixed (was: Started)
Should be fixed now.
Project Member

Comment 6 by ClusterFuzz, Oct 14 2017

ClusterFuzz has detected this issue as fixed in range 508753:508774.

Detailed report: https://clusterfuzz.com/testcase?key=6510078718115840

Fuzzer: libFuzzer_payment_method_manifest_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false. failed to open UTS46 data with error: 4 in url_canon_icu.cc
  SignalHandler
  url::UIDNAWrapper::UIDNAWrapper
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=501991:502034
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=508753:508774

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6510078718115840

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6510078718115840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment