[Bookmarks UI] Replace folder icon |
||||||
Issue descriptionCurrent icons are displaying too small because of padding within the png. Replace assets with new versions attached per UI review request.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bca67b142b9a04170ce1e1c0f8551244ab6cf28d commit bca67b142b9a04170ce1e1c0f8551244ab6cf28d Author: Marti Wong <martiw@chromium.org> Date: Fri Oct 13 04:17:41 2017 Replace folder icon assets per UI review request. (new iOS bookmark ui) screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7TzFkTzJWRmNRVk0 Bug: 774194 Change-Id: I914e672b57c8f305b1e4c4a05e519b272bfb3528 Reviewed-on: https://chromium-review.googlesource.com/716438 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#508583} [modify] https://crrev.com/bca67b142b9a04170ce1e1c0f8551244ab6cf28d/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new.png [modify] https://crrev.com/bca67b142b9a04170ce1e1c0f8551244ab6cf28d/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@2x.png [modify] https://crrev.com/bca67b142b9a04170ce1e1c0f8551244ab6cf28d/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@3x.png
,
Oct 13 2017
,
Oct 13 2017
Checked in today's canary and they haven't refreshed yet. Would you ping a comment in the implementation deck when they're visible and I can replace the screenshot? Thanks!
,
Oct 15 2017
,
Oct 16 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682 commit b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682 Author: Marti Wong <martiw@chromium.org> Date: Tue Oct 17 02:35:47 2017 Replace folder icon assets per UI review request. (new iOS bookmark ui) screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7TzFkTzJWRmNRVk0 Bug: 774194 Change-Id: I914e672b57c8f305b1e4c4a05e519b272bfb3528 Reviewed-on: https://chromium-review.googlesource.com/716438 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by: Ramya Sharma <ramyasharma@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508583}(cherry picked from commit bca67b142b9a04170ce1e1c0f8551244ab6cf28d) Reviewed-on: https://chromium-review.googlesource.com/722540 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#25} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new.png [modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@2x.png [modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@3x.png
,
Oct 17 2017
Verified "[Bookmarks UI] Replace folder icon"
Tested Build: 64.0.3242.0 canary
iOS: 11.1,10.3.3
Devices: iPad Mini, iPad 4, iPhone 6, iPhone 8
,
Oct 25 2017
Verified on 63.0.3239.19 Beta on iPhone 8 plus(iOS 11.0), iPhone 6s plus(iOS 11.1 beta 5), iPhone 5(iOS 9.3.5) and iPad Air(iOS 10.3.3) Bookmark UI folder icons are replaced and are displayed as per the latest UI, looks good |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by martiw@chromium.org
, Oct 13 2017