New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774194 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

[Bookmarks UI] Replace folder icon

Project Member Reported by amyroberts@chromium.org, Oct 12 2017

Issue description

Current icons are displaying too small because of padding within the png. 

Replace assets with new versions attached per UI review request. 
 
new foler icons.zip
1.2 KB Download

Comment 1 by martiw@chromium.org, Oct 13 2017

Status: Started (was: Assigned)

Comment 3 by martiw@chromium.org, Oct 13 2017

Status: Fixed (was: Started)
Checked in today's canary and they haven't refreshed yet. Would you ping a comment in the implementation deck when they're visible and I can replace the screenshot? Thanks!

Comment 5 by martiw@chromium.org, Oct 15 2017

Labels: Merge-Request-63
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 16 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682

commit b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682
Author: Marti Wong <martiw@chromium.org>
Date: Tue Oct 17 02:35:47 2017

Replace folder icon assets per UI review request. (new iOS bookmark ui)

screenshot: https://drive.google.com/file/d/0B1dtd3IUt4I7TzFkTzJWRmNRVk0

Bug:  774194 
Change-Id: I914e672b57c8f305b1e4c4a05e519b272bfb3528
Reviewed-on: https://chromium-review.googlesource.com/716438
Commit-Queue: Ramya Sharma <ramyasharma@chromium.org>
Reviewed-by: Ramya Sharma <ramyasharma@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#508583}(cherry picked from commit bca67b142b9a04170ce1e1c0f8551244ab6cf28d)
Reviewed-on: https://chromium-review.googlesource.com/722540
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#25}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new.png
[modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@2x.png
[modify] https://crrev.com/b7ad138ab1b5c4eafd736eb6e3bc7144b7c11682/ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_folder_new.imageset/bookmark_gray_folder_new@3x.png

Status: Verified (was: Fixed)
Verified "[Bookmarks UI] Replace folder icon"

Tested Build: 64.0.3242.0 canary
iOS: 11.1,10.3.3
Devices: iPad Mini, iPad 4, iPhone 6, iPhone 8
       
Verified on 63.0.3239.19 Beta on iPhone 8 plus(iOS 11.0), iPhone 6s plus(iOS 11.1 beta 5), iPhone 5(iOS 9.3.5) and iPad Air(iOS 10.3.3)

Bookmark UI folder icons are replaced and are displayed as per the latest UI, looks good

Sign in to add a comment