New issue
Advanced search Search tips

Issue 774178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-config-tools needs to install python tools properly

Project Member Reported by sjg@chromium.org, Oct 12 2017

Issue description

See this CL:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/707174

I cannot figure out how to make the normal install thing work. It gives 'permission denied'. I wonder if it is due to installing a module where the cros-workon source is in a subdir of the repo (platform2)?

Anyway, it needs further investigation, either by insight from those who know, or digging into portage.
 

Comment 1 by sjg@chromium.org, Oct 17 2017

Labels: -Pri-1 Pri-2
The CL is submitted, but the problem still exists. Will revisit in November when the current effort is over.

Comment 2 by sjg@chromium.org, Oct 17 2017

Labels: -Pri-2 Pri-3

Comment 3 by sjg@chromium.org, Nov 4 2017

Labels: Unibuild

Comment 4 by sjg@chromium.org, Nov 6 2017

Owner: la...@chromium.org
One more
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/da9a8ac3fdc5d99b61608f1795a4276b0e8660a1

commit da9a8ac3fdc5d99b61608f1795a4276b0e8660a1
Author: Lann Martin <lannm@chromium.org>
Date: Wed Nov 08 23:10:22 2017

chromeos-config: Fix python packaging

Update setup.py and main entrypoints to support being installed as a
standard python package.

BUG= 774178 
TEST=sudo emerge -C chromeos-config-host; python setup.py install;
  verify that cros_config_host_py works

Change-Id: I5d4935b48f8f77bf4750428f38e7ada8c1bf47a6
Reviewed-on: https://chromium-review.googlesource.com/757050
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/da9a8ac3fdc5d99b61608f1795a4276b0e8660a1/chromeos-config/setup.py
[modify] https://crrev.com/da9a8ac3fdc5d99b61608f1795a4276b0e8660a1/chromeos-config/cros_config_host.py
[modify] https://crrev.com/da9a8ac3fdc5d99b61608f1795a4276b0e8660a1/chromeos-config/validate_config.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/23351a9b112ab139a462ce9eaba7673893882879

commit 23351a9b112ab139a462ce9eaba7673893882879
Author: Lann Martin <lannm@chromium.org>
Date: Thu Nov 09 06:21:52 2017

chromeos-config-tools: Split python host tools into another ebuild

The tools that run on boards stay in chromeos-config-tools while the
tools that only run on the host move into chromeos-config-host.

BUG= 774178 
TEST=sudo env FEATURES=test emerge chromeos-config-tools chromeos-config-host

Change-Id: I58fcade45b76657d06ce2520c2f0f218f97f1e45
Reviewed-on: https://chromium-review.googlesource.com/756961
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[rename] https://crrev.com/23351a9b112ab139a462ce9eaba7673893882879/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r89.ebuild
[add] https://crrev.com/23351a9b112ab139a462ce9eaba7673893882879/chromeos-base/chromeos-config-host/chromeos-config-host-9999.ebuild
[modify] https://crrev.com/23351a9b112ab139a462ce9eaba7673893882879/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
[add] https://crrev.com/23351a9b112ab139a462ce9eaba7673893882879/chromeos-base/chromeos-config-tools/files/chromeos-version.sh
[modify] https://crrev.com/23351a9b112ab139a462ce9eaba7673893882879/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0e0f3d7d81bb5a7cd619e61bbd09698b33e35d84

commit 0e0f3d7d81bb5a7cd619e61bbd09698b33e35d84
Author: Lann Martin <lannm@chromium.org>
Date: Mon Nov 13 01:44:30 2017

chromeos-config-host: switch to distutils install

The setup.py for this project has been updated to replace the custom
src_install here.

Also, remove unnecessary platform eclass.

BUG= 774178 
TEST=sudo env FEATURES=test emerge chromeos-config-host;
  check for /usr/bin/{cros_config_host_py,validate_config}

Change-Id: If4c074fd5b4c059caae5e9f2fecdbb65672c043a
Reviewed-on: https://chromium-review.googlesource.com/760676
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/0e0f3d7d81bb5a7cd619e61bbd09698b33e35d84/chromeos-base/chromeos-config-host/chromeos-config-host-9999.ebuild

Comment 8 by la...@chromium.org, Nov 13 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 11 2017

Labels: merge-merged-factory-coral-10122.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/956822f10ed6efe7cb1340c00a9de703f93122e2

commit 956822f10ed6efe7cb1340c00a9de703f93122e2
Author: Lann Martin <lannm@chromium.org>
Date: Mon Dec 11 09:01:57 2017

chromeos-config-host: switch to distutils install

The setup.py for this project has been updated to replace the custom
src_install here.

Also, remove unnecessary platform eclass.

BUG= 774178 
TEST=sudo env FEATURES=test emerge chromeos-config-host;
  check for /usr/bin/{cros_config_host_py,validate_config}

Change-Id: If4c074fd5b4c059caae5e9f2fecdbb65672c043a
Reviewed-on: https://chromium-review.googlesource.com/760676
Commit-Ready: Lann Martin <lannm@chromium.org>
Tested-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/794712
Reviewed-by: Marco Chen <marcochen@chromium.org>
Commit-Queue: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>

[modify] https://crrev.com/956822f10ed6efe7cb1340c00a9de703f93122e2/chromeos-base/chromeos-config-host/chromeos-config-host-9999.ebuild

Sign in to add a comment