New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774177 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 780957



Sign in to add a comment

Spin up VR Linux trybot & waterfall bot

Project Member Reported by jbudorick@chromium.org, Oct 12 2017

Issue description

^^

Needs unique GN flags. Will run as a partial CQ bot w/ CQ_INCLUDE_TRYBOTS.
 
Here are the gn args we use to compile unit-tests and the app locally (minus the use_goma switch):

target_os="linux"
is_component_build=true
enable_vr=true
use_ozone=true

is component build necessary, or just used for expediency in local builds?
The latter - is_component_build isn't required.
John, could you estimate a rough timeline for this, so we know what to expect?  Thanks!
Blockedon: 780957
Are there particular targets that you're interested in? If so, what are they?
Targets:

- vr_common_unittests  (build and run tests)
- vr_common_perftests  (build-only at this point)
- vr_testapp  (build and ensure the app starts, if possible)

The testapp - I'm only expecting the bot will build the target.  However, if there is infrastructure in place to try and actually execute and see if it runs for X seconds without crashing, it'd be cool to know.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed664309352be8714287cd2e88b3a3286d1b3606

commit ed664309352be8714287cd2e88b3a3286d1b3606
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Nov 06 16:58:58 2017

Add configuration for VR Linux waterfall bot & trybot.

Bug: 774177
Change-Id: Ibc1b368ae7ec335f573fc85852ec8214f36e5f9c
Reviewed-on: https://chromium-review.googlesource.com/752027
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514153}
[modify] https://crrev.com/ed664309352be8714287cd2e88b3a3286d1b3606/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/ed664309352be8714287cd2e88b3a3286d1b3606/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/ed664309352be8714287cd2e88b3a3286d1b3606/tools/mb/mb_config.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/8dba503a541e015a4aa22009959d51e9ebd839f2

commit 8dba503a541e015a4aa22009959d51e9ebd839f2
Author: John Budorick <jbudorick@google.com>
Date: Wed Nov 08 19:26:26 2017

FYI bot's up: https://build.chromium.org/p/chromium.fyi/builders/VR%20Linux/builds/0

Failed one test in vr_common_unittests, but otherwise looks ok. Will work on the trybot next.
The bot has finally turned green, so it should be suitable for use as a trybot now.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/480a28db5a01a17263b559ff2c42f9bc7f153734

commit 480a28db5a01a17263b559ff2c42f9bc7f153734
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Dec 18 21:36:56 2017

Rename vr_linux bot to linux_vr

linux_vr better matches the names of other bots, and is what is being
used in other WIP CLs to set up the VR Linux trybot.

Bug: 774177
Change-Id: I525d94421c7cebfcaba2274dc0044b278a710e22
Reviewed-on: https://chromium-review.googlesource.com/833169
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524807}
[modify] https://crrev.com/480a28db5a01a17263b559ff2c42f9bc7f153734/tools/mb/mb_config.pyl

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4f1d630318868233081be9fec6ca061f8ab26e93

commit 4f1d630318868233081be9fec6ca061f8ab26e93
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Dec 19 17:50:15 2017

Mirror VR Linux FYI bot to trybot

Sets up "linux_vr" on tryserver.chromium.linux to mirror "VR Linux" on
chromium.fyi.

Bug: 774177
Change-Id: I7ba2ad6981bbd204227413b9aa93c917299361ef
Reviewed-on: https://chromium-review.googlesource.com/833206
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>

[modify] https://crrev.com/4f1d630318868233081be9fec6ca061f8ab26e93/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/4f1d630318868233081be9fec6ca061f8ab26e93/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/4f1d630318868233081be9fec6ca061f8ab26e93/masters/master.tryserver.chromium.linux/master.cfg

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b3fe42c140b158b502c3e9b68d5d4795cdb4f23

commit 6b3fe42c140b158b502c3e9b68d5d4795cdb4f23
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Dec 22 00:56:20 2017

Fix incorrect vr_testapp label in gn_isolate_map

Was previously set to build //chrome/browser/vr:vr_testapp instead of
//chrome/browser/vr/testapp:vr_testapp.

Bug: 774177
Change-Id: I89d63ae7f66d98a95d56d7baff5fa7ce0783b0eb
Reviewed-on: https://chromium-review.googlesource.com/841423
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525880}
[modify] https://crrev.com/6b3fe42c140b158b502c3e9b68d5d4795cdb4f23/testing/buildbot/gn_isolate_map.pyl

Sign in to add a comment