New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774163 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] auto revert setting page is broken.

Project Member Reported by chanli@chromium.org, Oct 12 2017

Issue description

Config is not updated when using the page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9b3dd31744c223e30530a38a0620f92adda20a97

commit 9b3dd31744c223e30530a38a0620f92adda20a97
Author: Chan <chanli@chromium.org>
Date: Thu Oct 12 20:42:50 2017

[Findit] Fix auto revert setting page.

And also changed the config names for auto_revert feature to make them easier to understand:
commit_gerrit_revert -> auto_commit_revert_compile,
revert_compile_culprit -> auto_create_revert_compile

Bug:774163
Change-Id: I1ff93ca8334dab9776dd43168ca5ae62926ca0df
Reviewed-on: https://chromium-review.googlesource.com/716799
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/services/revert.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/handlers/test/change_auto_revert_setting_test.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/handlers/config.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/templates/change_auto_revert_setting.html
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/handlers/change_auto_revert_setting.py
[modify] https://crrev.com/9b3dd31744c223e30530a38a0620f92adda20a97/appengine/findit/model/wf_config.py

Comment 2 by chanli@chromium.org, Oct 31 2017

Status: Verified (was: Started)

Sign in to add a comment