New issue
Advanced search Search tips

Issue 774150 link

Starred by 1 user
Status: Fixed
Owner:
tbarzic@chromium.org
Closed: Oct 2017
Cc:
jamescook@chromium.org
sky@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Lock/login screen windows can be activated behind a lock system modal dialog

Project Member Reported by tbarzic@chromium.org, Oct 12 2017 
It seems that ash does not correctly block lock screen windows (behind lock system modal dialog) from being activated:
https://cs.chromium.org/chromium/src/ash/wm/ash_focus_rules.cc?rcl=1fa1eff47a519f8637f10ad65c0d81eef01597c0&l=65

One manifestation:
1. On login screen, launch network config system modal dialog.
  (the dialog is expected to have focus upon showing)
2. Click on status tray - a tray bubble should be shown
3. Press Tab, to tab into the bubble
4. Press Esc, to close the tray bubble

5. System modal dialog is expected to get focus back - it doesn't
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/275eca00f04192bc3416ff0927fd7e79e3ecdf72

commit 275eca00f04192bc3416ff0927fd7e79e3ecdf72
Author: Toni Barzic <tbarzic@google.com>
Date: Mon Oct 16 17:42:47 2017

Correctly handle lock system-modal dialogs in ash focus rules

If lock system modal dialog is active, ash focus rules should prevent
any window that is stacked bellow the lock system modal dialog from
being activated - this was not the case, as the focus rules would
always compare the candidate window to system-modal container,
regardless of actual lock system modal container the dialog was in.

This meant that lock screen windows could be activated when a lock
system dialog was shown - they are stacked bellow
LockSystemModalContainer, but above SystemModalContainer.

BUG= 774150 

Change-Id: I6a145ff8dbeba73aee5affbf8c98c526c22b8afe
Reviewed-on: https://chromium-review.googlesource.com/717027
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509092}
[modify] https://crrev.com/275eca00f04192bc3416ff0927fd7e79e3ecdf72/ash/shell_port.cc
[modify] https://crrev.com/275eca00f04192bc3416ff0927fd7e79e3ecdf72/ash/shell_port.h
[modify] https://crrev.com/275eca00f04192bc3416ff0927fd7e79e3ecdf72/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/275eca00f04192bc3416ff0927fd7e79e3ecdf72/ash/wm/ash_focus_rules_unittest.cc

Comment 2 by tbarzic@chromium.org, Oct 30 2017

Labels: -M-63 M-64
Status: Fixed (was: Assigned)
►

Sign in to add a comment