New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 774147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocking:
issue 753585



Sign in to add a comment

Update Local NTP tab order

Project Member Reported by sfiera@chromium.org, Oct 12 2017

Issue description

Desired tab order should match visual order (top to bottom):

1. Omnibox (initial)
2. One Google Bar
3. Doodle (optional)
4. Voice Search
5. NTP Tiles
 

Comment 1 by sfiera@chromium.org, Oct 12 2017

Blocking: 753585

Comment 2 by treib@chromium.org, Oct 13 2017

Hm. I guess "follow the visual order" is a fairly hard requirement? It seems a bit weird to me to put the OGB first, because when you're tabbing through the page, that's almost certainly not what you want, so it just means 5 more "tab"s to get where you want to go.

Comment 3 by sfiera@chromium.org, Oct 13 2017

I don't know if it's a hard requirement, but it seemed to be the preference on https://crbug.com/753585. It's also the tab order on the remote NTP.

Comment 4 by sfiera@chromium.org, Oct 16 2017

Owner: sfiera@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc05f212344099e58bae26b21385768319fb4839

commit bc05f212344099e58bae26b21385768319fb4839
Author: Chris Pickel <sfiera@chromium.org>
Date: Mon Oct 16 12:34:18 2017

Local NTP: don't set tabindex

Allow the tab order to be set naturally by the flow of the document.

Also, improve tab/space navigation on non-white NTPs by automatically
focusing the doodle after the notifier is clicked.

Bug:  774147 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7a6154fce4ce983f55ea60a318a97dd44aab2954
Reviewed-on: https://chromium-review.googlesource.com/720917
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509027}
[modify] https://crrev.com/bc05f212344099e58bae26b21385768319fb4839/chrome/browser/resources/local_ntp/local_ntp.html
[modify] https://crrev.com/bc05f212344099e58bae26b21385768319fb4839/chrome/browser/resources/local_ntp/local_ntp.js

Comment 6 by sfiera@chromium.org, Oct 16 2017

Status: Fixed (was: Started)
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 7, mac 10.12.6 & Ubuntu 14.04 using chrome #64.0.3242.0 as per C#0.

Windows & Ubuntu behavior:
---------------
Tab order as below:

1. Omnibox  (Initial)
2. Google bar ( Gmail,images.Google apps Icon)
3. Voice Search
4. NTP Tiles

same steps repeats from 1 to 4 on tab every time

Mac behavior:
-------------
Tab order as below:

1. Omnibox  (Initial)
2. Bookmark icon
3. Extensions icons
4. Wrench menu icon
5. Show apps icon
6. 'Import bookmarks now' link
7. Google bar ( Gmail,images.Google apps Icon)
8. Voice Search
9. NTP Tiles

Please find the attached screencast of both Mac & windows .Please confirm on the fix & the expected behavior.

Note:
Observed same behavior in the older versions also (M62)

Thanks in advance..!


774147-Mac-M64.mp4
1.3 MB View Download
774147-Win 7 -M64.mp4
753 KB View Download

Comment 8 by sfiera@chromium.org, Oct 17 2017

Labels: -Needs-Feedback
Owner: jmukthavaram@chromium.org
Thanks, Jyothi. This looks correct, with two caveats:
* It's not clear whether this is the remote or local NTP. I think that the "share" icon on the doodle suggests it's the remote NTP, and this bug is about the local NTP.
* Since there was also a doodle at the time you made the videos, the doodle should have come after the One Google Bar and before Voice Search while tabbing.


Using these four flags should result in the full local NTP experience (or just search for local-ntp on chrome://flags):
chrome://flags/#use-google-local-ntp
chrome://flags/#one-google-bar-on-local-ntp
chrome://flags/#voice-search-on-local-ntp
chrome://flags/#doodles-on-local-ntp

To confirm that you're on the local NTP, you can use View > Developer > View Source. You should see view-source:chrome-search://local-ntp/local-ntp.html in the address bar.

If there's a doodle on google.com while you're testing, it should show up and you should be able to tab to it. If not, there are two "force doodle" options in this flag:
chrome://flags/#use-ddljson-api


There's nothing platform-specific in the changes here, so testing with any one desktop platform should be sufficient. Thanks!

Comment 9 by sfiera@chromium.org, Oct 18 2017

Owner: sfiera@chromium.org
Status: Started (was: Fixed)
Oops. I updated Canary: now Voice Search isn't tabbable. Fix shortly.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917b229f6c221ddd8be6519282634a4900099bad

commit 917b229f6c221ddd8be6519282634a4900099bad
Author: Chris Pickel <sfiera@chromium.org>
Date: Wed Oct 18 11:36:03 2017

Local NTP: restore tab to <div>, <span> elements

I removed the tabindex in https://crrev.com/c/720917, but that meant
that it was no longer possible to tab to the span and div elements.

Bug:  774147 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3c40b9b48b2daeb5a59eabfd9f679fc5a0c2e6f
Reviewed-on: https://chromium-review.googlesource.com/725288
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509744}
[modify] https://crrev.com/917b229f6c221ddd8be6519282634a4900099bad/chrome/browser/resources/local_ntp/local_ntp.html

Owner: jmukthavaram@chromium.org
Status: Fixed (was: Started)
OK!

Sign in to add a comment