[NTP::Push] Ignore pushed suggestions if they have been fetched before. |
|||
Issue descriptionIf the a pushed suggestions has been fetched before, it can either be still available, has been archived after another fetch, or has been dismissed by the user. Ignore the pushed suggestion if it falls below one of those categories.
,
Oct 13 2017
(Priority inheritance: P3 blocking a P2 should be a P2. Otherwise, revisit the blocked bug.)
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/421a9c7dfefaf01fef2012422d53fd287750c9d7 commit 421a9c7dfefaf01fef2012422d53fd287750c9d7 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Thu Oct 19 11:14:39 2017 [NTP::Push] Ignore pushed suggestions if they have been fetched before. When a pushed suggestion is received, ignore it if it exists in one of the following - Currently shown articles. - Dismissed articles (was already implemented before this CL). - Archived articles (i.e. possibly shown on previously opened NTPs). Bug: 774122 Change-Id: I46076e432b1ecd12c47e550a5faea7c0c36d6432 Reviewed-on: https://chromium-review.googlesource.com/713495 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510053} [modify] https://crrev.com/421a9c7dfefaf01fef2012422d53fd287750c9d7/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/421a9c7dfefaf01fef2012422d53fd287750c9d7/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
,
Oct 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vitaliii@chromium.org
, Oct 12 2017