New issue
Advanced search Search tips

Issue 774058 link

Starred by 1 user
Status: Fixed
Owner:
eirage@chromium.org
Closed: Oct 2017
Cc:
dtapu...@chromium.org
yosin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Regression: No I-beam on editable links

Reported by hu...@vewd.com, Oct 12 2017 
Steps:
1. content_shell -u "data:text/html,<a contenteditable='true' href='www'>Editable</a>"
2. Hover the link.

Expected: I-beam (shows information about editability)
Actual: Hand (information about editability is lost).

Works in 61.0.3163.100 and 62.0.3202.45, but not on ToT.

I bisected this down to:

 You are probably looking for a change made after 501291 (known good), but no later than 501293 (first known bad).
 CHANGELOG URL:
   https://chromium.googlesource.com/chromium/src/+log/f7f91782c6a16a5b7a9ba30b5a5c21a9671b757b..53a46aede88dac4189a493f1e6eb30868aa17929

so assigning to eirage@ .
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902ef4e53edcb011944f0f7cc3cd9a7d43b21759

commit 902ef4e53edcb011944f0f7cc3cd9a7d43b21759
Author: Ella Ge <eirage@chromium.org>
Date: Fri Oct 13 07:12:34 2017

editable links show text cursor

When hovering editable links, should show text cursor to show
information about editablity.

Add a:-webkit-any-link:read-write { cursor: text} in UA stylesheet

This matches what Firefox do.

Bug:  774058 ,  737452 
Change-Id: Id6fe4fcdf55dd22e7c320734fc8682a289d7e8c7
Reviewed-on: https://chromium-review.googlesource.com/716317
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508630}
[modify] https://crrev.com/902ef4e53edcb011944f0f7cc3cd9a7d43b21759/third_party/WebKit/Source/core/css/html.css
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39ddbd6c77f761e13a38bf4d9409452e1ca3b7f3

commit 39ddbd6c77f761e13a38bf4d9409452e1ca3b7f3
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Tue Oct 17 17:57:35 2017

Unit test that contenteditable links show an I-beam mouse cursor

Bug:  774058 
Change-Id: I05e14895d59609144b76264f04d081ee8657caeb
Reviewed-on: https://chromium-review.googlesource.com/718936
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509430}
[modify] https://crrev.com/39ddbd6c77f761e13a38bf4d9409452e1ca3b7f3/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/39ddbd6c77f761e13a38bf4d9409452e1ca3b7f3/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/39ddbd6c77f761e13a38bf4d9409452e1ca3b7f3/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Comment 3 by eirage@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment