New issue
Advanced search Search tips

Issue 774054 link

Starred by 2 users
Status: Started
Owner:
rayankans@chromium.org
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocked on:
issue 711354
Blocking:
issue 679300



Sign in to add a comment

Support uploads in Background Fetch

Project Member Reported by joh...@chromium.org, Oct 12 2017 
Chrome's Background Fetch implementation doesn't yet support uploads, i.e. requests with a non-empty body (e.g. POSTs).

In the short term, we should explicitly disable these with a clear error message.

In the long term, we should support uploads, which involves tasks like:
- consuming request body blobs and persisting them to disk
- logic determining whether it is safe to retry requests
- reporting uploaded/upload_total in progress events
- additional CORS security checks
- ideally a spec for resumable uploads

Comment 1 by rayankans@chromium.org, Aug 2

Owner: rayankans@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543f84f3db7dd16d26868913013742f6d2816aab

commit 543f84f3db7dd16d26868913013742f6d2816aab
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Aug 07 21:47:30 2018

[Background Fetch] Extract Request body blobs.

This is the first step in supporting uploads for Background Fetch

Bug: 774054
Change-Id: I13188181573fcd8464df0729a09190a42b5bd2d0
Reviewed-on: https://chromium-review.googlesource.com/1160848
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581349}
[modify] https://crrev.com/543f84f3db7dd16d26868913013742f6d2816aab/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/543f84f3db7dd16d26868913013742f6d2816aab/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d567caa14b94d1bac1d72e9c4dac9b7458786629

commit d567caa14b94d1bac1d72e9c4dac9b7458786629
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Sep 06 16:12:00 2018

[Background Fetch] Stop setting blob data handle

on web_requests. This causes us to crash when converting
FetchAPIRequest mojo type to content::ServiceWorkerFetchRequest
since the latter doesn't currently support request body.

Once we switch to using the mojo type everywhere in content, we
can start setting the blob data handle  again from blink.

Bug: 789854, 774054
Change-Id: Icec9a74b9302fb9731febc5adc30f4153dfb698c
Reviewed-on: https://chromium-review.googlesource.com/1209522
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589184}
[modify] https://crrev.com/d567caa14b94d1bac1d72e9c4dac9b7458786629/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/d567caa14b94d1bac1d72e9c4dac9b7458786629/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f450a830cea1418c01f48028b2422514a6b4cf1

commit 2f450a830cea1418c01f48028b2422514a6b4cf1
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Oct 24 19:59:12 2018

[Background Fetch] Create a feature flag for uploads.

Bug: 774054
Change-Id: I42ce8c29699701aec0df0de806ca5077bf49a056
Reviewed-on: https://chromium-review.googlesource.com/c/1297144
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602407}
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/content/child/runtime_features.cc
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/content/public/common/content_features.cc
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/content/public/common/content_features.h
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/2f450a830cea1418c01f48028b2422514a6b4cf1/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19947f44b3b572dd45eed7cb98fc34ca0c24e23e

commit 19947f44b3b572dd45eed7cb98fc34ca0c24e23e
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Nov 01 17:54:41 2018

[Background Fetch] Extract Request body blobs.

This was previously submitted as cl/1160848
This is the first step in supporting uploads for Background Fetch

Bug: 774054
Change-Id: I325302b77313b38f211cb035522f80308cc83e14
Reviewed-on: https://chromium-review.googlesource.com/c/1297973
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604635}
[modify] https://crrev.com/19947f44b3b572dd45eed7cb98fc34ca0c24e23e/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/19947f44b3b572dd45eed7cb98fc34ca0c24e23e/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31f4c5dd239568fadf35e6cec31247e16c16257a

commit 31f4c5dd239568fadf35e6cec31247e16c16257a
Author: Rayan Kanso <rayankans@google.com>
Date: Mon Nov 19 19:34:55 2018

[Background Fetch] Remove chromium specific WPT code

Also add an upload endpoint to test Background Fetch uploads.

Bug: 774054
Change-Id: I305e9f43b5d2e77a8e78e9e460e8398d771b03e0
Reviewed-on: https://chromium-review.googlesource.com/c/1341923
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609394}
[modify] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/abort.https.window.js
[add] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch-uploads.https.window-expected.txt
[add] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch-uploads.https.window.js
[modify] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt
[modify] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
[add] https://crrev.com/31f4c5dd239568fadf35e6cec31247e16c16257a/third_party/WebKit/LayoutTests/external/wpt/background-fetch/resources/upload.py
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3

commit 41a9ca69986fa5d27b12a939d6d49cb52b89f3b3
Author: Rayan Kanso <rayankans@google.com>
Date: Wed Nov 21 16:01:47 2018

Move disk cache entry logic to its own entity.

Add CacheStorageCacheEntryHandler which handles how blobs are written
to the disk cache and how they are read back.

This CL causes no behavioral changes, it is just a refactor.

CacheStorageCacheEntryHandler can now be specialized for Background
Fetch caches to store request body blobs instead of side blobs.

Bug: 774054
Change-Id: I4bea29ea53ea898e2b3e517fc3b0a74777280d16
Reviewed-on: https://chromium-review.googlesource.com/c/1338188
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610084}
[modify] https://crrev.com/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3/content/browser/BUILD.gn
[modify] https://crrev.com/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3/content/browser/cache_storage/cache_storage_cache.h
[add] https://crrev.com/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3/content/browser/cache_storage/cache_storage_cache_entry_handler.cc
[add] https://crrev.com/41a9ca69986fa5d27b12a939d6d49cb52b89f3b3/content/browser/cache_storage/cache_storage_cache_entry_handler.h
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a6dd4b4ba62708038819f8a0e87882429db31e

commit 21a6dd4b4ba62708038819f8a0e87882429db31e
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Dec 11 14:20:08 2018

[Background Fetch] Create a cache entry handler for BGF.

The handler uses the side data blob to store the request body if any.

Bug: 774054
Change-Id: I14ec3e992543937bef7a601bcb603103842c6acf
Reviewed-on: https://chromium-review.googlesource.com/c/1363205
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615515}
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/BUILD.gn
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[add] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/background_fetch/storage/cache_entry_handler_impl.cc
[add] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/background_fetch/storage/cache_entry_handler_impl.h
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/cache_storage/cache_storage_cache_entry_handler.cc
[modify] https://crrev.com/21a6dd4b4ba62708038819f8a0e87882429db31e/content/browser/cache_storage/cache_storage_cache_entry_handler.h
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4772a996ded50cb5c96b22ae8833bd9a16468a

commit cb4772a996ded50cb5c96b22ae8833bd9a16468a
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Dec 13 13:12:51 2018

[Background Fetch] Pass request bodies to the Download Service.

Bug: 774054
Change-Id: Ia1c45819af4f60d52d3b661efcbbcbd77c58a143
Reviewed-on: https://chromium-review.googlesource.com/c/1373825
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616286}
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/chrome/test/data/background_fetch/background_fetch.js
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_cross_origin_filter_unittest.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_request_info.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/background_fetch_request_info.h
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/storage/get_initialization_data_task.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/browser/background_fetch/storage/start_next_pending_request_task.cc
[modify] https://crrev.com/cb4772a996ded50cb5c96b22ae8833bd9a16468a/content/public/browser/background_fetch_delegate.h
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97

commit 5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Dec 13 13:18:29 2018

Include the request body when using the in memory driver.

Bug: 774054
Change-Id: I4251d752911818f4f5e499780815ef53fb30c640
Reviewed-on: https://chromium-review.googlesource.com/c/1374232
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616288}
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download.cc
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download.h
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download_driver.cc
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download_driver.h
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download_driver_unittest.cc
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/components/download/internal/background_service/in_memory_download_unittest.cc
[modify] https://crrev.com/5ccbac442b7e1a28562a5f4bd65dd1550ae8ea97/content/shell/browser/web_test/web_test_background_fetch_delegate.cc
[delete] https://crrev.com/9d5dd088b27805cbbe1c7c06b7173b46d6558eb2/third_party/blink/web_tests/external/wpt/background-fetch/fetch-uploads.https.window-expected.txt
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a

commit dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Dec 21 03:49:40 2018

Report upload progress to download client.

This CL uses the UploadProgressTracker and plumbs the information all the way
to the download client.
This is enabled for all possible paths:
- kNetworkService enabled
- kNetworService disabled
- in-memory downloads

Non-plumbing related changes:
- Add upload progress tracker to url_downloader.cc (kNetworkService enabled path)
- Turn on `enable_upload_progress` flag in download_utils.cc and in_memory_download.cc

Bug: 774054
Change-Id: I3dee625a5833312fbbec579784953c334d46b1f5
Reviewed-on: https://chromium-review.googlesource.com/c/1380540
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618450}
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/chrome/browser/background_fetch/background_fetch_download_client.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/chrome/browser/background_fetch/background_fetch_download_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/chrome/browser/offline_pages/prefetch/offline_prefetch_download_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/content/internal/download_driver_impl.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/controller_impl.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/controller_impl.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/controller_impl_unittest.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/debugging_client.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/debugging_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/download_driver.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/entry.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/entry.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/in_memory_download.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/in_memory_download.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/in_memory_download_driver.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/in_memory_download_driver.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/in_memory_download_unittest.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/background_service/test/mock_download_driver_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/common/download_response_handler.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/common/download_utils.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/common/resource_downloader.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/internal/common/resource_downloader.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/background_service/client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/background_service/test/empty_client.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/background_service/test/empty_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/background_service/test/mock_client.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/common/download_response_handler.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/components/download/public/common/download_url_parameters.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/content/browser/download/url_downloader.cc
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/content/browser/download/url_downloader.h
[modify] https://crrev.com/dfbd158d2a9dbd0a24ce988b3b8e288fac6ff92a/content/shell/browser/web_test/web_test_background_fetch_delegate.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867e3219d4783389a940c70f8bc6dbf1e1906d6e

commit 867e3219d4783389a940c70f8bc6dbf1e1906d6e
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Dec 21 14:17:54 2018

[Background Fetch] Display upload progress.

Use the progress updates from the DS, and make sure the registration
displays accurate information with regards to uploads.

Bug: 774054
Change-Id: Iccec2e61310442c051339505c2397bbaa244b50c
Reviewed-on: https://chromium-review.googlesource.com/c/1386865
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618515}
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/chrome/browser/background_fetch/background_fetch_download_client.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch.proto
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_registration_notifier.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_request_info.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_request_info.h
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_scheduler.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/background_fetch_scheduler_unittest.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/storage/get_initialization_data_task.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/browser/background_fetch/storage/start_next_pending_request_task.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/content/shell/browser/web_test/web_test_background_fetch_delegate.cc
[modify] https://crrev.com/867e3219d4783389a940c70f8bc6dbf1e1906d6e/third_party/blink/web_tests/external/wpt/background-fetch/fetch-uploads.https.window.js
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf2b3737af6bc079f56c445cb70d49c644db3f88

commit cf2b3737af6bc079f56c445cb70d49c644db3f88
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Jan 11 11:36:56 2019

[Background Fetch] Split download/upload progress in the delegate.

- Pass download/upload stats from storage to the delegate
- Keep track of in progress upload/download progress per request
- Rename variables for consistency

Bug: 919864, 774054
Change-Id: I7bf78a0e688753584bde51233ecd8c9f9b1049cd
Reviewed-on: https://chromium-review.googlesource.com/c/1405009
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621974}
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/content/public/browser/background_fetch_description.cc
[modify] https://crrev.com/cf2b3737af6bc079f56c445cb70d49c644db3f88/content/public/browser/background_fetch_description.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7321d2a63ea2415287f9481ea22080bc248c4d6

commit f7321d2a63ea2415287f9481ea22080bc248c4d6
Author: Rayan Kanso <rayankans@chromium.org>
Date: Wed Jan 16 22:21:26 2019

[Background Fetch] Include upload progress in the UI.

The progress bar total will be download_total + upload_total.

Bug: 774054
Change-Id: I69c8fc0e8aa82e43ea4225652ccee1a539171fd1
Reviewed-on: https://chromium-review.googlesource.com/c/1409012
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@google.com>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623398}
[modify] https://crrev.com/f7321d2a63ea2415287f9481ea22080bc248c4d6/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/f7321d2a63ea2415287f9481ea22080bc248c4d6/chrome/browser/background_fetch/background_fetch_delegate_impl.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a46e335ce6388b2124d8cc6348cd02f654d8095d

commit a46e335ce6388b2124d8cc6348cd02f654d8095d
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Jan 18 12:14:10 2019

[Background Fetch] Remove uploads feature flag.

Bug: 774054
Change-Id: Id043c7bfde953ce86addc358856418eb3104c2bb
Reviewed-on: https://chromium-review.googlesource.com/c/1416134
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624082}
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/content/child/runtime_features.cc
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/content/public/common/content_features.cc
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/content/public/common/content_features.h
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/a46e335ce6388b2124d8cc6348cd02f654d8095d/third_party/blink/renderer/platform/runtime_enabled_features.json5
►

Sign in to add a comment