Issue metadata
Sign in to add a comment
|
Settings: policy icon tooltips are missing |
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3236.0/10024.0.0 dev-channel Candy,Peppy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign in to Second user -> Go to chrome://settings/help/details page (2)Now at 'Channel' click on 'Administrator setting' info icon beside 'Change channel' Button and observe for info Message or tooltip (Please refer Video) Expected: Info Message should be seen on hovering on 'Administrator setting' info icon Actual: Instead info Message is seen missing This is Regression Issue as same is working fine in 63.0.3223.0/9977.0.0 dev-channel Peppy @stevenjb : Please confirm the issue Note: 1.Issue is also seen in 'Manage other Users' page for other Users 2.Issue is also seen at 'Automatically send diagnostic and usage data to google' and 'Enable Verified Access' 3.Issue is seen In Guest Mode and Supervised users settings page(i.e. 'Automatically send diagnostic and usage data to google' ,'Enable Verified Access' and 'Manage other Users')
,
Oct 12 2017
This was caused by changing settings boxes to relative positioning: https://chromium-review.googlesource.com/c/chromium/src/+/699195 I'm not sure what the right fix is here. Dave, thoughts?
,
Oct 13 2017
FWIW this seems to break all tooltips, at least on Chrome OS (including linux chromeos builds), not just policy indicator tooltips.
,
Oct 13 2017
It looks like the tooltip was appearing in the same place as the trigger. The tool tip normally appears near, but not on the trigger. By trigger I mean the thing (rectangle) the tooltip is giving a tip about. So the events to show and hide the tooltip would fire repeatedly. It was rather random whether the spinning events would end on a hide() or a show(), but that would determine whether the tooltip was shown.
,
Oct 13 2017
CL at https://chromium-review.googlesource.com/c/chromium/src/+/719581
,
Oct 13 2017
QA testing advice: After the fix lands, please watch for / test - the search bubbles show up in the right place (in chrome://settings there is a search field in the top center that will sometimes show yellow talk-bubbles, like crbug 771067) - the tooltips show up reliably (which is this bug) - if there any other little floating elements in the UI, maybe toasts
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f889022f1e61bace2efa5d54f6da3cae0402ad2 commit 5f889022f1e61bace2efa5d54f6da3cae0402ad2 Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Oct 16 22:47:36 2017 [MD settings] fix tooltips on policy icons This CL changes the relative position for tooltips vs the trigger for the tooltip so that the tooltip shows up reliably. Bug: 774046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I78f8fd6b95992a2c4e3f1a1d7b1ff43a969a4654 Reviewed-on: https://chromium-review.googlesource.com/719581 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#509188} [modify] https://crrev.com/5f889022f1e61bace2efa5d54f6da3cae0402ad2/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/5f889022f1e61bace2efa5d54f6da3cae0402ad2/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html [modify] https://crrev.com/5f889022f1e61bace2efa5d54f6da3cae0402ad2/ui/webui/resources/cr_elements/shared_vars_css.html
,
Oct 17 2017
I verified that this is working on ToT.
,
Oct 18 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dda3c312d4ae867c92a61984631ae4d3c38a85d commit 0dda3c312d4ae867c92a61984631ae4d3c38a85d Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Oct 18 19:08:56 2017 [MD settings] fix tooltips on policy icons This CL changes the relative position for tooltips vs the trigger for the tooltip so that the tooltip shows up reliably. Bug: 774046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I78f8fd6b95992a2c4e3f1a1d7b1ff43a969a4654 Reviewed-on: https://chromium-review.googlesource.com/719581 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509188}(cherry picked from commit 5f889022f1e61bace2efa5d54f6da3cae0402ad2) Reviewed-on: https://chromium-review.googlesource.com/726400 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#56} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/0dda3c312d4ae867c92a61984631ae4d3c38a85d/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/0dda3c312d4ae867c92a61984631ae4d3c38a85d/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html [modify] https://crrev.com/0dda3c312d4ae867c92a61984631ae4d3c38a85d/ui/webui/resources/cr_elements/shared_vars_css.html
,
Oct 18 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 12 2017Summary: Settings: policy icon tooltips are missing (was: Regression : Tooltip is seen Missing on clicking 'Administrator setting' info icon in chrome://settings/help/details page )