Issue metadata
Sign in to add a comment
|
Regression: Browser crash is seen on editing password field for Gmail.
Reported by
aiman.an...@etouch.net,
Oct 12 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3238.0 (Official Build)fc7c1e473dfde53eb32f2e6528d6b0f957f850f5-refs/heads/master@{#508208}(64-bit). OS: Mac(10.12.6). Test URL: https://www.google.com/gmail/about/# Steps to reproduce: 1.Launch Chrome, go to the above link and log in with valid credentials 2.On save password bubble click on the eye icon to edit password. 3.Enter long text in password field and click on save. 4.Observe. Actual Result: Browser crash is seen on entering text in save password field and saving it. Expected Result: Browser crash should not be seen. Uploaded Crash Report ID fc14b719f0c53741 (Local Crash ID: b50b797e-bfe9-4ceb-98e1-0938d399860b) This is regression issue broken in ‘M-63’ and will soon update other info. Using the per-revision bisect providing the bisect results, Good Build: 63.0.3236.0 Bad Build: 63.0.3237.7
,
Oct 12 2017
Using the per-revision bisect providing the bisect results, Good Build: 63.0.3236.0 (Revision:507287) Bad Build: 63.0.3237.7 (Revision:507841) You are probably looking for a change made after 507638 (known good), but no later than 507639 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/edb9b8c351be1048294578fe1a2f97bad7fbcc1a..cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc Suspect: https://chromium.googlesource.com/chromium/src/+/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc @vasilii: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Above issue is not seen on Linux(14.04 LTS) and Win(7,8,10) OS. Thank You!
,
Oct 12 2017
Tagging with blocker label, please undo if not the case.
,
Oct 13 2017
Friendly ping for an update on this issue marked as Beta blocker.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0e8a53a83569be65979a3984895126b2d87aac1 commit b0e8a53a83569be65979a3984895126b2d87aac1 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Oct 13 13:44:16 2017 Fix the crash when the password bubble moves to the promo state on Mac. SavePendingPasswordViewController sets itself as a delegate to NSComboBox. When the save password bubble moves to the promo state, the controller is destroyed synchronously. The views in the bubble still exist for some time and the combobox may ping the delegate. Bug: 774033 Change-Id: I1131806e32aec7f038d94f1e58b72655092b73ed Reviewed-on: https://chromium-review.googlesource.com/718208 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#508691} [modify] https://crrev.com/b0e8a53a83569be65979a3984895126b2d87aac1/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm [modify] https://crrev.com/b0e8a53a83569be65979a3984895126b2d87aac1/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/b0e8a53a83569be65979a3984895126b2d87aac1/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
,
Oct 13 2017
Thanks for the quick turnaround. aiman.ansari@, please verify in next canary.
,
Oct 16 2017
,
Oct 16 2017
Rechecked this issue on Mac 10.12.6 using chrome version 64.0.3241.0 and fix is working as intended. No crash is observed after trying to save a long text from password bubble. Adding TE-verified label for M64.
,
Oct 16 2017
M63 beta promotion is coming VERY soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.
,
Oct 17 2017
This is exactly what I want to do and I'm blocked on your permission.
,
Oct 17 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c11e7281573aba648bd9d8c551e5cb96c760c411 commit c11e7281573aba648bd9d8c551e5cb96c760c411 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Oct 17 11:51:58 2017 Fix the crash when the password bubble moves to the promo state on Mac. SavePendingPasswordViewController sets itself as a delegate to NSComboBox. When the save password bubble moves to the promo state, the controller is destroyed synchronously. The views in the bubble still exist for some time and the combobox may ping the delegate. TBR=vasilii@chromium.org (cherry picked from commit b0e8a53a83569be65979a3984895126b2d87aac1) Bug: 774033 Change-Id: I1131806e32aec7f038d94f1e58b72655092b73ed Reviewed-on: https://chromium-review.googlesource.com/718208 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508691} Reviewed-on: https://chromium-review.googlesource.com/723021 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#27} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c11e7281573aba648bd9d8c551e5cb96c760c411/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm [modify] https://crrev.com/c11e7281573aba648bd9d8c551e5cb96c760c411/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm [modify] https://crrev.com/c11e7281573aba648bd9d8c551e5cb96c760c411/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
,
Oct 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 12 2017