New issue
Advanced search Search tips

Issue 774020 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::CSSPropertyAPI from __cxxabiv1::__function_type_info;blink::ParseKeywordValue;blink::CSSParserFastPaths::MaybeParseValue

Project Member Reported by ClusterFuzz, Oct 12 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5818845003776000

Fuzzer: libFuzzer_css_parser_fast_paths_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x000009fef3a0
Crash State:
  Bad-cast to blink::CSSPropertyAPI from __cxxabiv1::__function_type_info
  blink::ParseKeywordValue
  blink::CSSParserFastPaths::MaybeParseValue
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=508219:508241

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5818845003776000

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 12 2017

Components: Blink>CSS
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 12 2017

Labels: Test-Predator-AutoOwner
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/4491ba9d10af731964683f577822e7f29c339bf3 (Add fuzzing target for CSSParserFastPaths.cpp.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 12 2017

Labels: M-63
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 12 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 12 2017

Labels: Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5def70bc87542c1cc4922a48cfdae9894a79796a

commit 5def70bc87542c1cc4922a48cfdae9894a79796a
Author: Darren Shen <shend@chromium.org>
Date: Thu Oct 12 23:44:26 2017

Fix preconditions for css_parser_fast_paths_fuzzer.

There's a bug in generating the CSSPropertyID value from the hash of
the data string. We currently do (hash % numCSSPropertyIDs), which
can generate unresolved properties, which are not allowed in the
fuzz target. This patch tries to only generate valid (resolved)
CSSPropertyIDs.

Bug:  774113 ,  774060 ,  774020 ,  774015 
Change-Id: Iaa5655f7399cd0d1381197e7b4026d426b3cf456
Reviewed-on: https://chromium-review.googlesource.com/717276
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508543}
[modify] https://crrev.com/5def70bc87542c1cc4922a48cfdae9894a79796a/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsFuzzer.cpp

Project Member

Comment 7 by ClusterFuzz, Oct 13 2017

ClusterFuzz has detected this issue as fixed in range 508529:508564.

Detailed report: https://clusterfuzz.com/testcase?key=5818845003776000

Fuzzer: libFuzzer_css_parser_fast_paths_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x000009fef3a0
Crash State:
  Bad-cast to blink::CSSPropertyAPI from __cxxabiv1::__function_type_info
  blink::ParseKeywordValue
  blink::CSSParserFastPaths::MaybeParseValue
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=508219:508241
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=508529:508564

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5818845003776000

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5818845003776000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 13 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Both regressed and fixed in M63, removing ReleaseBlock-Stable
Labels: -ReleaseBlock-Stable
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 19 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-63 M-65 Security_Impact-Stable

Sign in to add a comment