New issue
Advanced search Search tips

Issue 774012 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Clicking on the Key displayed in the Omni box, asks the user to save password again after logging into the website.

Project Member Reported by pnangunoori@chromium.org, Oct 12 2017

Issue description

Chrome Version: 63.0.3237.7
OS: Windows 10, Mac 10.12.6 and Ubuntu 14.04

What steps will reproduce the problem?
1. Navigate to facebook login page.
2. Login to the website.
3. Save the Password.
4. Logout of the logged in user in facebook.
5. Login with the saved credentials.
6. Click on the Key displayed in the Omnibox.

What is the expected result?
"Save" button should not be displayed.

What happens instead?
"Save" button is still seen to the user.

 
SavePasswordRepeatedlyAsked.mov
12.3 MB Download

Comment 1 by kolos@chromium.org, Oct 12 2017

Components: UI>Browser>Passwords
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf

commit 64aae3069d6fe3c7227f5fae82a8e8c68e9359cf
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Oct 12 19:46:16 2017

[Password Manager] Don't show the fallback for saving if the credential is already saved

Bug:  725883 ,  767861 ,  774012 
Change-Id: I64b4729a1db3c450fc532403bb9764e2e8adcbb4
Reviewed-on: https://chromium-review.googlesource.com/714176
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508387}
[modify] https://crrev.com/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/64aae3069d6fe3c7227f5fae82a8e8c68e9359cf/components/password_manager/core/browser/password_manager_unittest.cc

Comment 3 by kolos@chromium.org, Oct 13 2017

Status: Fixed (was: Started)

Sign in to add a comment