New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773993 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update UMA histogram enum requirements in /media presubmit.

Project Member Reported by olka@chromium.org, Oct 12 2017

Issue description

The current presubmit requirements are [https://cs.chromium.org/chromium/src/media/PRESUBMIT.py?type=cs&sq=package:chromium&l=142]:
'UMA_HISTOGRAM_ENUMERATION reports in src/media/ are expected to adhere\n'
      'to the following guidelines:\n'
      ' - The max value (3rd argument) should be an enum value equal to the\n'
      '   last valid value, e.g. FOO_MAX = LAST_VALID_FOO.\n'
      ' - 1 must be added to that max value.\n'

Wheres UMA documentation recommends using COUNT value as the last value of the enum: "The COUNT value should not include an explicit value--this lets the compiler keep the COUNT up-to-date." [https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md]

This leads to confusion both when submitting the code and during code reviews.
 

Comment 1 by olka@chromium.org, Oct 12 2017

Description: Show this description
Cc: xhw...@chromium.org
Components: Internals>Media
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dbbrooks@chromium.org, Today (19 hours ago)

Owner: dalecur...@chromium.org
Status: Available (was: Untriaged)
Dale, perhaps we can close this as "Won't Fix" considering its age?

Comment 6 by dalecur...@chromium.org, Today (17 hours ago)

Status: WontFix (was: Available)
Everyone should be using UMA_HISTOGRAM_ENUMERATION() and this syntax Chromium wide now: https://cs.chromium.org/chromium/src/base/metrics/histogram_macros.h?l=39 so WontFix

Sign in to add a comment