Update UMA histogram enum requirements in /media presubmit. |
||||||
Issue descriptionThe current presubmit requirements are [https://cs.chromium.org/chromium/src/media/PRESUBMIT.py?type=cs&sq=package:chromium&l=142]: 'UMA_HISTOGRAM_ENUMERATION reports in src/media/ are expected to adhere\n' 'to the following guidelines:\n' ' - The max value (3rd argument) should be an enum value equal to the\n' ' last valid value, e.g. FOO_MAX = LAST_VALID_FOO.\n' ' - 1 must be added to that max value.\n' Wheres UMA documentation recommends using COUNT value as the last value of the enum: "The COUNT value should not include an explicit value--this lets the compiler keep the COUNT up-to-date." [https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md] This leads to confusion both when submitting the code and during code reviews.
,
Oct 12 2017
,
Oct 18 2017
,
Oct 18
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Today
(19 hours ago)
Dale, perhaps we can close this as "Won't Fix" considering its age?
,
Today
(17 hours ago)
Everyone should be using UMA_HISTOGRAM_ENUMERATION() and this syntax Chromium wide now: https://cs.chromium.org/chromium/src/base/metrics/histogram_macros.h?l=39 so WontFix |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by olka@chromium.org
, Oct 12 2017