New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773992 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 773977
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CrExtensionsErrorPageTest.Layout and CrExtensionsShortcutTest.Basic failures

Project Member Reported by fhorschig@chromium.org, Oct 12 2017

Issue description

Suspectecting https://crrev.com/c/711095 which touched MD Extensions.
Cc: dschuyler@chromium.org
Components: UI>Browser>ExtensionsManagement
Labels: -Sheriff-Chromium Type-Bug-Regression
Owner: dpa...@chromium.org
Revert is in progress with https://crrev.com/c/711095, assigning bug to owners and removing it from Sheriff list.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d04c934260e5762ebbe19939aa2dd46e7dda7aec

commit d04c934260e5762ebbe19939aa2dd46e7dda7aec
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Oct 12 07:33:13 2017

Revert "MD Extensions: Improve perceived speed of page load/refresh."

This reverts commit 988655c32149893423e683430cdc8c271381c3da.

Reason for revert: Consistent CrExtensionsErrorPageTest.Layout and CrExtensionsShortcutTest.Basic failures starting with https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/67359

Original change's description:
> MD Extensions: Improve perceived speed of page load/refresh.
> 
>  - Pushing pixels on the screen faster by moving all <link> tags outside
>    of <head>.
>  - Faking the page layout (toolbar + background) until Polymer elements are
>    loaded.
> 
> This is the same trick used in other WebUI pages, and completely eliminates the
> white flash currently seen when refreshing/loading the page.
> 
> Bug:  764126 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Icc12935f10c8a9f3dda5eeab73ca5d91c06804c0
> Reviewed-on: https://chromium-review.googlesource.com/711095
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508250}

TBR=dbeam@chromium.org,dpapad@chromium.org,dschuyler@chromium.org

Change-Id: I8facb8d911d345a3a44ebd3422581dbe5d530586
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  764126 ,  773992 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/715456
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508274}

Mergedinto: 773977
Status: Duplicate (was: Started)

Sign in to add a comment