Check-select mode cancelled while multiple files selected, when another window modifies files |
|||||||
Issue descriptionChrome Version: 63.0.3239.0 Steps To Reproduce: (1) Open a directory containing 2+ files (2) Open a new window (see the same directory is opened in it) (3) Select all files in one of the window (A). See it the toolbar turns white. (multi-select mode) (4) Pick one file in another window (B) (5) Ctrl+C, then Ctrl+V. (or make any change) Expected Result: File selection in window A is retained. It is still in check-select mode. Actual Result: File selection in window A is retained, but it exists check-select mode. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) 100% What is the impact to the user, and is there a workaround? If so, what is it? This may be confusing for users because the next command will still take effect to the selected files, despite those selected files are not appearing "checked".
,
Feb 23 2018
,
Feb 28 2018
,
Apr 5 2018
,
Nov 22
,
Nov 22
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06044295da62f4caf5196b73caef1e55b2ca4884 commit 06044295da62f4caf5196b73caef1e55b2ca4884 Author: Sam McNally <sammc@chromium.org> Date: Thu Nov 22 08:45:59 2018 Re-enter check select mode after directory contents is replaced. When the directory contents is replaced, the selection is informed, and thus it clears check select mode. Once the new contents is swapped in, the check select state is lost. If check select mode was enabled and there was a selection, re-enable check select mode once the directory contents replacement is complete. Bug: 773989 Change-Id: I5859ece283dd10aca03310389174726fd18110e2 Reviewed-on: https://chromium-review.googlesource.com/c/1347964 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610351} [modify] https://crrev.com/06044295da62f4caf5196b73caef1e55b2ca4884/ui/file_manager/file_manager/foreground/js/directory_model.js
,
Nov 22
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yamaguchi@chromium.org
, Oct 12 2017FileListSelectionModel.prototype.adjustToReordering in window A received permutation list like {-1, -1, -1, ..., -1}. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/file_list_selection_model.js?type=cs&q=file:file_manager+permut&sq=package:chromium&l=44