Issue metadata
Sign in to add a comment
|
Regression:While taking photo, the photo captured blinks twice in settings/changePicture page |
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3236.0/10024.0.0 dev-channel Candy,Peppy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user ->Launch chrome,open chrome://settings/changePicture and click to take photo in Camera mode and Observe the capturing process(Kindly refer video) Actual:while taking photo, the photo captured blinks twice Expected:Instead,no such weird blinks should be seen This is a Regression issue as same is working fine in 63.0.3223.0/9978.0.0 dev Note: Issue is not seen in Linux,Windows OS @Stevenjb: please confirm the issue.
,
Oct 27 2017
Any updates?
,
Oct 29 2017
I've uploaded a change that should fix this issue and make photo taking animations more seamless in general: https://chromium-review.googlesource.com/c/chromium/src/+/742801
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e commit 111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e Author: David Reveman <reveman@chromium.org> Date: Mon Oct 30 20:39:12 2017 Change Picture: Improve photo taking animations. This improves the flash animation for photo taking by removing the use of a mask-image in favor of a border that can be animated and doesn't conflict with flash animations. This makes the removal of the circular frame used for preview less jarring. It also adjusts the delay of animations and defers image processing so that flash animations have a chance to finish running. Single photo mode uses white color ease-in animation, while video mode uses a less intense flash with 0.67 opacity. Last, it uses the first frame of PNGs as placeholder while larger animated PNGs are loading from object URLs. This prevents the loading from appearing as a flash. Bug: 773987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibd1a2ec06984a38df685d6f5e29963debcc91190 Reviewed-on: https://chromium-review.googlesource.com/742801 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512612} [modify] https://crrev.com/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e/ui/webui/resources/cr_elements/chromeos/cr_picture/compiled_resources2.gyp [modify] https://crrev.com/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html [modify] https://crrev.com/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js [modify] https://crrev.com/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Oct 30 2017
,
Oct 31 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 3 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24604ab732656cfe38faaa322107265cb83efa80 commit 24604ab732656cfe38faaa322107265cb83efa80 Author: David Reveman <reveman@chromium.org> Date: Fri Nov 03 05:09:02 2017 Change Picture: Improve photo taking animations. This improves the flash animation for photo taking by removing the use of a mask-image in favor of a border that can be animated and doesn't conflict with flash animations. This makes the removal of the circular frame used for preview less jarring. It also adjusts the delay of animations and defers image processing so that flash animations have a chance to finish running. Single photo mode uses white color ease-in animation, while video mode uses a less intense flash with 0.67 opacity. Last, it uses the first frame of PNGs as placeholder while larger animated PNGs are loading from object URLs. This prevents the loading from appearing as a flash. TBR=reveman@chromium.org (cherry picked from commit 111a20da92e6c9ad2bab07763d4cc5d3b4fd2c9e) Bug: 773987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibd1a2ec06984a38df685d6f5e29963debcc91190 Reviewed-on: https://chromium-review.googlesource.com/742801 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512612} Reviewed-on: https://chromium-review.googlesource.com/753021 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#361} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/24604ab732656cfe38faaa322107265cb83efa80/ui/webui/resources/cr_elements/chromeos/cr_picture/compiled_resources2.gyp [modify] https://crrev.com/24604ab732656cfe38faaa322107265cb83efa80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html [modify] https://crrev.com/24604ab732656cfe38faaa322107265cb83efa80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js [modify] https://crrev.com/24604ab732656cfe38faaa322107265cb83efa80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/24604ab732656cfe38faaa322107265cb83efa80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Nov 10 2017
Verified on M64 dev build (10115.0.0, 64.0.3264.0). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 12 2017