Issue metadata
Sign in to add a comment
|
Regression:Unable to capture video in chrome://settings/changePicture overlay |
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3236.0/10024.0.0 dev-channel Candy,Peppy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user ->Launch chrome,open chrome://settings/changePicture and click to take photo in video mode and Observe(Kindly refer video) Actual: Unable to capture video Expected:Should be able to capture video This is a Regression issue as same is working fine in 63.0.3230.0/9997.0.0 dev Note: Issue is not seen in Linux,Windows OS @Stevenjb: please confirm the issue.
,
Oct 17 2017
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d51655900c04b0eb3b9e9df085995ab1253c6409 commit d51655900c04b0eb3b9e9df085995ab1253c6409 Author: David Reveman <reveman@chromium.org> Date: Thu Oct 19 19:58:37 2017 Change Picture: Avoid using huge data URLs. Capture was failing because data URLs are sometimes too long. This avoids the use of GURLs with this limitation and creates object URLs for PNG images to ensure that they are displayed correctly. Bug: 773981 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9dd19aa346874a690f1fab2965baec69c9f6f3c2 Reviewed-on: https://chromium-review.googlesource.com/724526 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510168} [modify] https://crrev.com/d51655900c04b0eb3b9e9df085995ab1253c6409/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/d51655900c04b0eb3b9e9df085995ab1253c6409/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc [modify] https://crrev.com/d51655900c04b0eb3b9e9df085995ab1253c6409/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/d51655900c04b0eb3b9e9df085995ab1253c6409/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js
,
Oct 19 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f30e05f33c97c8d587f487c229b1bae39b27cfc9 commit f30e05f33c97c8d587f487c229b1bae39b27cfc9 Author: David Reveman <reveman@chromium.org> Date: Fri Oct 20 22:06:14 2017 Change Picture: Avoid using huge data URLs. Capture was failing because data URLs are sometimes too long. This avoids the use of GURLs with this limitation and creates object URLs for PNG images to ensure that they are displayed correctly. TBR=reveman@chromium.org (cherry picked from commit d51655900c04b0eb3b9e9df085995ab1253c6409) Bug: 773981 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9dd19aa346874a690f1fab2965baec69c9f6f3c2 Reviewed-on: https://chromium-review.googlesource.com/724526 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510168} Reviewed-on: https://chromium-review.googlesource.com/731615 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#122} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/f30e05f33c97c8d587f487c229b1bae39b27cfc9/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/f30e05f33c97c8d587f487c229b1bae39b27cfc9/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc [modify] https://crrev.com/f30e05f33c97c8d587f487c229b1bae39b27cfc9/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html [modify] https://crrev.com/f30e05f33c97c8d587f487c229b1bae39b27cfc9/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Oct 12 2017Owner: reve...@chromium.org