Bookmark star background doesn't get "lit" when pressing Ctrl+d - only when clicking |
||||
Issue descriptionChrome Version : 63.0.3218.0 It lights up on Mac with Cmd+d, but not on other platforms. It should light up, same as if it was clicked. See http://crbug.com/726187#c29
,
Dec 13 2017
,
Dec 13 2017
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ef3d9ac3f782e0a024704b8b9adf19e2643f70f commit 2ef3d9ac3f782e0a024704b8b9adf19e2643f70f Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Dec 15 14:24:26 2017 Force the star icon to highlight when using the keyboard shortcut for adding a bookmark. Bug: 773979 Change-Id: I1a2bc9a86e898c3a91fcdfdc97296972dbdff723 Reviewed-on: https://chromium-review.googlesource.com/825627 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524376} [modify] https://crrev.com/2ef3d9ac3f782e0a024704b8b9adf19e2643f70f/chrome/browser/ui/views/location_bar/star_view.cc [modify] https://crrev.com/2ef3d9ac3f782e0a024704b8b9adf19e2643f70f/chrome/browser/ui/views/location_bar/star_view.h [modify] https://crrev.com/2ef3d9ac3f782e0a024704b8b9adf19e2643f70f/chrome/browser/ui/views/location_bar/star_view_browsertest.cc [modify] https://crrev.com/2ef3d9ac3f782e0a024704b8b9adf19e2643f70f/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
Dec 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Oct 13 2017