New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: ----



Sign in to add a comment

CrExtensionsErrorPageTest.Layout CrExtensionsShortcutTest.Basic failures

Project Member Reported by keishi@chromium.org, Oct 12 2017

Issue description

Comment 1 by keishi@chromium.org, Oct 12 2017

Summary: CrExtensionsErrorPageTest.Layout CrExtensionsShortcutTest.Basic failures (was: Repeated HostedAppTest.CtrlClickLink failures on Mac Tests)
Cc: dpa...@chromium.org dschuyler@chromium.org
 Issue 773992  has been merged into this issue.
Cc: -dpa...@chromium.org
Components: UI>Browser>ExtensionsManagement
Labels: -Sheriff-Chromium OS-Linux Pri-1
Owner: dpa...@chromium.org
Status: Assigned (was: Available)

Comment 5 by dpa...@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)
So, it seems that the CQ does not run any tests in Debug mode. Which explains how my CL passed CQ but had to be reverted later. Either way, the CL has been reverted and there is nothing to do here. I'll roll forward making sure the tests are passing.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a2e568b06de2e2b63db8fc8e2731cc5519e032

commit 92a2e568b06de2e2b63db8fc8e2731cc5519e032
Author: dpapad <dpapad@chromium.org>
Date: Fri Oct 13 21:25:13 2017

MD Extensions: Fix tests that are causing problems in debug mode.

Bug:  764126 , 773977 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic18b4c1315812bbf38d45b77b091710814f113c0
Reviewed-on: https://chromium-review.googlesource.com/717539
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508824}
[modify] https://crrev.com/92a2e568b06de2e2b63db8fc8e2731cc5519e032/chrome/browser/resources/md_extensions/shortcut_input.html
[modify] https://crrev.com/92a2e568b06de2e2b63db8fc8e2731cc5519e032/chrome/test/data/webui/extensions/cr_extensions_browsertest.js

Sign in to add a comment