New issue
Advanced search Search tips

Issue 773974 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Files app: Remove unused code.

Project Member Reported by fukino@chromium.org, Oct 12 2017

Issue description

This is a tracking bug for the work to remove unused code from Files app (in both JavaScripts and C++ code).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd2c109f0cfefdf622903d4e264ed45890fa92e

commit 8bd2c109f0cfefdf622903d4e264ed45890fa92e
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri Oct 13 07:34:42 2017

Files app: Remove unused selectors about tree items.

In https://chromiumcodereview.appspot.com/12857002, we replaced <list> with
<tree> element for the directory tree.
Now that tree items in <tree> do not have 'anchor' or 'lead' attribute, we can
remove selectors for them.

Bug:  773974 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I95e0aefb084477fd56c8d04ddf3fa3c32b6236f5
Reviewed-on: https://chromium-review.googlesource.com/714940
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508638}
[modify] https://crrev.com/8bd2c109f0cfefdf622903d4e264ed45890fa92e/ui/file_manager/file_manager/foreground/css/file_manager.css

Comment 2 by sashab@chromium.org, Feb 23 2018

Labels: CrOS-FilesApp-CodeHealth
Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-CodeHealth CrOSFilesCategory-CodeHealth

Comment 5 by loyso@chromium.org, Mar 15 2018

Labels: -Type-Bug Type-Task
Status: Available (was: Unconfirmed)
Status: WontFix (was: Available)
Will close in favour of individual bugs as needs be.

Sign in to add a comment