The current situation: the change https://chromium-review.googlesource.com/c/chromium/src/+/697485 was committed once but reverted since this introduced flakiness on Windows ( crbug.com/771729 ). I think this can be fixed by making the test more deterministic. Another reported problem is that this caused performance drop ( crbug.com/772145 )
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b8485c6d66e754d5fd729d636e5d1c50a261e21 commit 1b8485c6d66e754d5fd729d636e5d1c50a261e21 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Oct 17 09:52:33 2017 Revert "Revert "Add RendererSchedulerImpl::V8TaskQueue()"" This reverts commit da95168e109c81c024d6edb25062af0a6fe2e7cd. Reason for revert: The test failure was already fixed at crbug.com/771729 Bug: 773970 Original change's description: > Revert "Add RendererSchedulerImpl::V8TaskQueue()" > > This reverts commit f6af34a1a523e06a8ef371f21469050795924eb5. > > Reason for revert: Speculative revert for layout test flake starting at https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11385 - will reland if the flake does not disappear > > Original change's description: > > Add RendererSchedulerImpl::V8TaskQueue() > > > > V8 tasks like GC are now posted to a loading task queue. This CL introduces > > V8 task queue at RendererSchedulerImpl and uses it for V8 tasks for better > > scheduling. > > > > Bug: n/a > > Change-Id: If65ad1b12e59de36a448dddc0da0777d2338b58a > > Reviewed-on: https://chromium-review.googlesource.com/697485 > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#506364} > > TBR=isherman@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: n/a > Change-Id: I353c558a1a637fcf70da20e537be4e218a993af9 > Reviewed-on: https://chromium-review.googlesource.com/705135 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507199} TBR=isherman@chromium.org,rockot@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: n/a Change-Id: I2555e1297d430de4f193a5d478a515a74078cc84 Reviewed-on: https://chromium-review.googlesource.com/722401 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509339} [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc [modify] https://crrev.com/1b8485c6d66e754d5fd729d636e5d1c50a261e21/tools/metrics/histograms/enums.xml
Comment 1 by hajimehoshi@chromium.org
, Oct 12 2017