Issue metadata
Sign in to add a comment
|
Regression: Unnecessary drop down box is seen for password field in save password bubble
Reported by
nutan.ga...@etouch.net,
Oct 12 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3237.7 8c1a645bff123782500285f1e44850320da52536-refs/branch-heads/3237@{#8} OS: Mac(10.12.6) What steps will reproduce the problem? 1. Launch chrome, navigate to www.gmail.com and login with valid credential 2. Observe the save password bubble Actual: Unnecessary drop down box is seen for password field Expected: Drop down box should not be seen for password field This is a regression issue, broken in 'M-63', will soon update the other info: Good Build: 63.0.3236.0 Bad Build: 63.0.3237.7 Note: Issue is not reproducible on Windows and Linux OS
,
Oct 12 2017
You are probably looking for a change made after 507638 (known good), but no later than 507639 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/edb9b8c351be1048294578fe1a2f97bad7fbcc1a..cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc Suspect: https://chromium.googlesource.com/chromium/src/+/cb22bad2eb6379beb3c9c2ca0ac2aec7eed63dcc
,
Oct 12 2017
Tagging with blocker label, please undo if not the case.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3107632464a2d623fa58c2476ab324ef2be71bd commit f3107632464a2d623fa58c2476ab324ef2be71bd Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Oct 12 19:50:00 2017 Show an editable field instead of combobox in the password bubble on Mac. Bug: 773966 Change-Id: I01f1dbd473670e0c82e0934e13162836dfd6ed7a Reviewed-on: https://chromium-review.googlesource.com/716481 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#508392} [modify] https://crrev.com/f3107632464a2d623fa58c2476ab324ef2be71bd/chrome/browser/ui/cocoa/passwords/password_item_views.h [modify] https://crrev.com/f3107632464a2d623fa58c2476ab324ef2be71bd/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm [modify] https://crrev.com/f3107632464a2d623fa58c2476ab324ef2be71bd/chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.mm [modify] https://crrev.com/f3107632464a2d623fa58c2476ab324ef2be71bd/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm
,
Oct 13 2017
Could you please file a merge request once this is landed on Canary? Thanks.
,
Oct 13 2017
I landed it before the branch point as I imagine.
,
Oct 13 2017
Retested the above issue on latest Canary #63.0.3239.0 on Mac(10.12.6) and fix is working as intended. Kindly refer the attached video
,
Oct 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nutan.ga...@etouch.net
, Oct 12 20174.5 MB
4.5 MB Download
3.2 MB
3.2 MB Download