New issue
Advanced search Search tips

Issue 773956 link

Starred by 1 user
Status: Fixed
Owner:
kouhei@chromium.org
Closed: Oct 2017
Cc:
yhirano@chromium.org
kinuko@chromium.org
kouhei@chromium.org
neis@chromium.org
hirosh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Invalid web platform test was upstreamed: instantiation-error-8.html

Project Member Reported by domenic@chromium.org, Oct 12 2017 
https://github.com/w3c/web-platform-tests/commit/ea1e3f95b5e84aa55bb0a1d2277731db2dc4abf6 contains an invalid test that assumes all implementations will use the same error messages as Chrome.

We should replace the lines that test the error message with something like

assert_equals(e.error.constructor, SyntaxError);

Assigning to kouhei as CL author and CCing reviewers
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060c0f10d2b026503461b40793a9465f616bd899

commit 060c0f10d2b026503461b40793a9465f616bd899
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Oct 12 07:33:00 2017

WPT: Check for error type rather than message which can be different across browsers

Bug:  773956 
Change-Id: Ia54ad4954c3d4b0effc678ebec10ba03cf499eab
Reviewed-on: https://chromium-review.googlesource.com/715078
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508273}
[modify] https://crrev.com/060c0f10d2b026503461b40793a9465f616bd899/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-8.html

Comment 2 by domenic@chromium.org, Oct 12 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment