gclient: do not write out gclient_gn_args_file until you've checked out the dependencies |
||
Issue descriptionSee bug 773185 for context ... currently, gclient will attempt to write out the args file for a dependency once it's been checked out, but before any sub-dependencies have been processed However, depending on the path, the args file might actually point to something inside a sub-dependencies, and so the directory won't exist. We should wait until after we've checked out all of the dependencies to write out the args file.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9f20d020855c8ee87ba64d53ef94051c06aab860 commit 9f20d020855c8ee87ba64d53ef94051c06aab860 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Oct 12 21:18:24 2017 Do not write gclient_gn_args_file too early. Previously, gclient would attempt to write an args file after a dependency was checked out, but before any sub-dependencies had been checked out. If the args file path pointed at something inside a sub-dependency, this wouldn't work, because the directory might not yet exist. This most obviously happened for buildspec clobber builds. The fix is to wait until after the sub-dependencies have been checked out to write the file. R=phajdan.jr@chromium.org, mmoss@chromium.org BUG= 773933 Change-Id: I0cf4564204f7dabd9f843dc7904db7050fcc0d23 Reviewed-on: https://chromium-review.googlesource.com/714644 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/9f20d020855c8ee87ba64d53ef94051c06aab860/testing_support/fake_repos.py [modify] https://crrev.com/9f20d020855c8ee87ba64d53ef94051c06aab860/gclient.py [modify] https://crrev.com/9f20d020855c8ee87ba64d53ef94051c06aab860/tests/gclient_smoketest.py
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b035c366091bbad4a84cf6d02892959e07cfd65a commit b035c366091bbad4a84cf6d02892959e07cfd65a Author: depot-tools-roller@chromium.org <depot-tools-roller@chromium.org> Date: Thu Oct 12 23:32:48 2017 Roll src/third_party/depot_tools/ d08043c72..9f20d0208 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d08043c72c79..9f20d020855c $ git log d08043c72..9f20d0208 --date=short --no-merges --format='%ad %ae %s' 2017-10-11 dpranke Do not write gclient_gn_args_file too early. Created with: roll-dep src/third_party/depot_tools BUG= 773933 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: I11fda894941e4461744d8c56eeae2bd6a82dec47 Reviewed-on: https://chromium-review.googlesource.com/716851 Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#508537} [modify] https://crrev.com/b035c366091bbad4a84cf6d02892959e07cfd65a/DEPS
,
Oct 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by phajdan.jr@chromium.org
, Oct 12 2017