New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773928 link

Starred by 10 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

[Print Preview]: Componetize UI codebase

Project Member Reported by dpa...@chromium.org, Oct 12 2017

Issue description

The overall goal is to modernize the UI codbase of PP by leveraging Web Components (with Polymer), while keeping the UI looking the same initially. This will enable us to later perform a UI refresh with less work, compared to trying to do it all at once (Componetize+UI refresh).

Some initial scaffolding work needs to be done to kick-start this effort.

1) Add a enable-new-print-preview runtime flag

2) Decide exactly where the new PP code will leave, and how it can leverage existing JS files
   Proposal: chrome/browser/resources/print_preview/new/

Putting the code under the existing folder will allow for easier re-using files as necessary from the existing PP UI.

3) Hook up the flag to trigger print preview with a dummy empty page for now.
 
Showing comments 18 - 117 of 117 Older
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378994c226ee9eaa4436eaa1faf17dadff3e1adf

commit 378994c226ee9eaa4436eaa1faf17dadff3e1adf
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Nov 28 22:47:38 2017

Print Preview componentization: change model

- Change model to be a Polymer UI element
- Leverage existing classes to store data
- Add behavior for setting/getting settings values

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I30b5aa71363c0bc2820670e8a9f3fb77b5975477
Reviewed-on: https://chromium-review.googlesource.com/783692
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519877}
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/coordinate2d.html
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/destination.html
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/document_info.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/document_info.js
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/printable_area.html
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/data/size.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/header.js
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/scaling_settings.js
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/settings_behavior.html
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/print_preview_resources.grd
[add] https://crrev.com/378994c226ee9eaa4436eaa1faf17dadff3e1adf/chrome/browser/resources/print_preview/print_preview_utils.html

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c540311a725da14f911fe1ffa88973ea583881

commit b9c540311a725da14f911fe1ffa88973ea583881
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Nov 30 18:25:49 2017

Print Preview Componentization: Add dependencies for sections hiding

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55754b306707a8f4a7b32c30c5596263925359a9
Reviewed-on: https://chromium-review.googlesource.com/794433
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520612}
[modify] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/test/data/webui/print_preview/.eslintrc.js
[add] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/b9c540311a725da14f911fe1ffa88973ea583881/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b47ce9e77e47653a1b61db4e171f3d4516c0fa80

commit b47ce9e77e47653a1b61db4e171f3d4516c0fa80
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 01 02:43:04 2017

Print Preview Componentization: Add tests for more sections

Bug: 773928, 789408
Change-Id: I66009509ad601756ec0281a66fd093ee7fc96477
Reviewed-on: https://chromium-review.googlesource.com/802175
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520815}
[modify] https://crrev.com/b47ce9e77e47653a1b61db4e171f3d4516c0fa80/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/b47ce9e77e47653a1b61db4e171f3d4516c0fa80/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567580e2510a87c28ef3e49c8b66ca9305b7f4b2

commit 567580e2510a87c28ef3e49c8b66ca9305b7f4b2
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 01 19:23:09 2017

Print Preview Componentization: Correctly update other options

Also add a test to verify, and only show rasterize checkbox on non-
Windows/Mac.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I430f138db14cbe2e456023ba93292ddbd5c49dbe
Reviewed-on: https://chromium-review.googlesource.com/802356
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521011}
[modify] https://crrev.com/567580e2510a87c28ef3e49c8b66ca9305b7f4b2/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/567580e2510a87c28ef3e49c8b66ca9305b7f4b2/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/567580e2510a87c28ef3e49c8b66ca9305b7f4b2/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/567580e2510a87c28ef3e49c8b66ca9305b7f4b2/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/567580e2510a87c28ef3e49c8b66ca9305b7f4b2/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3bb35d1424dbe1c15ae875d5418b69cac35536

commit 2c3bb35d1424dbe1c15ae875d5418b69cac35536
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Dec 05 22:49:15 2017

Print Preview componentization: incorporate native layer

Make test and existing code changes as needed to incorporate native
layer into the new UI. No behavior changes.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I660a4707a2a54d75e5ca7dde2b9ec10496c5055b
Reviewed-on: https://chromium-review.googlesource.com/807585
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521874}
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/compiled_resources2.gyp
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/data/compiled_resources2.gyp
[add] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/native_layer.html
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/2c3bb35d1424dbe1c15ae875d5418b69cac35536/chrome/test/data/webui/print_preview/print_preview_tests.js

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b75aba542778b09fe6621fd29f9bc84fdaf15093

commit b75aba542778b09fe6621fd29f9bc84fdaf15093
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Dec 07 22:23:23 2017

Print Preview: Remove destination store dependency on app state

The new UI needs the destination store, but not app state. Remove the
dependency to simplify integration of destination store in new UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I11ae62cae42929b2131b610c09e893fa4638eff2
Reviewed-on: https://chromium-review.googlesource.com/810208
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522575}
[modify] https://crrev.com/b75aba542778b09fe6621fd29f9bc84fdaf15093/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/b75aba542778b09fe6621fd29f9bc84fdaf15093/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/b75aba542778b09fe6621fd29f9bc84fdaf15093/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/b75aba542778b09fe6621fd29f9bc84fdaf15093/chrome/browser/resources/print_preview/search/destination_search.js
[modify] https://crrev.com/b75aba542778b09fe6621fd29f9bc84fdaf15093/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c631d67cec0b21f2ebcdd2038b34048b33222da

commit 8c631d67cec0b21f2ebcdd2038b34048b33222da
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Dec 09 14:16:53 2017

Print Preview Componentization: Update select settings

Add settings select element that correctly updates drop downs with
options based on printer capabilities.

Note: unlike in current UI, sets the default selected option to the
destination's default value for that option when the destination
changes, instead of looking for an exact match to the previously
selected value (see PS4 -> PS5 change).

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8f559f9cc0632e2a43d1ab455099fadc23294022
Reviewed-on: https://chromium-review.googlesource.com/815291
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522985}
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/dpi_settings.js
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/media_size_settings.html
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/media_size_settings.js
[add] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/settings_select.html
[add] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/new/settings_select.js
[modify] https://crrev.com/8c631d67cec0b21f2ebcdd2038b34048b33222da/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 25 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b20220988a5591de0f04bd896a604af4c0e30cc4

commit b20220988a5591de0f04bd896a604af4c0e30cc4
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Dec 12 05:10:38 2017

Print Preview componentization: use initial settings

Use initial settings to populate some fields.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I817c34fabf416b7a935633bdc1830d3e69fc4086
Reviewed-on: https://chromium-review.googlesource.com/809708
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523340}
[add] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/data/measurement_system.html
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/b20220988a5591de0f04bd896a604af4c0e30cc4/chrome/test/data/webui/print_preview/restore_state_test.js

Project Member

Comment 26 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bc0d6eb583fb67cc550d0834aae5eaac2588123

commit 7bc0d6eb583fb67cc550d0834aae5eaac2588123
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Dec 13 22:22:40 2017

Print Preview Componentization: Add destination store

Add destination store to the new UI, adding resources and changing tests
as need. No behavior changes yet.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib984fbcc3988d1f20219630ed01e1a941982eec7
Reviewed-on: https://chromium-review.googlesource.com/822597
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523908}
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/cloud_print_interface.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/compiled_resources2.gyp
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/compiled_resources2.gyp
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/destination.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/destination_match.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/destination_store.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/document_info.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/local_parsers.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/margins.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/measurement_system.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/data/user_info.html
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/metrics.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/native_layer.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/model.js
[add] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/new/state.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/resources/print_preview/print_preview_utils.html
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/7bc0d6eb583fb67cc550d0834aae5eaac2588123/ui/webui/resources/webui_resources.grd

Project Member

Comment 27 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c1909e01a902b15ab2973aa24f2afd6519d129

commit b0c1909e01a902b15ab2973aa24f2afd6519d129
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 15 21:49:02 2017

Print Preview Componentization: Use destination updates

Listen for destination events and update UI when destination changes.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1c9aff4f5e6fd1d856727064ab76058c30b12125
Reviewed-on: https://chromium-review.googlesource.com/823579
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524473}
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/browser/resources/print_preview/new/settings_section.html
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/b0c1909e01a902b15ab2973aa24f2afd6519d129/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 28 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96afa336c222db4a80ac3bc219612b320437a27

commit d96afa336c222db4a80ac3bc219612b320437a27
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Dec 20 19:20:22 2017

Print Preview: Refactor color

Refactor color settings logic out of the color ticket item and into
destination so that it can be used by the new UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f768d094ed45b592af9d19362ca098349376cc6
Reviewed-on: https://chromium-review.googlesource.com/835479
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525401}
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/data/print_ticket_store.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/data/ticket_items/color.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/preview_generator.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/d96afa336c222db4a80ac3bc219612b320437a27/chrome/test/data/webui/print_preview/print_preview_tests.js

Project Member

Comment 29 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c

commit 9a46c7e6f9033a14ff62d7c4fada6d216271cf5c
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Dec 20 21:03:02 2017

Print Preview Componentization: Update color, collate & layout from UI

Update color, collate and layout values in model from UI changes. Also
add tests to validate updates.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac3e5eeba2009ce895080e8a80c745ca44bcdd48
Reviewed-on: https://chromium-review.googlesource.com/835414
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525450}
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/color_settings.js
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/browser/resources/print_preview/new/layout_settings.js
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/9a46c7e6f9033a14ff62d7c4fada6d216271cf5c/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 30 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9b2a47bec348da9be078448df997977f650ca8

commit 7e9b2a47bec348da9be078448df997977f650ca8
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 22 01:49:45 2017

Print Preview Componentization: Update model for dpi, margins, media

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9db43dade6904ca444af74dc2a78d23af0d7fd32
Reviewed-on: https://chromium-review.googlesource.com/838188
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525891}
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/dpi_settings.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/margins_settings.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/media_size_settings.html
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/media_size_settings.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/settings_select.html
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/browser/resources/print_preview/new/settings_select.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/7e9b2a47bec348da9be078448df997977f650ca8/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 31 by bugdroid1@chromium.org, Dec 23 2017

Project Member

Comment 32 by bugdroid1@chromium.org, Jan 8 2018

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f98082cdfa0d6635f604845bb0a931f1df7885a8

commit f98082cdfa0d6635f604845bb0a931f1df7885a8
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jan 09 01:34:01 2018

Print Preview Componentization: Remove updatePreview field

This field was not useful.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4bbaa07577e2e11014c85ac9f7f8dce9e2901981
Reviewed-on: https://chromium-review.googlesource.com/855179
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527857}
[modify] https://crrev.com/f98082cdfa0d6635f604845bb0a931f1df7885a8/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/f98082cdfa0d6635f604845bb0a931f1df7885a8/chrome/browser/resources/print_preview/new/settings_behavior.js

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/776de246b0c79e64d367e09f5d7e9314a4679d70

commit 776de246b0c79e64d367e09f5d7e9314a4679d70
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 10 18:52:32 2018

Print Preview Componentization: Add tests and update pages

Print ticket expects the pages to be sent in the format of an array
with from and to fields in each element, or a null pointer/empty array
if the full range is to be printed. Change pages value to this format
and add a test.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5087d958e2cb5f60789053d7f152d5dfbe5b6617
Reviewed-on: https://chromium-review.googlesource.com/855506
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528370}
[modify] https://crrev.com/776de246b0c79e64d367e09f5d7e9314a4679d70/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/776de246b0c79e64d367e09f5d7e9314a4679d70/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/776de246b0c79e64d367e09f5d7e9314a4679d70/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb6df7981e63d04deffc20bd4574914ef463639e

commit eb6df7981e63d04deffc20bd4574914ef463639e
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jan 12 00:18:37 2018

Print Preview Componentization: Make cancel button work

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iad6a4027598ddff8352b90fa570008db22453bbf
Reviewed-on: https://chromium-review.googlesource.com/862192
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528825}
[modify] https://crrev.com/eb6df7981e63d04deffc20bd4574914ef463639e/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/eb6df7981e63d04deffc20bd4574914ef463639e/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/eb6df7981e63d04deffc20bd4574914ef463639e/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/eb6df7981e63d04deffc20bd4574914ef463639e/chrome/browser/resources/print_preview/new/state.js

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7d01949fae159d74a23901db28340b431eb4fd7

commit e7d01949fae159d74a23901db28340b431eb4fd7
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 17 22:45:23 2018

Print Preview Componentization: Persist settings

Add settings persistence behavior.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id891c5c4d09571e01a3d2c7262abfe3c4dec939a
Reviewed-on: https://chromium-review.googlesource.com/860170
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529933}
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/data/margins.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/data/ticket_items/margins_type.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/browser/resources/print_preview/new/settings_behavior.js
[add] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/test/data/webui/print_preview/model_test.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/e7d01949fae159d74a23901db28340b431eb4fd7/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e217503d2b09ae16dc3d6facb88f609e6ddd597

commit 0e217503d2b09ae16dc3d6facb88f609e6ddd597
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jan 18 18:06:52 2018

Print Preview Componentization: Add Preview Area

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I892875a75643776cd87a23cce38eda850622d379
Reviewed-on: https://chromium-review.googlesource.com/851734
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530201}
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/pages_settings.js
[add] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/preview_area.html
[add] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/new/state.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/0e217503d2b09ae16dc3d6facb88f609e6ddd597/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 38 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d05338c1d602f90c446e5a923ca53577e29ba6a

commit 5d05338c1d602f90c446e5a923ca53577e29ba6a
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Jan 29 19:38:16 2018

Print Preview Componentization: Minimal destinations dialog

Displays list of destinations in dialog. Selecting does not yet work.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I07cf498a25b248b2f6e11c13e09f139aebf20184
Reviewed-on: https://chromium-review.googlesource.com/875290
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532547}
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_dialog.html
[add] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_dialog.js
[add] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_list.html
[add] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/chrome/browser/resources/print_preview/search/destination_list_item.js
[modify] https://crrev.com/5d05338c1d602f90c446e5a923ca53577e29ba6a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Project Member

Comment 39 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25d6c056b042de94865a179d8a58db249abf201

commit f25d6c056b042de94865a179d8a58db249abf201
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jan 30 17:57:15 2018

Print Preview Componentization: Destinations Dialog additions

Add the recent destinations list and search box, and enable selection
of printers using the dialog.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I157461a6a2ec5223e88b97067a4ddc8933f08ea8
Reviewed-on: https://chromium-review.googlesource.com/885502
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532939}
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/model.js
[add] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[add] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/new/print_preview_search_box.js
[modify] https://crrev.com/f25d6c056b042de94865a179d8a58db249abf201/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 40 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/956b94d45e08414c293c88a9433cbad3fa01a813

commit 956b94d45e08414c293c88a9433cbad3fa01a813
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Feb 01 06:24:29 2018

Print Preview Componentization: Destination dialog search highlighting

Add the highlighting of the search query in the destination change
dialog for Print Preview. Refactor some highlighting code out of
chrome/browser/resources/settings/search_settings.js in order to
reuse it in print_preview.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id79fdb23717c83337cc5e208331066f364b355bf
Reviewed-on: https://chromium-review.googlesource.com/892209
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533593}
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/destination_list.js
[add] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/destination_list_item.html
[add] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/destination_list_item.js
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/new/print_preview_search_box.js
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/chrome/test/data/webui/settings/search_settings_test.js
[add] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/ui/webui/resources/html/search_highlight_utils.html
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/ui/webui/resources/js/compiled_resources2.gyp
[add] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/ui/webui/resources/js/search_highlight_utils.js
[modify] https://crrev.com/956b94d45e08414c293c88a9433cbad3fa01a813/ui/webui/resources/webui_resources.grd

Project Member

Comment 41 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bdca0846b3f8954affafe83b8b95d59a9640932

commit 9bdca0846b3f8954affafe83b8b95d59a9640932
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Feb 03 01:27:32 2018

Print Preview Componentization: Destinations Dialog Fixes

- Make dialog fixed height
- Remove show all button
- Improve highlighting speed
- Do not scroll search box
- Fix problem with footer disappearing

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4d19b7fa4b2e8246eb34e8c60d10382688e6a747
Reviewed-on: https://chromium-review.googlesource.com/898347
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534232}
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/9bdca0846b3f8954affafe83b8b95d59a9640932/chrome/browser/resources/print_preview/new/destination_list_item.js

Project Member

Comment 42 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611472bd8e7c2347c480ddb0080c9b26dc2483a2

commit 611472bd8e7c2347c480ddb0080c9b26dc2483a2
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Feb 06 04:23:50 2018

Print Preview Componentization: Do not change height in JS

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7089a22f7e9ed0da2a1df1320f0a3d1e511a5c67
Reviewed-on: https://chromium-review.googlesource.com/902793
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534622}
[modify] https://crrev.com/611472bd8e7c2347c480ddb0080c9b26dc2483a2/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/611472bd8e7c2347c480ddb0080c9b26dc2483a2/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/611472bd8e7c2347c480ddb0080c9b26dc2483a2/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Project Member

Comment 43 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2

commit c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Feb 06 22:12:28 2018

Print Preview Componentization: Enable print button

Enable the print button in the new print preview UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I27a8b99e3ce23ebe718214c4eee0ab92e6b48713
Reviewed-on: https://chromium-review.googlesource.com/892399
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534814}
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/model.html
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/c228e99c73c9ff71a2f2d706e0c54bb9fc1576e2/chrome/browser/resources/print_preview/new/state.js

Blockedon: 811392
Project Member

Comment 45 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d5b83fb1a536497e67a65decaaa12ca3036f21

commit a1d5b83fb1a536497e67a65decaaa12ca3036f21
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Feb 12 23:02:26 2018

Print Preview Componentization: Add state machine

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibaf50378d72b404723b5312867710cb40b1b8df7
Reviewed-on: https://chromium-review.googlesource.com/907851
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536229}
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/color_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/dpi_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/layout_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/margins_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/media_size_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/media_size_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/settings_select.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/settings_select.js
[add] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/state.html
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/new/state.js
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/a1d5b83fb1a536497e67a65decaaa12ca3036f21/chrome/test/data/webui/print_preview/settings_section_test.js

Blockedon: 812095
Blockedon: 812092
Blockedon: 812093
Blockedon: 812097
Blockedon: 812098
Blockedon: 812099
Project Member

Comment 52 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3

commit 55fa761a3bed09caa8e6119f0b7e86dfa1e487f3
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Feb 17 02:39:37 2018

Print Preview Componentization: Add cloud print interface

Add cloud print interface, enable sign in and account selection in
destinations dialog, add capability to print to cloud printers.

Bug: 773928, 812093
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7195700506da79f33fc10bc8bdebc5f24ff2d776
Reviewed-on: https://chromium-review.googlesource.com/917220
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537513}
[add] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/cloud_print_interface.html
[add] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/data/cloud_parsers.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/data/destination_store.html
[add] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/data/invitation.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/55fa761a3bed09caa8e6119f0b7e86dfa1e487f3/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 53 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add

commit c212d47a0f03d5b2024bcc98cb7a9e0ad8725add
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Feb 17 03:52:19 2018

Print Preview Componentization: Add advanced settings

Refactor cr-dialog styling from destination settings dialog and share
with advanced settings.

Bug: 773928, 812092
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I870d5831983af5fca56986314f06deb87dc9b242
Reviewed-on: https://chromium-review.googlesource.com/920775
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537522}
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/destination_dialog.html
[add] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/c212d47a0f03d5b2024bcc98cb7a9e0ad8725add/chrome/browser/resources/print_preview/print_preview_resources.grd

Blockedon: 814861
Blockedon: 814860
Project Member

Comment 56 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486ecf9799f29b9373ce7f65cef44fb6efb88cf2

commit 486ecf9799f29b9373ce7f65cef44fb6efb88cf2
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Feb 23 14:48:52 2018

Print Preview Componentization: Fill in settings in advanced settings

Fill in the settings in the advanced settings dialog.

Bug: 773928, 812092
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If2dacbd4db65700fe56f37c55aba3e2dec7a71d7
Reviewed-on: https://chromium-review.googlesource.com/923043
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538779}
[modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[add] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[add] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/486ecf9799f29b9373ce7f65cef44fb6efb88cf2/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

Project Member

Comment 57 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fae635000c95be29576373e8748ff579eafc988d

commit fae635000c95be29576373e8748ff579eafc988d
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Feb 23 14:59:35 2018

Print Preview Componentization: Set, save and restore advanced settings

Bug: 773928, 812092
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id5ab92710d394f3382bbe79ba7c0256b8ab7b5d3
Reviewed-on: https://chromium-review.googlesource.com/924521
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538780}
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/fae635000c95be29576373e8748ff579eafc988d/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 58 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56dd8004872f9a43b403e750be73c2f9cffd028a

commit 56dd8004872f9a43b403e750be73c2f9cffd028a
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Feb 26 19:20:32 2018

Print Preview Componentization: Cache sticky settings until ready

Cache the sticky settings until the destination capabilities are known.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic7b11b3e8cb1378a9d5c5f62f5e7d2d96c82ea70
Reviewed-on: https://chromium-review.googlesource.com/935082
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539227}
[modify] https://crrev.com/56dd8004872f9a43b403e750be73c2f9cffd028a/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/56dd8004872f9a43b403e750be73c2f9cffd028a/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/56dd8004872f9a43b403e750be73c2f9cffd028a/chrome/browser/resources/print_preview/new/settings_select.html
[modify] https://crrev.com/56dd8004872f9a43b403e750be73c2f9cffd028a/chrome/browser/resources/print_preview/new/settings_select.js
[modify] https://crrev.com/56dd8004872f9a43b403e750be73c2f9cffd028a/chrome/test/data/webui/print_preview/restore_state_test.js

Blockedon: 817058
Project Member

Comment 60 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e684b898fcefae015baa9fff016c84e292d0d87f

commit e684b898fcefae015baa9fff016c84e292d0d87f
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Feb 28 05:34:30 2018

Print Preview Componentization: Add highlighting for advanced settings

Bug: 773928, 812092
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6a77a773cc1eecf91b8847c46e83626215d2b0b5
Reviewed-on: https://chromium-review.googlesource.com/927831
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539720}
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/destination_list_item.js
[add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/highlight_utils.html
[add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/new/highlight_utils.js
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/chrome/browser/resources/settings/settings_vars_css.html
[add] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements/search_highlight_style_css.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/cr_elements_resources.grdp
[modify] https://crrev.com/e684b898fcefae015baa9fff016c84e292d0d87f/ui/webui/resources/js/search_highlight_utils.js

Project Member

Comment 61 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64fc3a28ff8390201c807e3b5e17c2edd4cb8fa4

commit 64fc3a28ff8390201c807e3b5e17c2edd4cb8fa4
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Mar 06 23:06:12 2018

Add more resource IDs for print preview

They are needed for continuing work on the componentized UI.

Bug: 773928
Change-Id: I1240cf9ae8afc9befdcf89ada7fbaed5340132d2
Reviewed-on: https://chromium-review.googlesource.com/951638
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541228}
[modify] https://crrev.com/64fc3a28ff8390201c807e3b5e17c2edd4cb8fa4/tools/gritsettings/resource_ids

Project Member

Comment 62 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb

commit 97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Mar 13 21:35:09 2018

Print Preview Componentization: Add custom margins controls

Make controls appear on preview area when custom margins is selected.
Controls do not yet work.

Bug: 773928, 812095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia0319b743736717f94af65c3ef364b65f2193571
Reviewed-on: https://chromium-review.googlesource.com/935681
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542918}
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control.html
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control.js
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control_container.html
[add] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/97b85948f63bd07ff0995cb2adbab8d6d8fd6ecb/chrome/browser/resources/print_preview/print_preview_resources.grd

Cc: -rbpotter@chromium.org dpa...@chromium.org
Owner: rbpotter@chromium.org
Project Member

Comment 64 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b656a14d3b0361dddc27b2e99d16ee108b601b2f

commit b656a14d3b0361dddc27b2e99d16ee108b601b2f
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Mar 17 00:52:23 2018

Print Preview Componentization: Make custom margins movable

Make custom margins draggable and allow for updates with text boxes.
Does not yet update margins ticket item or limit margins values based
on page size.

Bug: 773928, 812095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifa0e270bb32cc77c420788dae2daecf7817c063f
Reviewed-on: https://chromium-review.googlesource.com/961483
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543892}
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control_container.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/b656a14d3b0361dddc27b2e99d16ee108b601b2f/chrome/browser/resources/print_preview/new/preview_area.js

Project Member

Comment 65 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac183b9a73e189b6510fb1aa199efbd21385490

commit dac183b9a73e189b6510fb1aa199efbd21385490
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Mar 21 18:22:26 2018

Print Preview Componentization: Fix bugs found during Windows testing

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I329273eb229f63be362e551cb67f8472e1867ae8
Reviewed-on: https://chromium-review.googlesource.com/972198
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544774}
[modify] https://crrev.com/dac183b9a73e189b6510fb1aa199efbd21385490/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/dac183b9a73e189b6510fb1aa199efbd21385490/chrome/browser/resources/print_preview/new/model.js

Project Member

Comment 66 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6a52dd5ec6dd06d549471097c6fb320d0c667e3

commit a6a52dd5ec6dd06d549471097c6fb320d0c667e3
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Mar 21 22:36:58 2018

Print Preview: Add Preview Generation tests

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If137f14a5bd9cb23585629710b62e9b018cced96
Reviewed-on: https://chromium-review.googlesource.com/969704
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544883}
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/browser/resources/print_preview/data/document_info.js
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/a6a52dd5ec6dd06d549471097c6fb320d0c667e3/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 67 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eee63eee9be83197a081b054cc5e07d0a593e58d

commit eee63eee9be83197a081b054cc5e07d0a593e58d
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Mar 28 15:55:32 2018

Print Preview Componentization: Add timeout to inputs

Add input behavior to add a timeout on inputs so that preview refresh
does not immediately freeze UI after the user makes a change.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4ac7e0f62cec6303bbf6c2ef280d0aa51ad726ae
Reviewed-on: https://chromium-review.googlesource.com/975825
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546504}
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/input_behavior.html
[add] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/eee63eee9be83197a081b054cc5e07d0a593e58d/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 68 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25671885ba7b256b1a143c95bc8372026fd9db7d

commit 25671885ba7b256b1a143c95bc8372026fd9db7d
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Mar 30 03:07:01 2018

Print Preview Componentization: Add system dialog links

Bug: 773928, 812099
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I861a40dff62c4a4fd2929ff5644a23ebad0334b7
Reviewed-on: https://chromium-review.googlesource.com/971467
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547092}
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/link_container.html
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/new/state.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/browser/resources/print_preview/print_preview_resources.grd
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/link_container_test.js
[modify] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/25671885ba7b256b1a143c95bc8372026fd9db7d/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 69 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55cbc9d778e123931b1a2901a07e25a4950f8a31

commit 55cbc9d778e123931b1a2901a07e25a4950f8a31
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Mar 30 20:31:53 2018

Print Preview Componentization: Update custom margins model, add errors

Update the model with the custom margins values, correctly initialize
custom margins values, and add error handling. Correctly update header/
footer availability based on margins.

Bug: 773928, 812095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia67e3055cd05e9cdacd29dfd1a809f7a9f1e1c8b
Reviewed-on: https://chromium-review.googlesource.com/967541
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547259}
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/data/margins.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control_container.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/margin_control_container.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/55cbc9d778e123931b1a2901a07e25a4950f8a31/chrome/browser/resources/print_preview/new/preview_area.js

Blockedon: 827579
Project Member

Comment 71 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e84bcffb42030a30cb6c2dd268866abbde4d16f

commit 2e84bcffb42030a30cb6c2dd268866abbde4d16f
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 11 00:34:49 2018

Print Preview Componentization: Port GCP Certificate Error message

Port the GCP certificate error messages
- Learn more links work
- UI shows up in preview area
- Destination information has correct styling in destination settings.

Also
- Ensure invalid printer gets set in PrintPreviewApp so that state
  is changed
- Adjust state transition logic, since the system dialog link is
  available and can be clicked in most states as long as the OS is not
  Windows.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id644932123ef570f0d304e5fc7739a9f14d6a7d9
Reviewed-on: https://chromium-review.googlesource.com/998843
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549697}
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/destination_list_item.js
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/2e84bcffb42030a30cb6c2dd268866abbde4d16f/chrome/browser/resources/print_preview/new/state.js

Project Member

Comment 72 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7554e2a1d0a8108947a624e440819bc1a3fbade

commit b7554e2a1d0a8108947a624e440819bc1a3fbade
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 11 00:47:20 2018

Print Preview Componentization: Add key event handling

Add key event handling:
- Enter key results in print
- Ctrl + shift + P brings up system dialog
- Escape key and cmd- to close (on Mac)
- Arrow keys/page up and down scroll the preview PDF

Mostly copied from the existing UI code in print_preview.js and
previewarea/preview_area.js.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I78c99c0ddacc09d598766737a3af4cdcbcca741d
Reviewed-on: https://chromium-review.googlesource.com/998345
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549702}
[modify] https://crrev.com/b7554e2a1d0a8108947a624e440819bc1a3fbade/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/b7554e2a1d0a8108947a624e440819bc1a3fbade/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/b7554e2a1d0a8108947a624e440819bc1a3fbade/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/b7554e2a1d0a8108947a624e440819bc1a3fbade/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/b7554e2a1d0a8108947a624e440819bc1a3fbade/chrome/browser/resources/print_preview/new/preview_area.js

Project Member

Comment 73 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e262bf2d7d9ba7137e600121272f7f6ad13c78

commit 05e262bf2d7d9ba7137e600121272f7f6ad13c78
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Apr 12 08:01:48 2018

Print Preview componentization: Add a timeout on search fields

Add a timeout so that the list does not immediately begin changing.
This will better match the behavior of the old UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5c9d3c3ff2ccd48b30dbb8ef34a86aceb3cbee3a
Reviewed-on: https://chromium-review.googlesource.com/1007895
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550090}
[modify] https://crrev.com/05e262bf2d7d9ba7137e600121272f7f6ad13c78/chrome/browser/resources/print_preview/new/print_preview_search_box.js

Blockedon: 832312
Project Member

Comment 75 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab81b65bae809b1a35ac4593e3e4372da179368a

commit ab81b65bae809b1a35ac4593e3e4372da179368a
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Apr 14 01:26:56 2018

Print Preview Componentization: Do not show search box for 1 item

Don't show the advanced settings search box if there is only 1
capability.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I10a759951d4abd6549443594bc6a025af21284fe
Reviewed-on: https://chromium-review.googlesource.com/1012466
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550848}
[modify] https://crrev.com/ab81b65bae809b1a35ac4593e3e4372da179368a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/ab81b65bae809b1a35ac4593e3e4372da179368a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js

Project Member

Comment 76 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9811b184a2a997d0cffe917b973ccb5a6168e1b7

commit 9811b184a2a997d0cffe917b973ccb5a6168e1b7
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Apr 16 20:13:21 2018

Print Preview componentization: Correctly setup CrOS local destinations

Chrome OS local destinations need to be set up before they can be
selected. Add the logic to request setup from the handler and select
the destination only when configuration is complete.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iccfacad27bac15182abbfeb47f4ec9f274b46fa6
Reviewed-on: https://chromium-review.googlesource.com/1012191
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551089}
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_list_item.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 77 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab81b65bae809b1a35ac4593e3e4372da179368a

commit ab81b65bae809b1a35ac4593e3e4372da179368a
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Apr 14 01:26:56 2018

Print Preview Componentization: Do not show search box for 1 item

Don't show the advanced settings search box if there is only 1
capability.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I10a759951d4abd6549443594bc6a025af21284fe
Reviewed-on: https://chromium-review.googlesource.com/1012466
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550848}
[modify] https://crrev.com/ab81b65bae809b1a35ac4593e3e4372da179368a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/ab81b65bae809b1a35ac4593e3e4372da179368a/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js

Project Member

Comment 78 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9811b184a2a997d0cffe917b973ccb5a6168e1b7

commit 9811b184a2a997d0cffe917b973ccb5a6168e1b7
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Apr 16 20:13:21 2018

Print Preview componentization: Correctly setup CrOS local destinations

Chrome OS local destinations need to be set up before they can be
selected. Add the logic to request setup from the handler and select
the destination only when configuration is complete.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iccfacad27bac15182abbfeb47f4ec9f274b46fa6
Reviewed-on: https://chromium-review.googlesource.com/1012191
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551089}
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/new/destination_list_item.js
[modify] https://crrev.com/9811b184a2a997d0cffe917b973ccb5a6168e1b7/chrome/browser/resources/print_preview/print_preview_resources.grd

Project Member

Comment 80 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e5a869079d037b19cbb08b25aa4a7d017e7c6a

commit 09e5a869079d037b19cbb08b25aa4a7d017e7c6a
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 18 17:33:41 2018

Print Preview Componentization: Port GDPR message

Port the GDPR information message for invitations to the new UI.

Also fix a styling issue with buttons (were appearing vertically
stacked).

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9c36d15ed37e82b3e3038d9dd180b420fe8ecc04
Reviewed-on: https://chromium-review.googlesource.com/1012516
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551730}
[modify] https://crrev.com/09e5a869079d037b19cbb08b25aa4a7d017e7c6a/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/09e5a869079d037b19cbb08b25aa4a7d017e7c6a/chrome/browser/resources/print_preview/new/search_dialog_css.html

Project Member

Comment 81 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd9a870691b90b812b7ab2d64a7a9667a8c6756

commit 5bd9a870691b90b812b7ab2d64a7a9667a8c6756
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Apr 24 03:34:21 2018

Print Preview Componentization: Add More Settings UI

Adds the "more settings" action link, and shows and hides sections
based on the link and their availability.

Note: This CL does not add the height animation used to show and hide
sections in the existing UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I09ddc9239ad252e151f973a793d0f57884cba5e3
Reviewed-on: https://chromium-review.googlesource.com/1019571
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552990}
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/color_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/dpi_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/layout_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/margins_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/media_size_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/media_size_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/model.js
[add] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/more_settings.html
[add] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/more_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/scaling_settings.js
[add] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/settings_section_behavior.html
[add] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/new/settings_section_behavior.js
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/5bd9a870691b90b812b7ab2d64a7a9667a8c6756/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 82 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cb83894a5abd386c847b67e957b3e3da7a015a

commit 39cb83894a5abd386c847b67e957b3e3da7a015a
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Apr 24 20:32:08 2018

Print Preview Componentization: Fix color for printers with 1 option.

For printers with only 1 option for color, the unavailable value is
used for the print ticket. This CL updates this to reflect the printer's
only color option instead of always defaulting to false.

Also add validation of the value set by default to the Color
SettingsSectionTest.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib59cb766a8590e159cd23bcceb4b45214dc76f74
Reviewed-on: https://chromium-review.googlesource.com/1025016
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553248}
[modify] https://crrev.com/39cb83894a5abd386c847b67e957b3e3da7a015a/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/39cb83894a5abd386c847b67e957b3e3da7a015a/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 83 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a24898e5688bda5a584a07503bb5ecbda2b4da0b

commit a24898e5688bda5a584a07503bb5ecbda2b4da0b
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Apr 27 00:38:11 2018

Print Preview Componentization: Make more settings link stationary

- Link no longer has background and stays fixed when clicked.
- Load in additional settings at the bottom below the link.
- Other options including duplex are always hidden unless settings
are expanded.
- Scaling, including fit to page, now always hidden unless settings
are expanded.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I708bac5ff92b449c007e3201323349921c78c1ee
Reviewed-on: https://chromium-review.googlesource.com/1027079
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554222}
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/more_settings.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/browser/resources/print_preview/new/settings_section_behavior.js
[modify] https://crrev.com/a24898e5688bda5a584a07503bb5ecbda2b4da0b/chrome/test/data/webui/print_preview/settings_section_test.js

Blockedon: 838663
Blockedon: 838664
This should now be ready for some initial testing. It would be best if we can initially focus on testing user facing issues to prepare for a Canary rollout (so no need to test chrome://print at this stage, for example), and focus on issues that are unique to the new UI rather than issues that also occur in the existing Print Preview dialog.

Please also note the following:

Known (intentional) changes from the old UI:
- More settings will look slightly different (no background, left alignment) and the link will not slide, however it should have the same effect of showing/hiding settings sections
- "Fit to Page" and "Duplex" checkboxes are now hidden by default
- Highlighting color in the destination and advanced settings dialogs is slightly different to match chrome://settings highlighting
- Backdrop color of all dialogs (destination/advanced/provisional) is darker now due to a <dialog> styling limitation (https://crbug.com/827397)

Known issues (these behaviors have not yet been migrated):
- Accepting different forms of comma in the pages field (https://crbug.com/814861)
- Kiosk printing (https://crbug.com/838663)
- Settings sections just appear/disappear without animations (have not filed a bug as we are still determining the best option here).
- Avoiding preview regeneration when margin type changes to custom, since the value of the margins does not change in this case (https://crbug.com/838664).
Project Member

Comment 87 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b7ec4fe63bbf922de538a127f1b4916d6864709

commit 8b7ec4fe63bbf922de538a127f1b4916d6864709
Author: rbpotter <rbpotter@chromium.org>
Date: Wed May 02 22:43:59 2018

Print Preview Componentization: Add string includes

Include <strings.html> wherever we rely on load_time_data or i18n.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7474fcc83359503464a99df5e4d73a152f39c50d
Reviewed-on: https://chromium-review.googlesource.com/1040274
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555586}
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/data/destination.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/8b7ec4fe63bbf922de538a127f1b4916d6864709/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html

Blockedon: -832312
Project Member

Comment 89 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3cd6611d3f78d6e0f3e92b65a0f768916151ae

commit ce3cd6611d3f78d6e0f3e92b65a0f768916151ae
Author: rbpotter <rbpotter@chromium.org>
Date: Fri May 04 04:52:37 2018

Print Preview Componentization: Add listeners for failed and presets

Add listeners for the print-failed and print-preset-options Web UI
events in the new UI, and migrate the behaviors of calling
onPrintFailed_() for print-failed and setting the copies and duplex
setting values based on the presets when they are received.

Also migrate the tests used to verify that presets work.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cb17b5a189c8d138647a82cf845a47b51d91bdf
Reviewed-on: https://chromium-review.googlesource.com/1038660
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555989}
[modify] https://crrev.com/ce3cd6611d3f78d6e0f3e92b65a0f768916151ae/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/ce3cd6611d3f78d6e0f3e92b65a0f768916151ae/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/ce3cd6611d3f78d6e0f3e92b65a0f768916151ae/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/ce3cd6611d3f78d6e0f3e92b65a0f768916151ae/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 90 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42

commit 15f31f3218d0d4417d5b9d5866f769ddbd0b3b42
Author: rbpotter <rbpotter@chromium.org>
Date: Sat May 05 01:17:45 2018

Print Preview Componentization: Use a class for getting sections

This prevents needing to have link-container implement
SettingsSectionBehavior and will allow future experimental settings
sections to be inside dom-ifs.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f7ba68318fa671e4303304da17601e60b90f7a8
Reviewed-on: https://chromium-review.googlesource.com/1045585
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556285}
[modify] https://crrev.com/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42/chrome/browser/resources/print_preview/new/compiled_resources2.gyp
[modify] https://crrev.com/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/15f31f3218d0d4417d5b9d5866f769ddbd0b3b42/chrome/browser/resources/print_preview/new/link_container.js

Project Member

Comment 91 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7

commit a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7
Author: rbpotter <rbpotter@chromium.org>
Date: Tue May 15 14:52:44 2018

Print Preview Componentization: Minimize preview regeneration, updates

- Regenerate only for destination change, not id and capabilities
- Try to reduce unnecessary updates of settings availability, by
splitting updates that are based on document info from those based
on destination.
- Do not regenerate if media size vendor ID or name changes, since this
is irrelevant to the preview generation, or when changing to custom
margins.
- Also fix the destinations dialog size, so that it does not change
height as destinations load or when a search query is entered.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6d8f7052dca89a7894160d9e4eaf32e1184c5072
Reviewed-on: https://chromium-review.googlesource.com/1054140
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558701}
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/a618ff624e1d2a45668e9d6cb7798a35ffd2c8b7/chrome/test/data/webui/print_preview/preview_generation_test.js

Project Member

Comment 92 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8211f4f7169d21f1bc9a405513b37cf283535b53

commit 8211f4f7169d21f1bc9a405513b37cf283535b53
Author: rbpotter <rbpotter@chromium.org>
Date: Tue May 15 21:07:58 2018

Print Preview Componentization: settings section animations

- Put "More settings" in an iron-collapse that opens when more settings
is clicked
- Remove settings section behavior as it is no longer needed.
- Port metrics for "more settings".

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If120534bf5abbc6fbba97e80b2d872576f10b6d8
Reviewed-on: https://chromium-review.googlesource.com/1055657
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558830}
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/color_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/dpi_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/dpi_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/layout_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/margins_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/media_size_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/media_size_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/more_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/new/scaling_settings.js
[delete] https://crrev.com/c6d31e97721f9982a5a7bcaad534fda6763e2e80/chrome/browser/resources/print_preview/new/settings_section_behavior.html
[delete] https://crrev.com/c6d31e97721f9982a5a7bcaad534fda6763e2e80/chrome/browser/resources/print_preview/new/settings_section_behavior.js
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/8211f4f7169d21f1bc9a405513b37cf283535b53/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 93 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d6263c15d92ec6fc3b590b396e103a080fc255

commit a4d6263c15d92ec6fc3b590b396e103a080fc255
Author: rbpotter <rbpotter@chromium.org>
Date: Wed May 16 18:57:09 2018

Print Preview Componentization: Add timeout to selects

Add a timeout to the select sections, so that the preview does not
immediately begin generating and freeze the dropdown when the value
is changed.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If217c25420815f56a7c37adde7e97f86bcc99fa3
Reviewed-on: https://chromium-review.googlesource.com/1056216
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559210}
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/color_settings.js
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/layout_settings.js
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/margins_settings.js
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.html
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.js
[add] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/select_behavior.html
[add] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/select_behavior.js
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/settings_select.html
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/new/settings_select.js
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/a4d6263c15d92ec6fc3b590b396e103a080fc255/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 94 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5b5c3ea5908c8a8b7337e5f676e39a07d92446

commit 1a5b5c3ea5908c8a8b7337e5f676e39a07d92446
Author: rbpotter <rbpotter@chromium.org>
Date: Wed May 16 21:24:49 2018

Print Preview Componentization: remove commented out line in test

Was accidentally introduced in https://crrev.com/c/1055657.

Bug: 773928
Change-Id: I1167284e1d03cd89154310041c1d1f64021f7725
Reviewed-on: https://chromium-review.googlesource.com/1062503
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559297}
[modify] https://crrev.com/1a5b5c3ea5908c8a8b7337e5f676e39a07d92446/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 95 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0445b563bf94987638236955a0767b94c6bc7bf6

commit 0445b563bf94987638236955a0767b94c6bc7bf6
Author: rbpotter <rbpotter@chromium.org>
Date: Thu May 17 17:27:31 2018

Print Preview Componentization: Add delay to processing checkboxes

Leave out the collate checkbox, since it does not update the preview.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9673cb3197cc724923aed36eab995948605037d7
Reviewed-on: https://chromium-review.googlesource.com/1058595
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559589}
[modify] https://crrev.com/0445b563bf94987638236955a0767b94c6bc7bf6/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/0445b563bf94987638236955a0767b94c6bc7bf6/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/0445b563bf94987638236955a0767b94c6bc7bf6/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/0445b563bf94987638236955a0767b94c6bc7bf6/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/0445b563bf94987638236955a0767b94c6bc7bf6/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 96 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cc6356bc2a6136f3b1c4602926aad443784270

commit 20cc6356bc2a6136f3b1c4602926aad443784270
Author: rbpotter <rbpotter@chromium.org>
Date: Fri May 25 01:39:19 2018

Print Preview Componentization: change more settings styling

Make entire row clickable, change icon to arrow, and restore background
styling from old UI.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7a0bf76890887e0a02cecb17d470324cab5d4ec7
Reviewed-on: https://chromium-review.googlesource.com/1071114
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561727}
[modify] https://crrev.com/20cc6356bc2a6136f3b1c4602926aad443784270/chrome/browser/resources/print_preview/new/more_settings.html

Project Member

Comment 98 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733cb7a160e6e7823f8f2fa966991f3d2348d236

commit 733cb7a160e6e7823f8f2fa966991f3d2348d236
Author: rbpotter <rbpotter@chromium.org>
Date: Thu May 31 17:27:23 2018

Print Preview Componentization: Add destination item tests

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If9c677626661d992bb031afeda4edbbee733f14d
Reviewed-on: https://chromium-review.googlesource.com/1077823
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563297}
[add] https://crrev.com/733cb7a160e6e7823f8f2fa966991f3d2348d236/chrome/test/data/webui/print_preview/destination_item_test.js
[modify] https://crrev.com/733cb7a160e6e7823f8f2fa966991f3d2348d236/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 99 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ef100e5a22fe504c8b75a5540034ce7fbabf12

commit c1ef100e5a22fe504c8b75a5540034ce7fbabf12
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 01 03:00:50 2018

Print Preview Componentization: Add tests for advanced settings items

Bug: 773928
Change-Id: I6b63eabddd5622858f16275b54546b6f8757d000
Reviewed-on: https://chromium-review.googlesource.com/1081096
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563507}
[add] https://crrev.com/c1ef100e5a22fe504c8b75a5540034ce7fbabf12/chrome/test/data/webui/print_preview/advanced_item_test.js
[modify] https://crrev.com/c1ef100e5a22fe504c8b75a5540034ce7fbabf12/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/c1ef100e5a22fe504c8b75a5540034ce7fbabf12/chrome/test/data/webui/print_preview/print_preview_test_utils.js

Project Member

Comment 100 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63ec33a3e6f86c217da3c5a836b94594a3afa8b

commit b63ec33a3e6f86c217da3c5a836b94594a3afa8b
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 01 19:32:45 2018

Print Preview Componentization: Add advanced to sticky settings tests

Add the advanced/vendor options to RestoreStateTest and ModelTest,
which verify that settings are sticky.

Bug: 773928
Change-Id: Iafabf639df0bd426c9f30133ff2a8d1aca6ecc8c
Reviewed-on: https://chromium-review.googlesource.com/1081183
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563752}
[modify] https://crrev.com/b63ec33a3e6f86c217da3c5a836b94594a3afa8b/chrome/test/data/webui/print_preview/model_test.js
[modify] https://crrev.com/b63ec33a3e6f86c217da3c5a836b94594a3afa8b/chrome/test/data/webui/print_preview/restore_state_test.js

Project Member

Comment 101 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8dae51f4129611bfc18be06ac8057494b0b432f

commit c8dae51f4129611bfc18be06ac8057494b0b432f
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 01 23:08:45 2018

Print Preview Componentization: Add more tests for advanced settings

Add some tests to verify
- Updates from sticky settings are reflected in the UI
- Apply and close buttons work correctly
- Filtering by query works

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cabaa6303a33082806d73d572fe9360f6fccb78
Reviewed-on: https://chromium-review.googlesource.com/1081950
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563850}
[modify] https://crrev.com/c8dae51f4129611bfc18be06ac8057494b0b432f/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/c8dae51f4129611bfc18be06ac8057494b0b432f/chrome/test/data/webui/print_preview/advanced_dialog_test.js
[modify] https://crrev.com/c8dae51f4129611bfc18be06ac8057494b0b432f/chrome/test/data/webui/print_preview/advanced_item_test.js
[modify] https://crrev.com/c8dae51f4129611bfc18be06ac8057494b0b432f/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 102 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d750bf29e11b031680a5f030fb14215804afd3ee

commit d750bf29e11b031680a5f030fb14215804afd3ee
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jun 05 20:27:23 2018

Print Preview Componentization: Add custom margins tests

- Set pixels and points to different values, to improve existing test.
- Test setting the margins via both dragging and textbox.
- Test that setting the settings (e.g. from sticky settings) updates
  the controls.

Bug: 773928
Change-Id: I17daf6705b6dd66cbec68577c979fa5182176288
Reviewed-on: https://chromium-review.googlesource.com/1083888
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564641}
[modify] https://crrev.com/d750bf29e11b031680a5f030fb14215804afd3ee/chrome/test/data/webui/print_preview/custom_margins_test.js
[modify] https://crrev.com/d750bf29e11b031680a5f030fb14215804afd3ee/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Cc: dschuyler@chromium.org groby@chromium.org dbeam@chromium.org
Issue 549759 has been merged into this issue.
Project Member

Comment 104 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296900491e6d65e8a82ad8b120558d9199aa2883

commit 296900491e6d65e8a82ad8b120558d9199aa2883
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Jun 18 19:28:37 2018

Print Preview Componentization: Add to upcoming UI features flag

Add new print preview to the upcoming UI features flag.

Bug: 773928
Change-Id: Ia1fe0883fba0a76b6bbf75b86b932f3b1abf0947
Reviewed-on: https://chromium-review.googlesource.com/1103292
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568105}
[modify] https://crrev.com/296900491e6d65e8a82ad8b120558d9199aa2883/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/296900491e6d65e8a82ad8b120558d9199aa2883/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Project Member

Comment 105 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0314879e66bf8bb1a35c0002b0b93e6ef67f23f

commit b0314879e66bf8bb1a35c0002b0b93e6ef67f23f
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jun 19 16:39:15 2018

Print Preview Componentization: Fix document title

Set the document title to the title of the tab being printed, so that
the task manager will show the correct task title.

Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If8f7fec12bd81cca71bdccf3fb9f040ac17bc3f0
Reviewed-on: https://chromium-review.googlesource.com/1104985
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568487}
[modify] https://crrev.com/b0314879e66bf8bb1a35c0002b0b93e6ef67f23f/chrome/browser/resources/print_preview/new/app.js

Project Member

Comment 106 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e2d32f0e4f35d89322773f5b79459c24e60fca8

commit 5e2d32f0e4f35d89322773f5b79459c24e60fca8
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jun 20 04:10:49 2018

Print Preview Componentization: Add test for destinations filtering

Add test to verify that destination filtering works correctly.

Bug: 773928
Change-Id: Id561ff1611e9de15991528002e9c5f245a6a22df
Reviewed-on: https://chromium-review.googlesource.com/1102989
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568724}
[add] https://crrev.com/5e2d32f0e4f35d89322773f5b79459c24e60fca8/chrome/test/data/webui/print_preview/destination_list_test.js
[modify] https://crrev.com/5e2d32f0e4f35d89322773f5b79459c24e60fca8/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 107 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aba0cdeb7d583126d8989f12a530306f24195aec

commit aba0cdeb7d583126d8989f12a530306f24195aec
Author: Martin Šrámek <msramek@chromium.org>
Date: Wed Jun 20 13:07:39 2018

Revert "Print Preview Componentization: Fix document title"

This reverts commit b0314879e66bf8bb1a35c0002b0b93e6ef67f23f.

Reason for revert: Seems to have broken a number of print browsertests on Win 7

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69834

Original change's description:
> Print Preview Componentization: Fix document title
> 
> Set the document title to the title of the tab being printed, so that
> the task manager will show the correct task title.
> 
> Bug: 773928
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: If8f7fec12bd81cca71bdccf3fb9f040ac17bc3f0
> Reviewed-on: https://chromium-review.googlesource.com/1104985
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568487}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Ibafe5312ce179f07a5342cd512342873ab0687f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1107897
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568811}
[modify] https://crrev.com/aba0cdeb7d583126d8989f12a530306f24195aec/chrome/browser/resources/print_preview/new/app.js

A lot of print browsertests[1] turned red after this CL[2]. Reverting.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69834
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1107897

The change is:
document.head.querySelector('title').textContent = settings.documentTitle;

The test output is:
[6180:944:0619/104553.552:ERROR:CONSOLE(290)] "Uncaught (in promise) TypeError: Cannot set property 'textContent' of null", source: chrome://print/new/app.js (290)

Cc: anthonyvd@chromium.org rbpotter@chromium.org
Issue 854614 has been merged into this issue.
Project Member

Comment 110 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f2914906d1c654de521af4bfa85dfb8b2f6587a

commit 4f2914906d1c654de521af4bfa85dfb8b2f6587a
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jun 20 22:42:10 2018

Print Preview Componentization: Fix document title correctly

Add the document title in app.js instead of print_preview_new.html.
This also ensures that the title will exist in debug build browser tests
that only create print-preview-app.

Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia9f7c01291a03011b3ffa5ec11618ed9688d4a6a
Reviewed-on: https://chromium-review.googlesource.com/1108539
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569057}
[modify] https://crrev.com/4f2914906d1c654de521af4bfa85dfb8b2f6587a/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/4f2914906d1c654de521af4bfa85dfb8b2f6587a/chrome/browser/resources/print_preview/print_preview_new.html

Project Member

Comment 111 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746926262761fa5cd4294bc488369a1ac1c74c3b

commit 746926262761fa5cd4294bc488369a1ac1c74c3b
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jun 21 00:48:34 2018

Print Preview: Fix text color in new print preview UI's cr-dialogs

The text color in new Print Preview's cr-dialogs should not change to
the same greys as for other dialogs. Fix regression introduced by
https://crrev.com/c/1102189 by overriding text color variables.

See
https://cs.chromium.org/chromium/src/ui/webui/resources/css/overlay.css?l=37
for the CSS that set this color in the old UI.

Bug: 773928
Change-Id: Ifb4636bbe239a45c4f082a956554c94905fc266e
Reviewed-on: https://chromium-review.googlesource.com/1108927
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569108}
[modify] https://crrev.com/746926262761fa5cd4294bc488369a1ac1c74c3b/chrome/browser/resources/print_preview/new/search_dialog_css.html

Issue 854647 has been merged into this issue.
Project Member

Comment 113 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abb36320279033c77498465def2d4a4387ee499

commit 0abb36320279033c77498465def2d4a4387ee499
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Jun 28 03:56:22 2018

Print Preview Componentization: Add field trial config

Bug: 773928
Change-Id: I4a9b62249ac7ac45a73fe2345e7a41bd41525d27
Reviewed-on: https://chromium-review.googlesource.com/1103305
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571023}
[modify] https://crrev.com/0abb36320279033c77498465def2d4a4387ee499/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
[modify] https://crrev.com/0abb36320279033c77498465def2d4a4387ee499/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
[modify] https://crrev.com/0abb36320279033c77498465def2d4a4387ee499/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 114 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd7852fe04f763552fe289d4ff6881e241dff6d

commit fcd7852fe04f763552fe289d4ff6881e241dff6d
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 18 07:13:03 2018

Print Preview Componentization: Update destinations more efficiently

Use ListPropertyUpdateBehavior to avoid always changing the full list
when new destinations load. Observed a ~10% improvement in time to
refresh the list when cloud destinations were added to destination
store.

Bug: 773928
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I11c00701c8c3dd1c8f3bf06937a72d3640ff43c5
Reviewed-on: https://chromium-review.googlesource.com/1141083
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575962}
[modify] https://crrev.com/fcd7852fe04f763552fe289d4ff6881e241dff6d/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/fcd7852fe04f763552fe289d4ff6881e241dff6d/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/fcd7852fe04f763552fe289d4ff6881e241dff6d/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/fcd7852fe04f763552fe289d4ff6881e241dff6d/chrome/browser/resources/print_preview/new/destination_list.js

Project Member

Comment 115 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f610e16ed42a53337df296d451e00cba8a4dd424

commit f610e16ed42a53337df296d451e00cba8a4dd424
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 13 02:12:37 2018

Print Preview Componentization: Enable by default on ToT

Bug: 773928
Change-Id: Iefebbf69e162c7f54aee3fdb67e3495357d83090
Reviewed-on: https://chromium-review.googlesource.com/1220554
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590895}
[modify] https://crrev.com/f610e16ed42a53337df296d451e00cba8a4dd424/chrome/common/chrome_features.cc

Project Member

Comment 116 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

commit e73e92b7fbf4206ffdb20282ac73bcbed7cf910e
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 13 19:22:03 2018

Update Print Preview to Material Refresh styling

Change-Id: I4c6c2a338caeca37fb407ec292f4b8eaeb3b744f
Bug: 773928
Reviewed-on: https://chromium-review.googlesource.com/1152042
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591109}
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/app/printing_strings.grdp
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/data/destination.js
[add] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/icons.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/advanced_options_settings.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/advanced_settings_item.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/app.html
[delete] https://crrev.com/974aa7b559b4361d7410479796becb0b933dc6a4/chrome/browser/resources/print_preview/new/button_css.html
[delete] https://crrev.com/974aa7b559b4361d7410479796becb0b933dc6a4/chrome/browser/resources/print_preview/new/checkbox_radio_css.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/color_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/header.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/input_behavior.js
[delete] https://crrev.com/974aa7b559b4361d7410479796becb0b933dc6a4/chrome/browser/resources/print_preview/new/input_css.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/layout_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/margin_control.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/margin_control.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/margins_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/provisional_destination_resolver.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/scaling_settings.js
[delete] https://crrev.com/974aa7b559b4361d7410479796becb0b933dc6a4/chrome/browser/resources/print_preview/new/search_dialog_css.html
[delete] https://crrev.com/974aa7b559b4361d7410479796becb0b933dc6a4/chrome/browser/resources/print_preview/new/select_css.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/settings_section.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/new/settings_select.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/previewarea/preview_area.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/print_preview_new.html
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/advanced_dialog_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/advanced_item_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/base_settings_section_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/custom_margins_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/destination_dialog_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/header_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/number_settings_section_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/print_button_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/print_header_interactive_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 117 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b47bb9f8db4b3275d13cc85b6858ae3be1fbdfb7

commit b47bb9f8db4b3275d13cc85b6858ae3be1fbdfb7
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 09 02:13:44 2018

New Print Preview: Remove testing config

The feature is now enabled by default on trunk, so there is no need
for the testing config.

Bug: 773928
Change-Id: I68331e80e3b580e4220d31aed8506d82d535cf1f
Reviewed-on: https://chromium-review.googlesource.com/c/1266735
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597782}
[modify] https://crrev.com/b47bb9f8db4b3275d13cc85b6858ae3be1fbdfb7/testing/variations/fieldtrial_testing_config.json

Showing comments 18 - 117 of 117 Older

Sign in to add a comment